OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

As an optimisation, use `TRUNCATE` on Postgres when clearing the user directory tables. (#15316)

pull/15319/head
reivilibre 2023-03-24 15:31:12 +00:00 committed by GitHub
parent 5b70f240cf
commit 5f7c908280
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/15316.misc Normal file
View File

@ -0,0 +1 @@
As an optimisation, use `TRUNCATE` on Postgres when clearing the user directory tables.

15
synapse/storage/databases/main/user_directory.py
View File

@ -698,10 +698,17 @@ class UserDirectoryBackgroundUpdateStore(StateDeltasStore):
"""Delete the entire user directory""" """Delete the entire user directory"""
def _delete_all_from_user_dir_txn(txn: LoggingTransaction) -> None: def _delete_all_from_user_dir_txn(txn: LoggingTransaction) -> None:
txn.execute("DELETE FROM user_directory") # SQLite doesn't support TRUNCATE.
txn.execute("DELETE FROM user_directory_search") # On Postgres, DELETE FROM does a table scan but TRUNCATE is more efficient.
txn.execute("DELETE FROM users_in_public_rooms") truncate = (
txn.execute("DELETE FROM users_who_share_private_rooms") "DELETE FROM"
if isinstance(self.database_engine, Sqlite3Engine)
else "TRUNCATE"
)
txn.execute(f"{truncate} user_directory")
txn.execute(f"{truncate} user_directory_search")
txn.execute(f"{truncate} users_in_public_rooms")
txn.execute(f"{truncate} users_who_share_private_rooms")
txn.call_after(self.get_user_in_directory.invalidate_all) txn.call_after(self.get_user_in_directory.invalidate_all)
await self.db_pool.runInteraction( await self.db_pool.runInteraction(