From 66debd91182c9e3f7f74c8bf2a423e2b43863203 Mon Sep 17 00:00:00 2001 From: Mathieu Velten Date: Tue, 12 Dec 2023 15:07:11 +0100 Subject: [PATCH] Update synapse/server_notices/server_notices_manager.py Co-authored-by: Erik Johnston --- synapse/server_notices/server_notices_manager.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/synapse/server_notices/server_notices_manager.py b/synapse/server_notices/server_notices_manager.py index 1c7a00330d..fc76a283db 100644 --- a/synapse/server_notices/server_notices_manager.py +++ b/synapse/server_notices/server_notices_manager.py @@ -354,7 +354,16 @@ class ServerNoticesManager: "", ) - if room_info_event and room_info_event.get(info_content_key) == info_value: + existing_info_value = None + if room_info_event: + existing_info_value = room_info_event.get(info_content_key) + if existing_info_value == info_value: + return + if not existing_info_value and not info_value: + # A missing `info_value` can either be represented by a None + # or an empty string, so we assume that if they're both falsey + # they're equivalent. + return return if info_value is None: