OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

avoid leaking twisted log events by routing them to python's logging instead

matthew/logging-memleak
Matthew Hodgson 2016-12-30 01:05:26 +00:00
parent f023be9293
commit 68f5cadcba
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
synapse/app/homeserver.py
View File

@ -38,6 +38,8 @@ from twisted.application import service
from twisted.web.resource import Resource, EncodingResourceWrapper from twisted.web.resource import Resource, EncodingResourceWrapper
from twisted.web.static import File from twisted.web.static import File
from twisted.web.server import GzipEncoderFactory from twisted.web.server import GzipEncoderFactory
from twisted.logger import globalLogBeginner, STDLibLogObserver
from synapse.http.server import RootRedirect from synapse.http.server import RootRedirect
from synapse.rest.media.v0.content_repository import ContentRepoResource from synapse.rest.media.v0.content_repository import ContentRepoResource
from synapse.rest.media.v1.media_repository import MediaRepositoryResource from synapse.rest.media.v1.media_repository import MediaRepositoryResource
@ -474,6 +476,16 @@ def run(hs):
def main(): def main():
# it's critical to point twisted's internal logging somewhere, otherwise it
# stacks up and leaks; see: https://twistedmatrix.com/trac/ticket/8164
#
# XXX: however, routing it to python.logging is apparently a perf problem
# as python.logging is a blocking API - see
# https://twistedmatrix.com/documents/current/core/howto/logger.html
# filed as https://github.com/matrix-org/synapse/issues/1727
globalLogBeginner.beginLoggingTo([STDLibLogObserver()])
with LoggingContext("main"): with LoggingContext("main"):
# check base requirements # check base requirements
check_requirements() check_requirements()