OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Comment out dodgy log-kv (#12554)

pull/12557/head
David Robertson 2022-04-26 15:53:06 +01:00 committed by GitHub
parent c48ab3734e
commit 6d89f1239c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/12554.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory handling sentry logging failures.

9
synapse/handlers/device.py
View File

@ -683,9 +683,12 @@ class DeviceHandler(DeviceWorkerHandler):
self.federation_sender.send_device_messages( self.federation_sender.send_device_messages(
host, immediate=False host, immediate=False
) )
log_kv( # TODO: when called, this isn't in a logging context.
{"message": "sent device update to host", "host": host} # This leads to log spam, sentry event spam, and massive
) # memory usage. See #12552.
# log_kv(
# {"message": "sent device update to host", "host": host}
# )
if current_stream_id != stream_id: if current_stream_id != stream_id:
# Clear the set of hosts we've already sent to as we're # Clear the set of hosts we've already sent to as we're