OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Avoid no-op media deletes 

If there are no media entries to delete,
avoid creating transactions, prepared statements
and unnecessary log entries.

Signed-off-by: Slavi Pantaleev <slavi@devture.com>
pull/2637/head
Slavi Pantaleev 2017-11-04 09:47:25 +02:00
parent f851bc8182
commit 805196fbeb
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
synapse/storage/media_repository.py
View File

@ -254,6 +254,9 @@ class MediaRepositoryStore(SQLBaseStore):
return self.runInteraction("get_expired_url_cache", _get_expired_url_cache_txn) return self.runInteraction("get_expired_url_cache", _get_expired_url_cache_txn)
def delete_url_cache(self, media_ids): def delete_url_cache(self, media_ids):
if len(media_ids) == 0:
return
sql = ( sql = (
"DELETE FROM local_media_repository_url_cache" "DELETE FROM local_media_repository_url_cache"
" WHERE media_id = ?" " WHERE media_id = ?"
@ -281,6 +284,9 @@ class MediaRepositoryStore(SQLBaseStore):
) )
def delete_url_cache_media(self, media_ids): def delete_url_cache_media(self, media_ids):
if len(media_ids) == 0:
return
def _delete_url_cache_media_txn(txn): def _delete_url_cache_media_txn(txn):
sql = ( sql = (
"DELETE FROM local_media_repository" "DELETE FROM local_media_repository"