Fixup changelog and remove debug logging

pull/5850/head
Erik Johnston 2019-08-16 13:15:26 +01:00
parent 1771f0045d
commit 861d663c15
3 changed files with 2 additions and 5 deletions

1
changelog.d/5850.feature Normal file
View File

@ -0,0 +1 @@
Add retry to well-known lookups if we have recently seen a valid well-known record for the server.

View File

@ -1 +0,0 @@
Retry well-known lookups if we have recently seen a valid well-known record for the server.

View File

@ -163,9 +163,7 @@ class WellKnownResolver(object):
Deferred[Tuple[bytes,int]]: The lookup result and cache period.
"""
had_valid_well_known = bool(
self._had_valid_well_known_cache.get(server_name, False)
)
had_valid_well_known = self._had_valid_well_known_cache.get(server_name, False)
# We do this in two steps to differentiate between possibly transient
# errors (e.g. can't connect to host, 503 response) and more permenant
@ -247,7 +245,6 @@ class WellKnownResolver(object):
# Bail if we've been cancelled
raise
except Exception as e:
logger.info("Retry: %s", retry)
if not retry or i >= WELL_KNOWN_RETRY_ATTEMPTS:
logger.info("Error fetching %s: %s", uri_str, e)
raise _FetchWellKnownFailure(temporary=True)