OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Correct type hint for room_batch.py (#11310) 

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
pull/11315/head
David Robertson 2021-11-11 16:49:28 +00:00 committed by GitHub
parent 48278a0d09
commit 8dc666f785
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/11310.misc Normal file
View File

@ -0,0 +1 @@
Add type hints to storage classes.

4
mypy.ini
View File

@ -46,7 +46,6 @@ exclude = (?x)
|synapse/storage/databases/main/push_rule.py |synapse/storage/databases/main/push_rule.py
|synapse/storage/databases/main/receipts.py |synapse/storage/databases/main/receipts.py
|synapse/storage/databases/main/room.py |synapse/storage/databases/main/room.py
|synapse/storage/databases/main/room_batch.py
|synapse/storage/databases/main/roommember.py |synapse/storage/databases/main/roommember.py
|synapse/storage/databases/main/search.py |synapse/storage/databases/main/search.py
|synapse/storage/databases/main/signatures.py |synapse/storage/databases/main/signatures.py
@ -183,6 +182,9 @@ disallow_untyped_defs = True
[mypy-synapse.storage.databases.main.client_ips] [mypy-synapse.storage.databases.main.client_ips]
disallow_untyped_defs = True disallow_untyped_defs = True
[mypy-synapse.storage.databases.main.room_batch]
disallow_untyped_defs = True
[mypy-synapse.storage.util.*] [mypy-synapse.storage.util.*]
disallow_untyped_defs = True disallow_untyped_defs = True

18
synapse/storage/databases/main/room_batch.py
View File

@ -39,13 +39,11 @@ class RoomBatchStore(SQLBaseStore):
async def store_state_group_id_for_event_id( async def store_state_group_id_for_event_id(
self, event_id: str, state_group_id: int self, event_id: str, state_group_id: int
) -> Optional[str]: ) -> None:
{ await self.db_pool.simple_upsert(
await self.db_pool.simple_upsert( table="event_to_state_groups",
table="event_to_state_groups", keyvalues={"event_id": event_id},
keyvalues={"event_id": event_id}, values={"state_group": state_group_id, "event_id": event_id},
values={"state_group": state_group_id, "event_id": event_id}, # Unique constraint on event_id so we don't have to lock
# Unique constraint on event_id so we don't have to lock lock=False,
lock=False, )
)
}