From 8ecdfa29c4c606ce1752ce2498998817ca454f4a Mon Sep 17 00:00:00 2001 From: Patrick Cloke Date: Fri, 26 Aug 2022 15:01:10 -0400 Subject: [PATCH] Disable unread counts. --- synapse/push/bulk_push_rule_evaluator.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/synapse/push/bulk_push_rule_evaluator.py b/synapse/push/bulk_push_rule_evaluator.py index 713dcf6950..6840ef5437 100644 --- a/synapse/push/bulk_push_rule_evaluator.py +++ b/synapse/push/bulk_push_rule_evaluator.py @@ -251,7 +251,9 @@ class BulkPushRuleEvaluator: # This can happen due to out of band memberships return - count_as_unread = _should_count_as_unread(event, context) + # Disable counting as unread as it is unused and can cause additional + # (unwanted) rows to be added to the event_push_actions table. + count_as_unread = False rules_by_user = await self._get_rules_for_event(event) actions_by_user: Dict[str, List[Union[dict, str]]] = {}