Fix PeriodicallyFlushingMemoryHandler inhibiting application shutdown (#10517)

2021-08-03 14:28:30 +01:00 · 2021-08-03 14:28:30 +01:00 · 903db99ed5
parent 6878e10653
commit 903db99ed5
2 changed files with 2 additions and 0 deletions
--- a/changelog.d/10517.bugfix
+++ b/changelog.d/10517.bugfix
@ -0,0 +1 @@
+Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.
--- a/synapse/logging/handlers.py
+++ b/synapse/logging/handlers.py
@ -45,6 +45,7 @@ class PeriodicallyFlushingMemoryHandler(MemoryHandler):
        self._flushing_thread: Thread = Thread(
            name="PeriodicallyFlushingMemoryHandler flushing thread",
            target=self._flush_periodically,
+            daemon=True,
        )
        self._flushing_thread.start()
				`@ -0,0 +1 @@`
				Fix the `PeriodicallyFlushingMemoryHandler` inhibiting application shutdown because of its background thread.