OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Disable aggregation bundling on `/sync` responses 

A partial revert of #11478. This turns out to have had a significant CPU impact
on initial-sync handling. For now, let's disable it, until we find a more
efficient way of achieving this.
pull/11583/head
Richard van der Hoff 2021-12-15 13:08:24 +00:00
parent 26b5d2320f
commit a9c146ac53
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/11583.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a performance regression in `/sync` handling, introduced in 1.49.0.

8
synapse/rest/client/sync.py
View File

@ -522,7 +522,13 @@ class SyncRestServlet(RestServlet):
time_now=time_now, time_now=time_now,
# Don't bother to bundle aggregations if the timeline is unlimited, # Don't bother to bundle aggregations if the timeline is unlimited,
# as clients will have all the necessary information. # as clients will have all the necessary information.
bundle_aggregations=room.timeline.limited, # bundle_aggregations=room.timeline.limited,
#
# richvdh 2021-12-15: disable this temporarily as it has too high an
# overhead for initialsyncs. We need to figure out a way that the
# bundling can be done *before* the events are stored in the
# SyncResponseCache so that this part can be synchronous.
bundle_aggregations=False,
token_id=token_id, token_id=token_id,
event_format=event_formatter, event_format=event_formatter,
only_event_fields=only_fields, only_event_fields=only_fields,