Call RetryLimiter correctly (#5340)

Fixes a regression introduced in #5335.
2019-06-04 22:02:53 +01:00 · 2019-06-04 22:02:53 +01:00 · aa530e6800
parent dae224a73f
commit aa530e6800
2 changed files with 8 additions and 1 deletions
--- a/changelog.d/5340.bugfix
+++ b/changelog.d/5340.bugfix
@ -0,0 +1,2 @@
+Fix a bug where we could rapidly mark a server as unreachable even though it was only down for a few minutes.
+
--- a/synapse/util/retryutils.py
+++ b/synapse/util/retryutils.py
@ -97,7 +97,12 @@ def get_retry_limiter(destination, clock, store, ignore_backoff=False, **kwargs)

    defer.returnValue(
        RetryDestinationLimiter(
-            destination, clock, store, retry_interval, backoff_on_failure, **kwargs
+            destination,
+            clock,
+            store,
+            retry_interval,
+            backoff_on_failure=backoff_on_failure,
+            **kwargs
        )
    )
				`@ -0,0 +1,2 @@`
				`Fix a bug where we could rapidly mark a server as unreachable even though it was only down for a few minutes.`