Wrap get_verify_key_from_cross_signing_key in a try/except

pull/7289/head
Andrew Morgan 2020-04-16 17:51:00 +01:00
parent 03d2c8c65b
commit b386658d28
1 changed files with 5 additions and 2 deletions

View File

@ -1031,8 +1031,11 @@ class E2eKeysHandler(object):
logger.debug("No %s key found for %s", key_type, user_id) logger.debug("No %s key found for %s", key_type, user_id)
raise NotFoundError("No %s key found for %s" % (key_type, user_id)) raise NotFoundError("No %s key found for %s" % (key_type, user_id))
key_id, verify_key = get_verify_key_from_cross_signing_key(key) try:
return key, key_id, verify_key key_id, verify_key = get_verify_key_from_cross_signing_key(key)
return key, key_id, verify_key
except ValueError:
raise SynapseError(502, "Invalid %s key retrieved from remote server")
def _check_cross_signing_key(key, user_id, key_type, signing_key=None): def _check_cross_signing_key(key, user_id, key_type, signing_key=None):