OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix subscriptable type usage in Python <3.9 (#15604) 

Fix the following `mypy` errors when running `mypy` with Python 3.7:
```
synapse/storage/controllers/stats.py:58: error: "Counter" is not subscriptable, use "typing.Counter" instead  [misc]

tests/test_state.py:267: error: "dict" is not subscriptable, use "typing.Dict" instead  [misc]
```

Part of https://github.com/matrix-org/synapse/issues/15603

In Python 3.9, `typing` is deprecated and the types are subscriptable (generics) by default, https://peps.python.org/pep-0585/#implementation
pull/15606/head
Eric Eastwood 2023-05-16 12:19:46 -05:00 committed by GitHub
parent 0ccfb9318c
commit c51d2e6199
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/15604.misc Normal file
View File

@ -0,0 +1 @@
Fix subscriptable type usage in Python <3.9.

3
synapse/storage/controllers/stats.py
View File

@ -13,8 +13,7 @@
# limitations under the License. # limitations under the License.
import logging import logging
from collections import Counter from typing import TYPE_CHECKING, Collection, Counter, List, Tuple
from typing import TYPE_CHECKING, Collection, List, Tuple
from synapse.api.errors import SynapseError from synapse.api.errors import SynapseError
from synapse.storage.database import LoggingTransaction from synapse.storage.database import LoggingTransaction

2
tests/test_state.py
View File

@ -264,7 +264,7 @@ class StateTestCase(unittest.TestCase):
self.dummy_store.register_events(graph.walk()) self.dummy_store.register_events(graph.walk())
context_store: dict[str, EventContext] = {} context_store: Dict[str, EventContext] = {}
for event in graph.walk(): for event in graph.walk():
context = yield defer.ensureDeferred( context = yield defer.ensureDeferred(