OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove fixed and flakey tests from the sytest blacklist (#10788) 

We want to blacklist only known, consistent failures. We should deflake tests rather than ignoring them.
pull/10795/head
David Robertson 2021-09-10 10:53:04 +01:00 committed by GitHub
parent 0c0da36a68
commit c6f5fb5477
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.ci/worker-blacklist
View File

@ -1,10 +1,2 @@
# This file serves as a blacklist for SyTest tests that we expect will fail in # This file serves as a blacklist for SyTest tests that we expect will fail in
# Synapse when run under worker mode. For more details, see sytest-blacklist. # Synapse when run under worker mode. For more details, see sytest-blacklist.
Can re-join room if re-invited
# new failures as of https://github.com/matrix-org/sytest/pull/732
Device list doesn't change if remote server is down
# https://buildkite.com/matrix-dot-org/synapse/builds/6134#6f67bf47-e234-474d-80e8-c6e1868b15c5
Server correctly handles incoming m.device_list_update

1
changelog.d/10788.misc Normal file
View File

@ -0,0 +1 @@
Remove fixed and flakey tests from the sytest-blacklist.

11
sytest-blacklist
View File

@ -1,5 +1,5 @@
# This file serves as a blacklist for SyTest tests that we expect will fail in # This file serves as a blacklist for SyTest tests that we expect will fail in
# Synapse. # Synapse. This doesn't include flakey tests---better to deflake them instead.
# #
# Each line of this file is scanned by sytest during a run and if the line # Each line of this file is scanned by sytest during a run and if the line
# exactly matches the name of a test, it will be marked as "expected fail", # exactly matches the name of a test, it will be marked as "expected fail",
@ -9,9 +9,6 @@
# Test names are encouraged to have a bug accompanied with them, serving as an # Test names are encouraged to have a bug accompanied with them, serving as an
# explanation for why the test has been excluded. # explanation for why the test has been excluded.
# Blacklisted due to https://github.com/matrix-org/synapse/issues/1679
Remote room members also see posted message events
# Blacklisted due to https://github.com/matrix-org/synapse/issues/2065 # Blacklisted due to https://github.com/matrix-org/synapse/issues/2065
Guest users can accept invites to private rooms over federation Guest users can accept invites to private rooms over federation
@ -24,12 +21,6 @@ Newly created users see their own presence in /initialSync (SYT-34)
# Blacklisted due to https://github.com/matrix-org/synapse/issues/1396 # Blacklisted due to https://github.com/matrix-org/synapse/issues/1396
Should reject keys claiming to belong to a different user Should reject keys claiming to belong to a different user
# Blacklisted due to https://github.com/matrix-org/synapse/issues/1531
Enabling an unknown default rule fails with 404
# Blacklisted due to https://github.com/matrix-org/synapse/issues/1663
New federated private chats get full presence information (SYN-115)
# Blacklisted due to https://github.com/matrix-org/matrix-doc/pull/2314 removing # Blacklisted due to https://github.com/matrix-org/matrix-doc/pull/2314 removing
# this requirement from the spec # this requirement from the spec
Inbound federation of state requires event_id as a mandatory paramater Inbound federation of state requires event_id as a mandatory paramater