Don't yield in list comprehensions

I've tried to grep for more of this with no success.

Signed-off-by: Adrian Tschira <nota@notafile.com>
pull/3150/head
Adrian Tschira 2018-04-28 13:04:40 +02:00
parent 9558236728
commit cdb4647a80
1 changed files with 9 additions and 5 deletions

View File

@ -259,11 +259,15 @@ class ApplicationServicesHandler(object):
event based on the service regex.
"""
services = self.store.get_app_services()
interested_list = [
s for s in services if (
yield s.is_interested(event, self.store)
)
]
# we can't use a list comprehension here. Since python 3, list
# comprehensions use a generator internally. This means you can't yield
# inside of a list comprehension anymore.
interested_list = []
for s in services:
if (yield s.is_interested(event, self.store)):
interested_list.append(s)
defer.returnValue(interested_list)
def _get_services_for_user(self, user_id):