Code style

synapse/http/site.py

@@ -239,7 +239,7 @@ class SynapseRequest(Request):
 
         # Start a span
         span_context = extract_span_context(self.requestHeaders)
-        span = opentracing.tracer.start_active_span(
+        opentracing.tracer.start_active_span(
             "incoming-federation-request",
             tags={
                 "request_id": self.get_request_id(),

synapse/util/scopecontextmanager.py

@@ -15,8 +15,8 @@ class LogContextScopeManager(ScopeManager):
     def __init__(self, config):
         # Set the whitelists
         logger.info(config.tracer_config)
-        _homeserver_whitelist = config.tracer_config["homeserver_whitelist"]
-        _user_whitelist = config.tracer_config["user_whitelist"]
+        self._homeserver_whitelist = config.tracer_config["homeserver_whitelist"]
+        self._user_whitelist = config.tracer_config["user_whitelist"]
 
     @property
     def active(self):

synapse/util/tracerutils.py

@@ -1,8 +1,6 @@
 import opentracing
 from opentracing.propagation import Format
 
-from .logcontext import LoggingContext
-
 
 def extract_span_context(headers):
     """