OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve the error message printed by synctl when synapse fails to start. (#10059)

pull/10084/head
Richard van der Hoff 2021-05-27 10:35:06 +01:00 committed by GitHub
parent 5447a76332
commit dcbfec919b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/10059.misc Normal file
View File

@ -0,0 +1 @@
Improve the error message printed by synctl when synapse fails to start.

12
synctl
View File

@ -97,11 +97,15 @@ def start(pidfile: str, app: str, config_files: Iterable[str], daemonize: bool)
write("started %s(%s)" % (app, ",".join(config_files)), colour=GREEN) write("started %s(%s)" % (app, ",".join(config_files)), colour=GREEN)
return True return True
except subprocess.CalledProcessError as e: except subprocess.CalledProcessError as e:
write( err = "%s(%s) failed to start (exit code: %d). Check the Synapse logfile" % (
"error starting %s(%s) (exit code: %d); see above for logs" app,
% (app, ",".join(config_files), e.returncode), ",".join(config_files),
colour=RED, e.returncode,
) )
if daemonize:
err += ", or run synctl with --no-daemonize"
err += "."
write(err, colour=RED, stream=sys.stderr)
return False return False