pin urllib3 to <1.25

2019-05-03 18:30:13 +01:00 · 2019-05-03 18:30:13 +01:00 · e3281d7d26
parent f73f18fe7b
commit e3281d7d26
1 changed files with 8 additions and 0 deletions
--- a/synapse/python_dependencies.py
+++ b/synapse/python_dependencies.py
@ -69,6 +69,14 @@ REQUIREMENTS = [
    "attrs>=17.4.0",

    "netaddr>=0.7.18",
+
+    # requests is a transitive dep of treq, and urlib3 is a transitive dep
+    # of requests, as well as of sentry-sdk.
+    #
+    # As of requests 2.21, requests does not yet support urllib3 1.25.
+    # (If we do not pin it here, pip will give us the latest urllib3
+    # due to the dep via sentry-sdk.)
+    "urllib3<1.25",
 ]

 CONDITIONAL_REQUIREMENTS = {