Merge pull request #2566 from matrix-org/rav/media_logcontext_leak
Fix a logcontext leak in the media repopull/2074/merge
						commit
						ecf198aab8
					
				| 
						 | 
				
			
			@ -17,6 +17,7 @@ from synapse.http.server import respond_with_json, finish_request
 | 
			
		|||
from synapse.api.errors import (
 | 
			
		||||
    cs_error, Codes, SynapseError
 | 
			
		||||
)
 | 
			
		||||
from synapse.util import logcontext
 | 
			
		||||
 | 
			
		||||
from twisted.internet import defer
 | 
			
		||||
from twisted.protocols.basic import FileSender
 | 
			
		||||
| 
						 | 
				
			
			@ -103,7 +104,9 @@ def respond_with_file(request, media_type, file_path,
 | 
			
		|||
        )
 | 
			
		||||
 | 
			
		||||
        with open(file_path, "rb") as f:
 | 
			
		||||
            yield FileSender().beginFileTransfer(f, request)
 | 
			
		||||
            yield logcontext.make_deferred_yieldable(
 | 
			
		||||
                FileSender().beginFileTransfer(f, request)
 | 
			
		||||
            )
 | 
			
		||||
 | 
			
		||||
        finish_request(request)
 | 
			
		||||
    else:
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
		Reference in New Issue