OpenCloud
/
MatrixSynapse
mirror of https://github.com/matrix-org/synapse
1
0
Fork 0
Code Issues Releases Wiki Activity

Enforce all replication HTTP clients calls use kwargs (#9144)

pull/9161/head
Erik Johnston 2021-01-18 15:24:04 +00:00 committed by GitHub
parent 2b467d0b61
commit f08ef64926
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/9144.misc Normal file
View File

@ -0,0 +1 @@
Enforce that replication HTTP clients are called with keyword arguments only.

2
synapse/replication/http/_base.py
View File

@ -177,7 +177,7 @@ class ReplicationEndpoint(metaclass=abc.ABCMeta):
@trace(opname="outgoing_replication_request") @trace(opname="outgoing_replication_request")
@outgoing_gauge.track_inprogress() @outgoing_gauge.track_inprogress()
async def send_request(instance_name="master", **kwargs): async def send_request(*, instance_name="master", **kwargs):
if instance_name == local_instance_name: if instance_name == local_instance_name:
raise Exception("Trying to send HTTP request to self") raise Exception("Trying to send HTTP request to self")
if instance_name == "master": if instance_name == "master":