Fix exceptions on requests for non-ascii urls (#6682)

Fixes #6402
2020-01-13 12:41:51 +00:00 · 2020-01-13 12:41:51 +00:00 · feee819973
parent da4e52544e
commit feee819973
2 changed files with 3 additions and 1 deletions
--- a/changelog.d/6682.bugfix
+++ b/changelog.d/6682.bugfix
@ -0,0 +1,2 @@
+Fix "CRITICAL" errors being logged when a request is received for a uri containing non-ascii characters.
+
--- a/synapse/http/site.py
+++ b/synapse/http/site.py
@ -88,7 +88,7 @@ class SynapseRequest(Request):
    def get_redacted_uri(self):
        uri = self.uri
        if isinstance(uri, bytes):
-            uri = self.uri.decode("ascii")
+            uri = self.uri.decode("ascii", errors="replace")
        return redact_uri(uri)

    def get_method(self):
				`@ -0,0 +1,2 @@`
				`Fix "CRITICAL" errors being logged when a request is received for a uri containing non-ascii characters.`