2c6a7dfcbf
Use attempt_to_set_autocommit everywhere. ( #16615 )
...
To avoid asserting the type of the database connection.
2023-11-09 16:19:42 -05:00
dc7f068d9c
Fix a long-standing bug where Synapse would not unbind third-party identifiers for Application Service users when deactivated and would not emit a compliant response. ( #16617 )
...
* Don't skip unbinding 3PIDs and returning success status when deactivating AS user
Fixes #16608
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-11-09 20:18:25 +00:00
bc4372ad81
Use dbname instead of database for Postgres config. ( #16618 )
2023-11-09 14:40:45 -05:00
9f514dd0fb
Use _invalidate_cache_and_stream_bulk in more places. ( #16616 )
...
This takes advantage of the new bulk method in more places to
invalidate caches for many keys at once (and then to stream that
over replication).
2023-11-09 14:40:30 -05:00
ab3f1b3b53
Convert simple_select_one_txn and simple_select_one to return tuples. ( #16612 )
2023-11-09 11:13:31 -05:00
ff716b483b
Return attrs for more media repo APIs. ( #16611 )
2023-11-09 11:00:30 -05:00
91587d4cf9
Bulk-invalidate e2e cached queries after claiming keys ( #16613 )
...
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2023-11-09 15:57:09 +00:00
f6aa047aa2
Bump pyicu from 2.11 to 2.12 ( #16603 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-08 09:28:51 -05:00
2a336cd2fc
Bump serde_json from 1.0.107 to 1.0.108 ( #16604 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-08 09:27:51 -05:00
455ef04187
Avoid updating the same rows multiple times with simple_update_many_txn. ( #16609 )
...
simple_update_many_txn had a bug in it which would cause each
update to be applied twice.
2023-11-07 14:02:09 -05:00
9738b1c497
Avoid executing no-op queries. ( #16583 )
...
If simple_{insert,upsert,update}_many_txn is called without any data
to modify then return instead of executing the query.
This matches the behavior of simple_{select,delete}_many_txn.
2023-11-07 14:00:25 -05:00
ec9ff389f4
More tests for the simple_* methods. ( #16596 )
...
Expand tests for the simple_* database methods, additionally
test against both PostgreSQL and SQLite variants.
2023-11-07 09:34:23 -05:00
7e5d3b06fa
Collect information for PushRuleEvaluator in parallel. ( #16590 )
...
Fetch information needed for push rule evaluation in parallel.
Ideally this would use query pipelining, but this is not
available in psycopg2.
Due to the database thread pool this may result in little
to no parallelization.
2023-11-06 15:41:57 -05:00
1dd3074629
Bump setuptools_rust to match pinned version. ( #16605 )
2023-11-06 09:13:53 -05:00
cc4fe68adf
Support reactor timing metric on more reactors. ( #16532 )
...
Previously only Twisted's EPollReactor was compatible with the
reactor timing metric, notably not working when asyncio was used.
After this change, the following configurations support the reactor
timing metric:
* poll, epoll, or select reactors
* asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.
2023-11-06 08:31:22 -05:00
1a9b22a3d1
Bump setuptools-rust from 1.8.0 to 1.8.1 ( #16601 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-06 08:12:18 -05:00
5cf2988694
Bump types-pyyaml from 6.0.12.11 to 6.0.12.12 ( #16602 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-06 08:12:01 -05:00
a28339b867
Bump types-jsonschema from 4.19.0.3 to 4.19.0.4 ( #16599 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-06 08:11:31 -05:00
2f689a6326
Bump ruff from 0.0.292 to 0.1.4 ( #16600 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-06 08:11:15 -05:00
92828a7f95
Simplify event persistence code ( #16584 )
...
The event persistence code used to handle multiple rooms
at a time, but was simplified to only ever be called with a
single room at a time (different rooms are now handled in
parallel). The code is still generic to multiple rooms causing
a lot of work that is unnecessary (e.g. unnecessary loops, and
partitioning data by room).
This strips out the ability to handle multiple rooms at once, greatly
simplifying the code.
2023-11-03 07:30:31 -04:00
0afbef30cf
Use simple_select_many_txn in event persistance code. ( #16585 )
...
Just to standardize on the normal helpers, it might also have
a slight perf improvement on PostgreSQL which will now use
`ANY (?)` instead of `IN (?, ?, ...)`.
2023-11-02 09:41:00 -04:00
c812f43bd7
Bump twisted from 23.8.0 to 23.10.0 ( #16588 )
2023-11-01 10:23:13 +00:00
ed1b879576
Do not call getfullargspec on every call. ( #16589 )
...
getfullargspec is relatively expensive and the results will
not change between calls, so precalculate it outside the
wrapper.
2023-10-31 20:16:17 +00:00
cfb6d38c47
Remove remaining usage of cursor_to_dict. ( #16564 )
2023-10-31 13:13:28 -04:00
c0ba319b22
Merge branch 'release-v1.96' into develop
2023-10-31 16:30:16 +00:00
70b503f144
Fix import ordering issue introduced in 7a3a55ac98.
2023-10-31 10:32:35 -04:00
c5b543938b
Update changelog
2023-10-31 14:17:27 +00:00
4bb2b4aa9a
1.96.0rc1
2023-10-31 14:09:13 +00:00
1f033ad5e4
Merge remote-tracking branch 'origin/develop' into release-v1.96
2023-10-31 14:08:51 +00:00
60c5e8d79b
Revert "1.96.0rc1"
...
This reverts commit 4724a6ded1
2023-10-31 14:08:45 +00:00
0cc6509cfe
Merge branch 'release-v1.95' into develop
2023-10-31 14:05:52 +00:00
a11511954a
1.95.1
2023-10-31 14:02:32 +00:00
daec55e1fe
Merge pull request from GHSA-mp92-3jfm-3575
2023-10-31 13:59:09 +00:00
7a3a55ac98
Merge pull request from GHSA-mp92-3jfm-3575
2023-10-31 13:58:30 +00:00
4724a6ded1
1.96.0rc1
2023-10-31 13:47:08 +00:00
de981ae567
Claim local one-time-keys in bulk ( #16565 )
...
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-10-30 21:25:21 +00:00
91aa52c911
Clients link fixed in README ( #16569 )
2023-10-30 16:05:34 +00:00
408c13801a
Add fast path for replication events stream fetch ( #16580 )
...
We can bail early if the from token is greater than or equal to the
current token.
2023-10-30 14:47:57 +00:00
fdce83ee60
Claim fallback keys in bulk ( #16570 )
2023-10-30 14:34:37 +00:00
a3f6200d65
Bump setuptools-rust from 1.7.0 to 1.8.0 ( #16574 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-10-30 13:40:17 +00:00
4e1a19d375
Run actions/setup-go after checking out complement ( #16567 )
2023-10-30 13:07:08 +00:00
8c63e93286
Fix HTTP repl response to use minimum token ( #16578 )
2023-10-30 12:27:14 +00:00
ba55835000
Bump cryptography from 41.0.4 to 41.0.5 ( #16572 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 11:44:36 +00:00
8f7cd4cd03
Bump serde from 1.0.189 to 1.0.190 ( #16577 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 11:32:36 +00:00
425cb9c23c
Bump phonenumbers from 8.13.22 to 8.13.23 ( #16576 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 11:30:26 +00:00
13f6467785
Bump black from 23.10.0 to 23.10.1 ( #16575 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 11:29:52 +00:00
bcaaeab410
Bump types-psycopg2 from 2.9.21.14 to 2.9.21.15 ( #16573 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-10-30 11:28:50 +00:00
747416e94c
Portdb: don't copy a table that gets rebuilt ( #16563 )
2023-10-27 20:14:02 +01:00
11a8ae0632
complement: enable dirty runs ( #16520 )
...
* complement: enable dirty runs
* Add changelog
* Set a low connpool limit when running in Complement
Dirty runs can cause many containers to be running concurrently,
which seems to easily exhaust resources on the host. The increased
speedup from dirty runs also seems to use more db connections on
workers, which are misconfigured currently to have
`SUM(workers * cp_max) > max_connections`, causing
```
FATAL: sorry, too many clients already
```
which results in tests failing.
* Try p=2 concurrency to restrict slowness of servers which causes partial state join tests to flake
* Debug logging
* Only run flakey tests
* Only adjust connection pool limits in worker mode
* Move cp vars to somewhere where they get executed in CI
* Move cp values back to where they actually work
* Debug logging
* Try p=1 to see if this makes worker mode happier
* Remove debug logging
2023-10-27 18:29:20 +01:00
2bf9341406
Ensure local invited & knocking users leave before purge. ( #16559 )
...
This is mostly useful for federated rooms where some users
would get stuck in the invite or knock state when the room
was purged from their homeserver.
2023-10-27 12:50:50 -04:00
Patrick Cloke