b1d71c687a
Add MSC4040 `matrix-fed` service lookups ( #16137 )
2023-09-05 15:45:39 -04:00
c9cec2daed
Fix bug where we kept re-requesting a remote server's key repeatedly. ( #16257 )
...
* Correctly handle multiple rows per server/key
* Newsfile
2023-09-05 20:27:41 +01:00
a2b8814d64
Fix incorrect docstring for Ratelimiter. ( #16255 )
2023-09-05 12:11:05 -04:00
02bc5906ec
- Add configuration setting for CAS protocol version. Contributed by Aurélien Grimpard. ([\#15816]( https://github.com/matrix-org/synapse/issues/15816 ))
...
- Suppress notifications from message edits per [MSC3958](https://github.com/matrix-org/matrix-spec-proposals/pull/3958 ). ([\#16113](https://github.com/matrix-org/synapse/issues/16113 ))
- Return a `Retry-After` with `M_LIMIT_EXCEEDED` error responses. ([\#16136](https://github.com/matrix-org/synapse/issues/16136 ))
- Add `last_seen_ts` to the [admin users API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html ). ([\#16218](https://github.com/matrix-org/synapse/issues/16218 ))
- Improve resource usage when sending data to a large number of remote hosts that are marked as "down". ([\#16223](https://github.com/matrix-org/synapse/issues/16223 ))
- Fix IPv6-related bugs on SMTP settings, adding groundwork to fix similar issues. Contributed by @evilham and @telmich (ungleich.ch). ([\#16155](https://github.com/matrix-org/synapse/issues/16155 ))
- Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `include_all_networks` as a string. ([\#16185](https://github.com/matrix-org/synapse/issues/16185 ))
- Fix inaccurate error message while attempting to ban or unban a user with the same or higher PL by spliting the conditional statements. Contributed by @leviosacz. ([\#16205](https://github.com/matrix-org/synapse/issues/16205 ))
- Fix a rare bug that broke looping calls, which could lead to e.g. linearly increasing memory usage. Introduced in v1.90.0. ([\#16210](https://github.com/matrix-org/synapse/issues/16210 ))
- Fix a long-standing bug where uploading images would fail if we could not generate thumbnails for them. ([\#16211](https://github.com/matrix-org/synapse/issues/16211 ))
- Fix a long-standing bug where we did not correctly back off from servers that had "gone" if they returned 4xx series error codes. ([\#16221](https://github.com/matrix-org/synapse/issues/16221 ))
- Update links to the [matrix.org blog](https://matrix.org/blog/ ). ([\#16008](https://github.com/matrix-org/synapse/issues/16008 ))
- Document which [admin APIs](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html ) are disabled when experimental [MSC3861](https://github.com/matrix-org/matrix-spec-proposals/pull/3861 ) support is enabled. ([\#16168](https://github.com/matrix-org/synapse/issues/16168 ))
- Document [`exclude_rooms_from_sync`](https://matrix-org.github.io/synapse/v1.92/usage/configuration/config_documentation.html#exclude_rooms_from_sync ) configuration option. ([\#16178](https://github.com/matrix-org/synapse/issues/16178 ))
- Prepare unit tests for Python 3.12. ([\#16099](https://github.com/matrix-org/synapse/issues/16099 ))
- Fix nightly CI jobs. ([\#16121](https://github.com/matrix-org/synapse/issues/16121 ), [\#16213](https://github.com/matrix-org/synapse/issues/16213 ))
- Describe which rate limiter was hit in logs. ([\#16135](https://github.com/matrix-org/synapse/issues/16135 ))
- Simplify presence code when using workers. ([\#16170](https://github.com/matrix-org/synapse/issues/16170 ))
- Track per-device information in the presence code. ([\#16171](https://github.com/matrix-org/synapse/issues/16171 ), [\#16172](https://github.com/matrix-org/synapse/issues/16172 ))
- Stop using the `event_txn_id` table. ([\#16175](https://github.com/matrix-org/synapse/issues/16175 ))
- Use `AsyncMock` instead of custom code. ([\#16179](https://github.com/matrix-org/synapse/issues/16179 ), [\#16180](https://github.com/matrix-org/synapse/issues/16180 ))
- Improve error reporting of invalid data passed to `/_matrix/key/v2/query`. ([\#16183](https://github.com/matrix-org/synapse/issues/16183 ))
- Task scheduler: add replication notify for new task to launch ASAP. ([\#16184](https://github.com/matrix-org/synapse/issues/16184 ))
- Improve type hints. ([\#16186](https://github.com/matrix-org/synapse/issues/16186 ), [\#16188](https://github.com/matrix-org/synapse/issues/16188 ), [\#16201](https://github.com/matrix-org/synapse/issues/16201 ))
- Bump black version to 23.7.0. ([\#16187](https://github.com/matrix-org/synapse/issues/16187 ))
- Log the details of background update failures. ([\#16212](https://github.com/matrix-org/synapse/issues/16212 ))
- Cache device resync requests over replication. ([\#16241](https://github.com/matrix-org/synapse/issues/16241 ))
* Bump anyhow from 1.0.72 to 1.0.75. ([\#16141](https://github.com/matrix-org/synapse/issues/16141 ))
* Bump furo from 2023.7.26 to 2023.8.19. ([\#16238](https://github.com/matrix-org/synapse/issues/16238 ))
* Bump phonenumbers from 8.13.18 to 8.13.19. ([\#16237](https://github.com/matrix-org/synapse/issues/16237 ))
* Bump psycopg2 from 2.9.6 to 2.9.7. ([\#16196](https://github.com/matrix-org/synapse/issues/16196 ))
* Bump regex from 1.9.3 to 1.9.4. ([\#16195](https://github.com/matrix-org/synapse/issues/16195 ))
* Bump ruff from 0.0.277 to 0.0.286. ([\#16198](https://github.com/matrix-org/synapse/issues/16198 ))
* Bump sentry-sdk from 1.29.2 to 1.30.0. ([\#16236](https://github.com/matrix-org/synapse/issues/16236 ))
* Bump serde from 1.0.184 to 1.0.188. ([\#16194](https://github.com/matrix-org/synapse/issues/16194 ))
* Bump serde_json from 1.0.104 to 1.0.105. ([\#16140](https://github.com/matrix-org/synapse/issues/16140 ))
* Bump types-psycopg2 from 2.9.21.10 to 2.9.21.11. ([\#16200](https://github.com/matrix-org/synapse/issues/16200 ))
* Bump types-pyyaml from 6.0.12.10 to 6.0.12.11. ([\#16199](https://github.com/matrix-org/synapse/issues/16199 ))
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmT3RFIACgkQkD7OEIo5
3t1gGA/9HQwV3vNgZkQj9Y0TVEj/ECoASSOvaTWbsXmoyctEqUOF7yoin+e6rZdB
b5hrCMN8dGGny/Nqb7hF2/Zcz+zHOhNOshEE7VDnt2dLZY3MaaF7SOFVnfM6KDz5
UyKkSbvhO2wgZIu8YebxW9C7a3EUnI8ocnb2PsyNNCPYtOVdZ7h+JeV9T2OS78rG
dw/hFNBG8jQYwbbpaFtdCjDCaz67/GB9LnWcXwbE6kJr5lJ903uH0NPLdrdITsrH
wvvw1vQHFZtzuAjfnKA/dz42H1h/s3ogxBMQxS0rVdxvFDIJiLUpWyDdPxjixzRS
w96Pw4+hTlposAZT1qWRf0n263M5BZpoEQuZ/C4q088FrLubuaummW2IfMWx8ono
y556CLRg+yjv2MmGeYYabcSxj1OPc/FV3w73tbxrVjKP7x2fnfGqTJeDhIqXh2wj
DphMFBVHmvUEJv6TRfPV/V/ocoN3Tg1vXCPiY3JGcU9ihtHAjL0F9Af03nMKg594
ZQc/xbroEFln11Ip+q9LYxP8q0ptKZph/Fo10WaeYSLII2WO0dC+mP+QvDfQle3N
ftXJm+Utk/cg73gSYNqex4EmHkGAB0np8YjpA41mdVNcJlXGQ3WQn0FgqX7JZ1jQ
lc0YtGm8jqp045tU2WAcacOg8/udTL+UkbDSdkhzq3KRXbB5bE8=
=K4NS
-----END PGP SIGNATURE-----
gpgsig -----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmT3T8IACgkQkD7OEIo5
3t3hyhAAoTswFfnZxfee5fk458OIe05KdpQ/oYSv+5iKeqe3SGrPPgPD58gGi6+c
vUccRAB7frZIdzjGnTuN98WMn2ll7LPvn1tHzRIQM78qoIwAyJrpe40BL5HQR6Iy
3weNug9ae2NGOqNaO816aDFOHvkE0lNDpU9fE4iZcyxs5b7kyD8CTmNv1DrRRtPV
DOcCqtRgSMZXC7aVI4c8f7q4WdzfjWSLrieeDaHwVBFPAm1jcg3WiWauFpCYScHg
sPq0D0zeRdkaNNw8+B4B6WOePL1lm31RRsjmxqf3+bgfyzEB8DzJw8JEv02BnkTi
yNzJKAouBahjgXEcGXmfm5APBbu1eW4hkHeZPWkM1aHHNnQ3MdRPGHt0Nb+cmsxO
AEu6GiFY2w14y6DwATXGpOpzlKHmYfdsncjpC17f35aqt94LnSXH39tt1idYABbI
uC4sfStXFN+bURYUbsIDTGXbe1/yjaTNGR0Cq8GvqWDWQGN2fy2z9dhgZzvr7SEL
3TRHtUOcuCHVBv/FxCl3jjWNFgDveemSVDqvBmtbvNjGaIP2jSpJD9tJTRWk+m3n
7c0T8UiryfAsgkme3cwjfnvIHaPRevLNqImNlQnJS42xjQaplx67aP4HZ1P3JiBU
lSC+JhKQ7TOxajFlmrB3LUkFaRpYt7i3ZCFvRZACWkDPxh285r8=
=WqeW
-----END PGP SIGNATURE-----
Merge tag 'v1.92.0rc1' into develop
- Add configuration setting for CAS protocol version. Contributed by Aurélien Grimpard. ([\#15816](https://github.com/matrix-org/synapse/issues/15816 ))
- Suppress notifications from message edits per [MSC3958](https://github.com/matrix-org/matrix-spec-proposals/pull/3958 ). ([\#16113](https://github.com/matrix-org/synapse/issues/16113 ))
- Return a `Retry-After` with `M_LIMIT_EXCEEDED` error responses. ([\#16136](https://github.com/matrix-org/synapse/issues/16136 ))
- Add `last_seen_ts` to the [admin users API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html ). ([\#16218](https://github.com/matrix-org/synapse/issues/16218 ))
- Improve resource usage when sending data to a large number of remote hosts that are marked as "down". ([\#16223](https://github.com/matrix-org/synapse/issues/16223 ))
- Fix IPv6-related bugs on SMTP settings, adding groundwork to fix similar issues. Contributed by @evilham and @telmich (ungleich.ch). ([\#16155](https://github.com/matrix-org/synapse/issues/16155 ))
- Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `include_all_networks` as a string. ([\#16185](https://github.com/matrix-org/synapse/issues/16185 ))
- Fix inaccurate error message while attempting to ban or unban a user with the same or higher PL by spliting the conditional statements. Contributed by @leviosacz. ([\#16205](https://github.com/matrix-org/synapse/issues/16205 ))
- Fix a rare bug that broke looping calls, which could lead to e.g. linearly increasing memory usage. Introduced in v1.90.0. ([\#16210](https://github.com/matrix-org/synapse/issues/16210 ))
- Fix a long-standing bug where uploading images would fail if we could not generate thumbnails for them. ([\#16211](https://github.com/matrix-org/synapse/issues/16211 ))
- Fix a long-standing bug where we did not correctly back off from servers that had "gone" if they returned 4xx series error codes. ([\#16221](https://github.com/matrix-org/synapse/issues/16221 ))
- Update links to the [matrix.org blog](https://matrix.org/blog/ ). ([\#16008](https://github.com/matrix-org/synapse/issues/16008 ))
- Document which [admin APIs](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html ) are disabled when experimental [MSC3861](https://github.com/matrix-org/matrix-spec-proposals/pull/3861 ) support is enabled. ([\#16168](https://github.com/matrix-org/synapse/issues/16168 ))
- Document [`exclude_rooms_from_sync`](https://matrix-org.github.io/synapse/v1.92/usage/configuration/config_documentation.html#exclude_rooms_from_sync ) configuration option. ([\#16178](https://github.com/matrix-org/synapse/issues/16178 ))
- Prepare unit tests for Python 3.12. ([\#16099](https://github.com/matrix-org/synapse/issues/16099 ))
- Fix nightly CI jobs. ([\#16121](https://github.com/matrix-org/synapse/issues/16121 ), [\#16213](https://github.com/matrix-org/synapse/issues/16213 ))
- Describe which rate limiter was hit in logs. ([\#16135](https://github.com/matrix-org/synapse/issues/16135 ))
- Simplify presence code when using workers. ([\#16170](https://github.com/matrix-org/synapse/issues/16170 ))
- Track per-device information in the presence code. ([\#16171](https://github.com/matrix-org/synapse/issues/16171 ), [\#16172](https://github.com/matrix-org/synapse/issues/16172 ))
- Stop using the `event_txn_id` table. ([\#16175](https://github.com/matrix-org/synapse/issues/16175 ))
- Use `AsyncMock` instead of custom code. ([\#16179](https://github.com/matrix-org/synapse/issues/16179 ), [\#16180](https://github.com/matrix-org/synapse/issues/16180 ))
- Improve error reporting of invalid data passed to `/_matrix/key/v2/query`. ([\#16183](https://github.com/matrix-org/synapse/issues/16183 ))
- Task scheduler: add replication notify for new task to launch ASAP. ([\#16184](https://github.com/matrix-org/synapse/issues/16184 ))
- Improve type hints. ([\#16186](https://github.com/matrix-org/synapse/issues/16186 ), [\#16188](https://github.com/matrix-org/synapse/issues/16188 ), [\#16201](https://github.com/matrix-org/synapse/issues/16201 ))
- Bump black version to 23.7.0. ([\#16187](https://github.com/matrix-org/synapse/issues/16187 ))
- Log the details of background update failures. ([\#16212](https://github.com/matrix-org/synapse/issues/16212 ))
- Cache device resync requests over replication. ([\#16241](https://github.com/matrix-org/synapse/issues/16241 ))
* Bump anyhow from 1.0.72 to 1.0.75. ([\#16141](https://github.com/matrix-org/synapse/issues/16141 ))
* Bump furo from 2023.7.26 to 2023.8.19. ([\#16238](https://github.com/matrix-org/synapse/issues/16238 ))
* Bump phonenumbers from 8.13.18 to 8.13.19. ([\#16237](https://github.com/matrix-org/synapse/issues/16237 ))
* Bump psycopg2 from 2.9.6 to 2.9.7. ([\#16196](https://github.com/matrix-org/synapse/issues/16196 ))
* Bump regex from 1.9.3 to 1.9.4. ([\#16195](https://github.com/matrix-org/synapse/issues/16195 ))
* Bump ruff from 0.0.277 to 0.0.286. ([\#16198](https://github.com/matrix-org/synapse/issues/16198 ))
* Bump sentry-sdk from 1.29.2 to 1.30.0. ([\#16236](https://github.com/matrix-org/synapse/issues/16236 ))
* Bump serde from 1.0.184 to 1.0.188. ([\#16194](https://github.com/matrix-org/synapse/issues/16194 ))
* Bump serde_json from 1.0.104 to 1.0.105. ([\#16140](https://github.com/matrix-org/synapse/issues/16140 ))
* Bump types-psycopg2 from 2.9.21.10 to 2.9.21.11. ([\#16200](https://github.com/matrix-org/synapse/issues/16200 ))
* Bump types-pyyaml from 6.0.12.10 to 6.0.12.11. ([\#16199](https://github.com/matrix-org/synapse/issues/16199 ))
2023-09-05 16:56:43 +01:00
8b5013dcbc
Time out busy presence status & test multi-device busy ( #16174 )
...
Add a (long) timeout to when a "busy" device is considered not online.
This does *not* match MSC3026, but is a reasonable thing for an
implementation to do.
Expands tests for the (unstable) busy presence with multiple devices.
2023-09-05 10:39:38 -04:00
ea75346f6a
Track presence state per-device and combine to a user state. ( #16066 )
...
Tracks presence on an individual per-device basis and combine
the per-device state into a per-user state. This should help in
situations where a user has multiple devices with conflicting status
(e.g. one is syncing with unavailable and one is syncing with online).
The tie-breaking is done by priority:
BUSY > ONLINE > UNAVAILABLE > OFFLINE
2023-09-05 09:58:51 -04:00
dfcfa9f0ed
Bump minimum supported Rust version to 1.61.0 ( #16248 )
2023-09-05 13:12:50 +01:00
757010905e
Bump twisted from 22.10.0 to 23.8.0 ( #16235 )
...
* Bump twisted from 22.10.0 to 23.8.0
Bumps [twisted](https://github.com/twisted/twisted ) from 22.10.0 to 23.8.0.
- [Release notes](https://github.com/twisted/twisted/releases )
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst )
- [Commits](https://github.com/twisted/twisted/compare/twisted-22.10.0...twisted-23.8.0 )
---
updated-dependencies:
- dependency-name: twisted
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Fix types
* Fix lint
* Newsfile
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erik Johnston <erik@matrix.org>
2023-09-05 11:14:14 +00:00
0425dd28f4
1.92.0rc1
2023-09-05 11:21:54 +01:00
d35bed8369
Don't wake up destination transaction queue if they're not due for retry. ( #16223 )
2023-09-04 17:14:09 +01:00
dcb2778341
Add last_seen_ts to the admin users API ( #16218 )
2023-09-04 18:13:28 +02:00
f84baecb6f
Don't reset retry timers on "valid" error codes ( #16221 )
2023-09-04 14:04:43 +01:00
e9eb26e3af
Cache device resync requests over replication ( #16241 )
2023-09-04 11:57:59 +01:00
93f2fdd8d1
Fix typo where we ended up with multiple `WorkerLocksHandler` ( #16220 )
...
I don't think has caused any actual issues.
Introduced in #15891
2023-09-01 12:52:57 +00:00
6525fd65ee
Log the details of background update failures ( #16212 )
2023-09-01 12:41:56 +01:00
ed5e8a77ca
Ignore redundant casts in latest deps CI job ( #16213 )
2023-08-30 22:55:47 +01:00
3de82bb2af
Gracefully handle failing to thumbnail images ( #16211 )
2023-08-30 15:18:34 +01:00
a2e0d4cd60
Fix rare bug that broke looping calls ( #16210 )
...
* Fix rare bug that broke looping calls
We can't interact with the reactor from the main thread via looping
call.
Introduced in v1.90.0 / #15791 .
* Newsfile
2023-08-30 14:18:42 +01:00
ebd8374fb5
Stop writing to the event_txn_id table ( #16175 )
2023-08-30 11:10:56 +01:00
62a1a9be52
Describe which rate limiter was hit in logs ( #16135 )
2023-08-30 00:39:39 +01:00
e9235d92f2
Track currently syncing users by device for presence ( #16172 )
...
Refactoring to use both the user ID & the device ID when tracking
the currently syncing users in the presence handler.
This is done both locally and over replication. Note that the device
ID is discarded but will be used in a future change.
2023-08-29 11:44:07 -04:00
9ec3da06da
Bump mypy-zope & mypy. ( #16188 )
2023-08-29 10:38:56 -04:00
63b51ef3fb
Support IPv6-only SMTP servers ( #16155 )
...
Use Twisted HostnameEndpoint to connect to SMTP servers (instead
of connectTCP/connectSSL) which properly supports IPv6-only servers.
2023-08-29 09:33:58 -04:00
2d72367367
Update black & fix the targeted Python versions. ( #16187 )
...
Black should target Python 3.8 to 3.11.
2023-08-29 08:34:53 -04:00
692ee2af19
Fix inaccurate error message while trying to ban or unban a user with the same or higher PL ( #16205 )
2023-08-29 10:37:09 +01:00
40901af5e0
Pass the device ID around in the presence handler ( #16171 )
...
Refactoring to pass the device ID (in addition to the user ID) through
the presence handler (specifically the `user_syncing`, `set_state`,
and `bump_presence_active_time` methods and their replication
versions).
2023-08-28 13:08:49 -04:00
1bf143699c
Combine logic about not overriding BUSY presence. ( #16170 )
...
Simplify some of the presence code by reducing duplicated code between
worker & non-worker modes.
The main change is to push some of the logic from `user_syncing` into
`set_state`. This is done by passing whether the user is setting the presence
via a `/sync` with a new `is_sync` flag to `set_state`. If this is `true` some
additional logic is performed:
* Don't override `busy` presence.
* Update the `last_user_sync_ts`.
* Never update the status message.
2023-08-28 11:03:23 -04:00
501da8ecd8
Task scheduler: add replication notify for new task to launch ASAP ( #16184 )
2023-08-28 14:03:51 +00:00
4379d3ef63
Bump setuptools-rust from 1.6.0 to 1.7.0. ( #16201 )
2023-08-28 09:04:15 -04:00
84f441f88f
Prepare unit tests for Python 3.12 ( #16099 )
2023-08-25 15:05:10 -04:00
ed6de4b2d4
service-identity, incremental, and setuptools-rust now have type hints. ( #16186 )
2023-08-25 14:10:47 -04:00
82699428e3
Validate input to POST /key/v2/query endpoint. ( #16183 )
...
To avoid 500 internal server errors with garbage input.
2023-08-25 14:10:31 -04:00
fcf7a5759e
Send proper JSON POST data to /publicRooms ( #16185 )
...
The include_all_networks was previously sent in the JSON body as
string "true" and "false" instead of boolean true and false.
2023-08-25 12:11:40 -04:00
a8a46b1336
Replace simple_async_mock with AsyncMock ( #16180 )
...
Python 3.8 has a native AsyncMock, use it instead of a custom
implementation.
2023-08-25 09:27:21 -04:00
5c9402b9fd
Add warnings about MSC3861 on certain APIs. ( #16168 )
2023-08-25 07:25:34 -04:00
daf11e26ef
Replace make_awaitable with AsyncMock ( #16179 )
...
Python 3.8 provides a native AsyncMock, we can replace the
homegrown version we have.
2023-08-24 19:38:46 -04:00
5856a8ba42
Document `exclude_rooms_fom_sync` configuration option ( #16178 )
2023-08-24 13:57:53 -07:00
aeeca2a62e
Add configuration setting for CAS protocol version ( #15816 )
2023-08-24 16:11:23 -04:00
5427cc20b9
Update URLs to matrix.org blog categories. ( #16008 )
2023-08-24 11:06:06 -04:00
e691243e19
Fix typechecking with twisted trunk ( #16121 )
2023-08-24 14:53:07 +00:00
0538e3e2db
Add `Retry-After` to M_LIMIT_EXCEEDED error responses ( #16136 )
...
Implements MSC4041 behind an experimental configuration flag.
2023-08-24 10:40:26 -04:00
851cbdcb57
Merge branch 'release-v1.91' into develop
2023-08-23 11:44:01 -07:00
33fa82a34c
Stabilize support for MSC3958 (suppress notifications from edits). ( #16113 )
2023-08-23 13:22:34 -04:00
23f88f9c59
1.91.0rc1
2023-08-23 09:47:29 -07:00
18279631e9
Fix rare deadlock when using read/write locks ( #16169 )
2023-08-23 16:24:30 +01:00
85118420a2
Switch `devenv` dependency in the nix development environment to the latest release (instead of the development branch) ( #16063 )
2023-08-23 16:16:14 +01:00
ec662bbe41
Filter out unwanted user_agents from udv. ( #16124 )
2023-08-23 14:00:34 +01:00
4adaba9acf
Fix rare deadlock when using read/write locks ( #16133 )
2023-08-23 13:45:25 +01:00
7cd79ce051
Reduce DB contention on worker locks ( #16160 )
2023-08-23 13:45:19 +01:00
86ecd341ec
Always update `retry_last_ts` ( #16164 )
2023-08-23 13:04:46 +01:00
873971a8b9
Task scheduler: mark task as active if we are scheduling ASAP ( #16165 )
2023-08-23 13:37:51 +02:00
da162cbe4e
Add tests for restoring the presence state after a restart. ( #16151 )
2023-08-23 07:31:00 -04:00
19a1cda084
Properly update retry_last_ts when hitting the maximum retry interval ( #16156 )
...
* Properly update retry_last_ts when hitting the maximum retry interval
This was broken in 1.87 when the maximum retry interval got changed from
almost infinite to a week (and made configurable).
fixes #16101
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* Add changelog
* Change fix + add test
* Add comment
---------
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-08-23 09:35:23 +01:00
dffe095642
Only lock when we're backfilling ( #16159 )
2023-08-23 09:23:41 +01:00
3b3fed7229
Increase perf of read/write locks ( #16149 )
...
We do this by marking the tables as `UNLOGGED` in PostgreSQL.
2023-08-23 09:23:22 +01:00
3f17178728
Clean-up presence tests ( #16158 )
...
Reduce duplicated code & remove unused variables.
2023-08-22 11:43:44 -04:00
803f63df1c
Fix perf of `wait_for_stream_positions` ( #16148 )
2023-08-22 15:11:22 +00:00
0ba17777be
Disable `m.3pid_changes` capability when MSC3861 is enabled. ( #16134 )
2023-08-22 14:47:59 +00:00
69048f7b48
Add an admin endpoint to allow authorizing server to signal token revocations ( #16125 )
2023-08-22 14:15:34 +00:00
b657e89005
Fix user directory test for deactivated support user. ( #16157 )
...
Support users should not be added to the user directory after
being deactivated.
2023-08-22 09:08:24 -04:00
bc72d803d5
Raise poetry-core version cap to 1.7.0 ( #16152 )
2023-08-22 13:51:35 +01:00
6d7c63fcc6
Properly call setup_background_tasks in unit tests. ( #16150 )
...
This should only be called on HomeServer objects which are configured
to run background tasks, which is automatically (and properly) done via
the call to setup().
2023-08-22 07:46:32 -04:00
7dbac123f9
Disallow user_consent where experimental MSC3861 is enabled ( #16127 )
2023-08-22 07:42:08 -04:00
d6ae4041a4
Add `client_secret_path` as alternative for `client_secret` for OIDC config ( #16030 )
2023-08-21 19:32:17 +00:00
358896e1b8
Implements a task scheduler for resumable potentially long running tasks ( #15891 )
2023-08-21 14:17:13 +02:00
bd558a6dc3
Speed up state res in rare case we don't have all events ( #16116 )
...
If we don't have all the auth events in a room then not all state events will have a chain cover index. Even so, we can still use the chain cover index on the events that do have it, rather than bailing and using the slower functions.
This situation should not arise for newly persisted rooms, as we check we have the full auth chain for each event, but can happen for existing rooms.
c.f. #15245
2023-08-18 15:32:06 +01:00
2d15e39684
MSC3861: allow impersonation by an admin using a query param ( #16132 )
2023-08-18 15:46:46 +02:00
54317d34b7
Allow filtering for admins in the list accounts admin API ( #16114 )
2023-08-18 12:26:38 +01:00
6130afb862
Add response time metrics for introspection requests ( #16131 )
...
See #16119
2023-08-18 12:16:00 +01:00
0aba4a4eaa
Add cache to `get_server_keys_json_for_remote` ( #16123 )
2023-08-18 11:05:01 +01:00
54a51ff6c1
Cache token introspection response from OIDC provider ( #16117 )
2023-08-17 10:53:10 -07:00
eb0dbab15b
Fix database performance of read/write worker locks ( #16061 )
...
We were seeing serialization errors when taking out multiple read locks.
The transactions were retried, so isn't causing any failures.
Introduced in #15782 .
2023-08-17 14:07:57 +01:00
0377cb4fab
Override global statement timeout when creating indexes in Postgres ( #16085 )
2023-08-17 10:30:02 +01:00
8a4fb7a6ba
Disable caching in /sync corner case ( #16080 )
...
Fixes #15502
2023-08-17 10:22:50 +01:00
8c3bcea2da
Rename pagination&purge locks and add comments explaining them ( #16112 )
2023-08-16 16:19:54 +02:00
4513b36a75
Add link explaining ELK stack to structured_logging.md ( #16091 )
2023-08-16 14:08:35 +01:00
47c629bb27
Attempt to fix twisted trunk ( #16115 )
2023-08-15 16:07:13 +00:00
ad3f43be9a
Run pyupgrade for python 3.7 & 3.8. ( #16110 )
2023-08-15 08:11:20 -04:00
9ff84bccbb
Allow customizing IdP name and icon for SAML and CAS ( #16094 )
2023-08-11 20:15:17 +00:00
614efc488b
Add linearizer on user ID to push rule PUT/DELETE requests ( #16052 )
...
See: #16053
Signed off by Nick @ Beeper (@Fizzadar)
2023-08-11 11:37:09 +00:00
7f4b413690
Fix the type annotation on `run_db_interaction` in the Module API. ( #16089 )
...
* Fix the method signature of `run_db_interaction` on the module API
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-08-10 18:28:31 +01:00
efd4d06d76
Clean-up presence code ( #16092 )
...
Misc. clean-ups to:
* Use keyword arguments.
* Return early (reducing indentation) of some functions.
* Removing duplicated / unused code.
* Use wrap_as_background_process.
2023-08-10 07:39:46 -04:00
dac97642e4
Implements admin API to lock an user (MSC3939) ( #15870 )
2023-08-10 09:10:55 +00:00
0328b56468
Support MSC3814: Dehydrated Devices Part 2 ( #16010 )
2023-08-08 12:04:46 -07:00
8e09b8aecb
1.90.0rc1
2023-08-08 15:29:44 +01:00
a476d5048b
Allow modules to schedule delayed background calls. ( #15993 )
...
* Add a module API function to provide `call_later`
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Add comments
* Update version number
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-08-08 11:53:49 +01:00
f3dc6dc19f
Remove old rows from the `cache_invalidation_stream_by_instance` table automatically. (This table is not used when Synapse is configured to use SQLite.) ( #15868 )
...
* Add a cache invalidation clean-up task
* Run the cache invalidation stream clean-up on the background worker
* Tune down
* call_later is in millis!
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* fixup! Add a cache invalidation clean-up task
* Update synapse/storage/databases/main/cache.py
Co-authored-by: Eric Eastwood <erice@element.io>
* Update synapse/storage/databases/main/cache.py
Co-authored-by: Eric Eastwood <erice@element.io>
* MILLISEC -> MS
* Expand on comment
* Move and tweak comment about Postgres
* Use `wrap_as_background_process`
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
Co-authored-by: Eric Eastwood <erice@element.io>
2023-08-08 11:10:07 +01:00
8af3f33d84
Fix endpoint improperly declaring support for MSC3814 ( #16068 )
2023-08-07 10:52:15 -07:00
81a6f8c9ae
Drop backwards compat hack for event serialization ( #16069 )
2023-08-07 10:37:08 -07:00
9d3713d6d5
Add notes describing Synapse's streams ( #16015 )
...
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-08-07 18:36:04 +01:00
84ae2e3f6f
Fix deletion for Dehydrated Devices ( #16046 )
2023-08-04 10:49:54 -07:00
d98a43d922
Stabilize support for MSC3970: updated transaction semantics (scope to `device_id`) ( #15629 )
...
For now this maintains compatible with old Synapses by falling back
to using transaction semantics on a per-access token. A future version
of Synapse will drop support for this.
2023-08-04 07:47:18 -04:00
0a5f4f7665
Move support for application service query parameter authorization behind a configuration option ( #16017 )
2023-08-03 11:43:51 -07:00
f0a860908b
Allow config of the backoff algorithm for the federation client. ( #15754 )
...
Adds three new configuration variables:
* destination_min_retry_interval is identical to before (10mn).
* destination_retry_multiplier is now 2 instead of 5, the maximum value will
be reached slower.
* destination_max_retry_interval is one day instead of (essentially) infinity.
Capping this will cause destinations to continue to be retried sometimes instead
of being lost forever. The previous value was 2 ^ 62 milliseconds.
2023-08-03 14:36:55 -04:00
9c462f18a4
Allow modules to check whether the current worker is configured to run background tasks. ( #15991 )
2023-08-03 08:42:19 -04:00
4f5bccbbba
Add forward-compatibility for the redacts property (MSC2174). ( #16013 )
...
The location of the redacts field changes in room version 11. Ensure
it is copied to the *new* location for *old* room versions for
forwards-compatibility with clients.
Note that copying it to the *old* location for the *new* room version
was previously handled.
2023-08-02 15:35:54 +00:00
01a45869f0
Update MSC3958 support to interact with intentional mentions. ( #15992 )
...
* Updates the rule ID.
* Use `event_property_is` instead of `event_match`.
This updates the implementation of MSC3958 to match the latest
text from the MSC.
2023-08-02 08:41:32 -04:00
a51b0862a1
Update `flake.lock` to fix running the nix developer environment on MacOS ( #16019 )
2023-08-02 07:47:16 +01:00
8fe1fd906a
Update certifi to 2023.7.22 and pygments to 2.15.1. ( #16044 )
2023-08-01 15:55:58 +00:00
90ad836ed8
Properly setup the additional sequences in the portdb script. ( #16043 )
...
The un_partial_stated_event_stream_sequence and
application_services_txn_id_seq were never properly configured
in the portdb script, resulting in an error on start-up.
2023-08-01 10:36:33 -04:00
5eb3fd785b
Trim whitespace when setting display names ( #16031 )
2023-08-01 09:14:02 -04:00
7cbb2a00d1
Add metrics tracking for eviction to ResponseCache ( #16028 )
...
Track whether the ResponseCache is evicting due to invalidation
or due to time.
2023-08-01 08:10:49 -04:00
b7695ac388
Combine duplicated code for calculating an event ID from a txn ID ( #16023 )
...
Refactoring related to stabilization of MSC3970, refactor to combine
code which has the same logic.
2023-07-31 08:44:45 -04:00
e02f4b7de2
Do not expose Admin API in caddy reverse proxy example ( #16027 )
...
Signed-off-by: Nils ANDRÉ-CHANG <nils@nilsand.re>
2023-07-31 13:25:06 +02:00
ae55cc1e6b
Add ability to wait for locks and add locks to purge history / room deletion ( #15791 )
...
c.f. #13476
2023-07-31 10:58:03 +01:00
68b2611783
Clarify comment on key uploads over replication ( #16016 )
2023-07-27 15:08:46 -07:00
a719b703d9
Fix 404 on /profile when the display name is empty but not the avatar ( #16012 )
2023-07-27 15:45:05 +02:00
a461f1f846
Update PyYAML to 6.0.1 ( #16011 )
2023-07-27 14:51:26 +02:00
f9f3e89354
Attempt to fix labelling in docker workflow ( #16009 )
2023-07-27 13:47:48 +01:00
f98f4f2e16
Remove support for legacy application service paths ( #15964 )
2023-07-26 12:59:47 -07:00
58f8305114
Inline SQL queries using boolean parameters ( #15525 )
...
SQLite now supports TRUE and FALSE constants, simplify some
queries by inlining those instead of passing them as arguments.
2023-07-26 18:45:47 +00:00
96529c4236
Add synapse version as Docker container label ( #15972 )
...
Co-authored-by: Mo Balaa <balaa@fractalnetworks.co>
2023-07-26 16:16:12 +00:00
d4ea465496
Remove changelog file
2023-07-26 14:54:37 +02:00
8ebfd577e2
Bump DB version to 79 since synapse v1.88 was already there ( #15998 )
2023-07-26 14:51:44 +02:00
dbee081d14
1.89.0rc1
2023-07-25 14:32:47 +02:00
641ff9ef7e
Support MSC3814: Dehydrated Devices ( #15929 )
...
Signed-off-by: Nicolas Werner <n.werner@famedly.com>
Co-authored-by: Nicolas Werner <n.werner@famedly.com>
Co-authored-by: Nicolas Werner <89468146+nico-famedly@users.noreply.github.com>
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
2023-07-24 08:23:19 -07:00
05f8dada8b
Fix broken Arch Linux package link ( #15981 )
2023-07-24 09:06:10 -04:00
654902a758
Resync stale devices in background ( #15975 )
...
This is so we don't block responding to federation transaction while we
try and fetch the device lists.
2023-07-24 13:43:43 +01:00
5c7364fea5
Properly handle redactions of creation events ( #15973 )
2023-07-23 16:32:01 -07:00
f08d05dd2c
Actually stop reading from column `user_id` of tables `profiles` ( #15955 )
2023-07-23 16:30:54 -07:00
e1fa42249c
Build packages for Debian Trixie ( #15961 )
2023-07-23 16:30:05 -07:00
fc1e534e41
Speed up updating state in large rooms ( #15971 )
...
This should speed up updating state in rooms with lots of state.
2023-07-20 15:51:28 +01:00
835174180b
Fixed grafana deploy annotations in the dashboard config, so it shows for those not managing matrix.org ( #15957 )
...
Removed the 'matrix.org' hardcorded instance setting
Originally introduced in #15674
Co-authored-by: wrjlewis <will.lewis@askattest.com>
2023-07-20 12:33:06 +00:00
fd44053b84
Don't log exceptions for every non-200 response ( #15969 )
...
Introduced in #15913
2023-07-20 11:07:58 +01:00
ad52db3b5c
Reduce the amount of state we pull out ( #15968 )
2023-07-20 10:46:37 +01:00
67f9e5293e
Ensure a long state res does not starve CPU ( #15960 )
...
We do this by yielding the reactor in hot loops.
2023-07-19 17:00:33 +00:00
19796e20aa
Fix bad merge of #15933 ( #15958 )
...
This was because we reverted the bump of the schema version, so we were not applying the new deltas.
2023-07-19 12:17:08 +00:00
40a3583ba1
Fix race in triggers for read/write locks. ( #15933 )
2023-07-19 12:06:38 +01:00
cb6e2c6cc7
Fix background schema updates failing over a large upgrade gap ( #15887 )
2023-07-18 16:59:27 -07:00
6d81aec09f
Support room version 11 ( #15912 )
...
And fix a bug in the implementation of the updated redaction
format (MSC2174) where the top-level redacts field was not
properly added for backwards-compatibility.
2023-07-18 08:44:59 -04:00
199c270947
Add a locality to a few presence metrics ( #15952 )
2023-07-18 10:36:40 +01:00
1c802de626
Re-introduce the outbound federation proxy ( #15913 )
...
Allow configuring the set of workers to proxy outbound federation traffic through (`outbound_federation_restricted_to`).
This is useful when you have a worker setup with `federation_sender` instances responsible for sending outbound federation requests and want to make sure *all* outbound federation traffic goes through those instances. Before this change, the generic workers would still contact federation themselves for things like profile lookups, backfill, etc. This PR allows you to set more strict access controls/firewall for all workers and only allow the `federation_sender`'s to contact the outside world.
2023-07-18 09:49:21 +01:00
85e0541db1
Pin the rust version in `flake.nix`, and bump to 1.70.0 to fix installing `ruff` ( #15940 )
2023-07-17 09:36:12 +01:00
8d3656b994
Document that you cannot login as yourself on /_synapse/admin/v1/users/<user_id>/login ( #15938 )
2023-07-14 08:32:13 -04:00
20ae617d14
Stop accepting 'user' parameter for application service registration. ( #15928 )
...
This is unspecced, but has existed for a very long time.
2023-07-13 07:23:56 -04:00
204b66c203
Remove unneeded __init__. ( #15926 )
...
Remove an __init__ which only calls super() without changing the
input arguments.
2023-07-12 14:30:05 +00:00
5bdf01fccd
Fix running with an empty experimental features section. ( #15925 )
2023-07-12 12:39:25 +00:00
36c6b92bfc
Fix push for invites received over federation ( #15820 )
2023-07-12 11:02:11 +00:00
8eb7bb975e
Mark get_user_in_directory private since only used in tests ( #15884 )
2023-07-12 11:09:13 +02:00
3bdb9b07fd
Make it more obvious which Python version runs on a given Linux distribution ( #15909 )
...
Make it more obvious which Python version runs on a given Linux distribution so when we end up dropping support for a given Python version, we can more easily find the reference to the Python version and remove any references for the distribution. We don't want to be running tests or building packages on a distribution that no longer has a supported Python version.
This way, we can avoid another situation like when we dropped support for Python 3.7 but forgot to drop the Debian Buster references everywhere (https://github.com/matrix-org/synapse/pull/15893 )
2023-07-11 17:15:06 -05:00
0371a354cf
Better clarify how to run a worker instance (pass both configs) ( #15921 )
...
Previously, if you just followed the instructions per the docs, you just ran into an error:
```sh
$ poetry run synapse_worker --config-path homeserver_generic_worker1.yaml
Missing mandatory `server_name` config option.
```
2023-07-11 17:13:54 -05:00
ae391db777
Better warning in logs when we fail to fetch an alias ( #15922 )
...
**Before:**
```
Error retrieving alias
```
**After:**
```
Error retrieving alias #foo:bar -> 401 Unauthorized
```
*Spawning from creating the [manual testing strategy for the outbound federation proxy](https://github.com/matrix-org/synapse/pull/15773 ).*
2023-07-11 17:12:41 -05:00
d7fc87d973
Bump Unix sockets intro version ( #15924 )
...
https://github.com/matrix-org/synapse/pull/15708 didn't quite make the cut for `1.88.0` this morning.
2023-07-11 15:32:50 -05:00
224ef0b669
Unix Sockets for HTTP Replication ( #15708 )
...
Unix socket support for `federation` and `client` Listeners has existed now for a little while(since [1.81.0](https://github.com/matrix-org/synapse/pull/15353 )), but there was one last hold out before it could be complete: HTTP Replication communication. This should finish it up. The Listeners would have always worked, but would have had no way to be talked to/at.
---------
Co-authored-by: Eric Eastwood <madlittlemods@gmail.com>
Co-authored-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
Co-authored-by: Eric Eastwood <erice@element.io>
2023-07-11 13:08:06 -05:00
a4243183f0
Add + as an allowed character for Matrix IDs (MSC4009) ( #15911 )
2023-07-11 12:21:00 -04:00
7c7bd9898b
1.88.0rc1
2023-07-11 10:28:11 +01:00
b516d91999
Add `Server` to Access-Control-Expose-Headers header ( #15908 )
2023-07-11 09:18:50 +01:00
2328e90fbb
Make the media `/upload` tracing less ambiguous ( #15888 )
...
A lot of the functions have the same name in this space like `store_file`,
and we also do it multiple times for different reasons (main media repo,
other storage providers, thumbnails, etc) so it's good to differentiate
them so your head doesn't explode.
Follow-up to https://github.com/matrix-org/synapse/pull/15850
Tracing instrumentation to media `/upload` code paths to investigate https://github.com/matrix-org/synapse/issues/15841
2023-07-10 17:23:11 -05:00
5e82b07d2c
Drop debian buster ( #15893 )
2023-07-10 10:39:36 -07:00
c9bf644fa0
Revert "Federation outbound proxy" ( #15910 )
...
Revert "Federation outbound proxy (#15773 )"
This reverts commit b07b14b494
2023-07-10 11:10:20 -05:00
a704a35dd7
Revert "Placeholder changelog"
...
This reverts commit 6e731e86bf
2023-07-10 10:26:04 -05:00
e55a9b3e41
Fix downgrading to previous version of Synapse ( #15907 )
...
We do this by marking the constraint as deferrable.
2023-07-10 16:24:42 +01:00
6774f265b4
Fix building rust with nightly ( #15906 )
...
Also fix up a warning.
2023-07-10 16:24:04 +01:00
6e731e86bf
Placeholder changelog
2023-07-10 10:23:30 -05:00
8a529e4fb6
Stop running sytest on buster/python3.7 ( #15892 )
2023-07-07 12:04:55 -07:00
f25b0f8808
Stop writing to column `user_id` of tables `profiles` and `user_filters` ( #15787 )
2023-07-07 09:23:27 -07:00
677272caed
Remove `worker_replication_*` settings from worker doc ( #15872 )
...
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-07-07 08:09:41 +00:00
2481b7dfa4
Remove `worker_replication_*` deprecated settings, with helpful errors on startup ( #15860 )
...
Co-authored-by: reivilibre <oliverw@matrix.org>
2023-07-07 07:45:25 +00:00
f19dd39dfc
Update link to the clients webpage, fix #15825 ( #15874 )
2023-07-06 17:28:09 +02:00
b07b14b494
Federation outbound proxy ( #15773 )
...
Allow configuring the set of workers to proxy outbound federation traffic through (`outbound_federation_restricted_to`).
This is useful when you have a worker setup with `federation_sender` instances responsible for sending outbound federation requests and want to make sure *all* outbound federation traffic goes through those instances. Before this change, the generic workers would still contact federation themselves for things like profile lookups, backfill, etc. This PR allows you to set more strict access controls/firewall for all workers and only allow the `federation_sender`'s to contact the outside world.
The original code is from @erikjohnston's branches which I've gotten in-shape to merge.
2023-07-05 18:53:55 -05:00
561d06b481
Remove support for Python 3.7 ( #15851 )
...
Fix https://github.com/matrix-org/synapse/issues/15836
2023-07-05 18:45:42 -05:00
39d131b016
Add basic read/write lock ( #15782 )
2023-07-05 17:25:00 +01:00
ce857c05d5
Add tracing to media `/upload` endpoint ( #15850 )
...
Add tracing instrumentation to media `/upload` code paths to investigate https://github.com/matrix-org/synapse/issues/15841
2023-07-05 10:22:21 -05:00
cc780b3f77
docs/admin_api: fix header level on 'Users' page ( #15852 )
...
Signed-off-by: Sumner Evans <sumner@beeper.com>
2023-07-05 16:15:56 +02:00
4cf9f92f39
Fix could not serialize access due to concurrent `DELETE` from presence_stream ( #15826 )
...
* Change update_presence to have a isolation level of READ_COMMITTED
* changelog
2023-07-05 11:44:02 +01:00
95a96b21eb
Add foreign key constraint to `event_forward_extremities`. ( #15751 )
2023-07-05 09:43:19 +00:00
c303eca8cc
use Image.LANCZOS instead of Image.ANTIALIAS for thumbnail resize ( #15876 )
...
Image.ANTIALIAS is not defined in current pillow releases. Since ANTIALIAS was just using LANCZOS anyways, this is just a cosmetic change, but makes synapse work with most recent pillow releases.
Signed-off-by: Giovanni Harting <539@idlegandalf.com>
2023-07-05 10:52:12 +02:00
c8e81898b6
Add not_user_type param to the list accounts admin API ( #15844 )
...
Signed-off-by: Michael Weimann <michaelw@element.io>
2023-07-04 15:03:20 -07:00
861752b3aa
Merge branch 'master' into develop
2023-07-04 17:40:37 +01:00
664ba14080
1.87.0
2023-07-04 16:25:33 +01:00
649848627c
Pin `pydantic` to <2.0.0 ( #15862 )
...
Signed-off-by: Paarth Shah <mail@shahpaarth.com>
2023-07-04 16:22:33 +01:00
670d590f8a
Pin `pydantic` to <2.0.0 ( #15862 )
...
Signed-off-by: Paarth Shah <mail@shahpaarth.com>
2023-07-04 09:33:24 +02:00
07d7cbfe69
devices: use combined ANY clause for faster cleanup ( #15861 )
...
Old device entries for the same user were being removed in individual
SQL commands, making the batch take way longer than necessary.
This combines the commands into a single one with a IN/ANY clause.
Example of log entry before the change, regularly observed with
"log_min_duration_statement = 10000" in PostgreSQL's config:
LOG: duration: 42538.282 ms statement:
DELETE FROM device_lists_stream
WHERE user_id = '@someone' AND device_id = 'someid1'
AND stream_id < 123456789
;
DELETE FROM device_lists_stream
WHERE user_id = '@someone' AND device_id = 'someid2'
AND stream_id < 123456789
;
[repeated for each device ID of that user, potentially a lot...]
With the patch applied on my instance for the past couple of days, I
no longer notice overly long statements of that particular kind.
Signed-off-by: pacien <pacien.trangirard@pacien.net>
2023-07-03 16:39:38 +02:00
cd8b73aa97
Fix the `devenv up` configuration which was ignoring the config overrides. ( #15854 )
...
* Fix use of config override directory in `devenv up`
`--config-directory` is for the generate config script; `-c` is for usage
* Add homeserver config override directory to gitignore
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-07-03 11:39:52 +01:00
53aa26eddc
Add a timeout that aborts any Postgres statement taking more than 1 hour. ( #15853 )
...
* Add a timeout to Postgres statements
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-07-03 11:38:57 +01:00
13fc89148c
Split out 2022 changes from the changelog ( #15846 )
...
Split out 2022 changes from the changelog so the rendered version in GitHub doesn't timeout as much.
2023-06-28 15:10:33 -05:00
472c2c72f6
Prepare changelog for v1.87.0rc1
2023-06-27 10:29:20 -05:00
78cfa55dad
Fix sqlite `user_filters` upgrade ( #15817 )
2023-06-27 09:41:42 +01:00
25c55a9d22
Add login spam checker API ( #15838 )
2023-06-26 14:12:20 +00:00
e0c39d6bb5
Fix forgotten rooms missing in initial sync ( #15815 )
...
If you leave a room and forget it, then rejoin it, the room would be
missing from the next initial sync.
fixes #13262
Signed-off-by: Nicolas Werner <n.werner@famedly.com>
2023-06-21 14:56:31 +01:00
289ce3b8d9
Fix harmless exception in port DB script ( #15814 )
...
The port DB script would try and run database background tasks, which
could fail if the data they acted on was in the process of being ported.
These exceptions were non fatal.
Fixes #15789
2023-06-21 13:20:46 +00:00
6c749c5124
Fix typo in faster join docs ( #15812 )
...
Fixes #15756
2023-06-21 11:34:32 +01:00
496f73103d
Allow for the configuration of max request retries and min/max retry delays in the matrix federation client ( #15783 )
2023-06-21 10:41:11 +02:00
6a5cf1a759
Fix Sytest environmental variable evaluation in CI ( #15804 )
2023-06-20 07:55:46 -07:00
2301a09d7a
Fix admin api documentation typo ( #15805 )
...
* Fix admin api documentation typo
Signed-off-by: Eric Wolf <eric.wolf@vier.ai>
2023-06-20 10:45:26 +00:00
887fa4b66b
Switch from `matrix://` to `matrix-federation://` scheme for internal Synapse routing of outbound federation traffic ( #15806 )
...
`matrix://` is a registered specced scheme nowadays and doesn't make sense for
our internal to Synapse use case anymore. ([discussion]
(https://github.com/matrix-org/synapse/pull/15773#discussion_r1227598679 ))
2023-06-20 10:05:31 +01:00
0f02f0b4da
Remove experimental MSC2716 implementation to incrementally import history into existing rooms ( #15748 )
...
Context for why we're removing the implementation:
- https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1487441010
- https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1504262734
Anyone wanting to continue MSC2716, should also address these leftover tasks: https://github.com/matrix-org/synapse/issues/10737
Closes https://github.com/matrix-org/synapse/issues/10737 in the fact that it is not longer necessary to track those things.
2023-06-16 14:12:24 -05:00
2ac6c3bbb5
Don't always lock "user_ips" table when performing non-native upsert ( #15788 )
2023-06-16 15:25:44 +01:00
0618bf94cd
push rules: fix internal conversion from _type to value ( #15781 )
...
Also fix wrong rule names for `is_user_mention` and `is_room_mention`.
2023-06-16 14:17:02 +02:00
f63d4a3a65
Regularly try to wake up dests instead of waiting for next PDU/EDU ( #15743 )
2023-06-16 10:15:12 +00:00
d939120421
Fix unsafe hotserving behaviour for non-multimedia uploads. ( #15680 )
...
* Fix unsafe hotserving behaviour for non-multimedia uploads.
* invert disposition assert
* test_media_storage.py: run lint
* test_base.py: /inline/attachment/s
* Only return attachment for disposition type, update tests
* Update synapse/media/_base.py
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Update changelog.d/15680.bugfix
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* add attribution
* Update changelog.
---------
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-06-15 14:23:27 +01:00
1404f68a03
Fix joining rooms through aliases where the alias server isn't a real homeserver ( #15776 )
2023-06-14 15:42:33 +01:00
87e5df9a6e
Merge branch 'release-v1.86' into develop
2023-06-14 14:54:19 +02:00
825c5909de
1.86.0rc2
2023-06-14 12:17:29 +02:00
14f9d9b452
Fix empty scope when having version mismatch between workers ( #15774 )
2023-06-14 11:53:55 +02:00
21fea6b749
Prefill events after invalidate not before when persisting events ( #15758 )
...
Fixes #15757
2023-06-14 09:42:18 +01:00
8ddb2de553
Document `looping_call()` functionality that will wait for the given function to finish before scheduling another ( #15772 )
...
Thanks to @erikjohnston for clarifying, https://github.com/matrix-org/synapse/pull/15743#discussion_r1226544457
We don't have to worry about calls stacking up if the given function takes longer than the scheduled time.
2023-06-13 16:34:54 -05:00
553f2f53e7
Replace `EventContext` fields `prev_group` and `delta_ids` with field `state_group_deltas` ( #15233 )
2023-06-13 13:22:06 -07:00
59ec4a0dc1
Fix MSC3983 support: only one OTK per device was returned through federation ( #15770 )
2023-06-13 19:51:47 +02:00
0757d59ec4
Avoid backfill when we already have messages to return ( #15737 )
...
We now only block the client to backfill when we see a large gap in the events (more than 2 events missing in a row according to `depth`), more than 3 single-event holes, or not enough messages to fill the response. Otherwise, we return the messages directly to the client and backfill in the background for eventual consistency sake.
Fix https://github.com/matrix-org/synapse/issues/15696
2023-06-13 12:31:08 -05:00
df945e0d7c
Fix MSC3983 support: Use the unstable /keys/claim federation endpoint if multiple keys are requested ( #15755 )
2023-06-13 18:07:55 +02:00
9966eb10a3
1.86.0rc1
2023-06-13 14:30:51 +02:00
ba97b39881
Bump minimum supported Rust version ( #15768 )
...
Important crates such as `log` and `regex` have bumped theirs to 1.60.0
as well.
2023-06-12 13:27:11 +00:00
fcc3ca37e1
Backfill in the background if we're doing it "just because" ( #15710 )
...
Fix https://github.com/matrix-org/synapse/issues/15702
2023-06-09 15:39:49 -05:00
373c0c7ff7
Speed up typechecking CI ( #15752 )
...
By restoring the rust cache before installing the project.
2023-06-09 15:00:30 +01:00
d84e66144d
Allow for the configuration of max request retries and min/max retry delays in the matrix federation client ( #12504 )
...
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
Co-authored-by: Erik Johnston <erik@matrix.org>
2023-06-09 09:00:46 +02:00
c485ed1c5a
Clear event caches when we purge history ( #15609 )
...
This should help a little with #13476
---------
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
2023-06-08 13:14:40 +01:00
d162aecaac
Quick & dirty metric for background update status ( #15740 )
...
* Quick & dirty metric for background update status
* Changelog
* Remove debug
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
* Actually write to _aborted
---------
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-06-07 17:12:23 +00:00
e536f02f68
Remove superfluous `room_memberships` join from background update ( #15733 )
...
Spawning from https://github.com/matrix-org/synapse/pull/15731
2023-06-07 11:47:01 -05:00
195b6a298d
Remove redundant `room_memberships` join to find participating servers in a room ( #15732 )
...
Spawning from https://github.com/matrix-org/synapse/pull/15731
2023-06-07 11:45:16 -05:00
5c24d7b9eb
Check required power levels earlier in createRoom handler. ( #15695 )
...
* Check required power levels earlier in createRoom handler.
- If a server was configured to reject the creation of rooms with E2EE
enabled (by specifying an unattainably high power level for
"m.room.encryption" in default_power_level_content_override), the 403
error was not being triggered until after the room was created and
before the "m.room.power_levels" was sent. This allowed a user to
access the partially-configured room and complete the setup of E2EE
and power levels manually.
- This change causes the power level overrides to be checked earlier and
the request to be rejected before the user gains access to the room.
- A new `_validate_room_config` method is added to contain checks that
should be run before a room is created.
- The new test case confirms that a user request is rejected by the new
validation method.
Signed-off-by: Grant McLean <grant@catalyst.net.nz>
* Add a changelog file.
* Formatting fix for black.
* Remove unneeded line from test.
---------
Signed-off-by: Grant McLean <grant@catalyst.net.nz>
2023-06-07 16:21:25 +01:00
9d911b0da6
No need for the extra join since `membership` is built-in to `current_state_events` ( #15731 )
...
This helps with the upstream `is_host_joined()` and `is_host_invited()` functions.
`membership` was added to `current_state_events` in https://github.com/matrix-org/synapse/pull/5706 and forced in https://github.com/matrix-org/synapse/pull/13745
2023-06-06 22:19:57 -05:00
8bfded81f3
Trace functions which return `Awaitable` ( #15650 )
2023-06-06 17:39:22 -05:00
4e6390cb10
Update error to more plainly explain we can only authorize our own events ( #15725 )
2023-06-06 16:26:12 -05:00
33c3550887
Add context for when/why to use the `long_retries` option when sending Federation requests ( #15721 )
2023-06-06 16:25:03 -05:00
6ee96e9366
Improve performance of user directory search ( #15729 )
2023-06-06 21:16:03 +01:00
d43c72a6c8
Prevent "twisted trunk" and "latest deps" workflows from running on forks ( #15726 )
2023-06-06 18:29:54 +00:00
dfd77f426e
Remove some unused `server_name` fields ( #15723 )
...
Signed-off-by: Sean Quah <seanq@matrix.org>
2023-06-06 12:32:29 +01:00
f880e64b11
Stabilize support for MSC3952: Intentional mentions. ( #15520 )
2023-06-06 09:11:07 +01:00
f9561b9e37
Some house keeping on `maybe_backfill()` functions ( #15709 )
2023-06-05 23:38:52 -05:00
d0c4257f14
`N + 3`: Read from column `full_user_id` rather than `user_id` of tables `profiles` and `user_filters` ( #15649 )
2023-06-02 17:24:13 -07:00
e0f2429d13
Add a catch-all * to the supported relation types when redacting ( #15705 )
...
This is an update to MSC3912 implementation
2023-06-02 13:13:50 +00:00
30a5076da8
Log when events are (unexpectedly) filtered out of responses in tests ( #14213 )
...
See https://github.com/matrix-org/synapse/pull/14095#discussion_r990335492
This is useful because when see that a relevant event is an `outlier` or `soft-failed`, then that's a good unexpected indicator explaining why it's not showing up. `filter_events_for_client` is used in `/sync`, `/messages`, `/context` which are all common end-to-end assertion touch points (also notifications, relations).
2023-06-01 21:27:18 -05:00
5ed0e8c61f
Cache requests for user's devices from federation ( #15675 )
...
This should mitigate the issue where lots of different servers requests
the same user's devices all at once.
2023-06-01 13:25:20 +00:00
d1693f0362
Implement stable support for MSC3882 to allow an existing device/session to generate a login token for use on a new device/session ( #15388 )
...
Implements stable support for MSC3882; this involves updating Synapse's support to
match the MSC / the spec says.
Continue to support the unstable version to allow clients to transition.
2023-06-01 08:52:51 -04:00
0b5f64ff09
Add Synapse version deploy annotations to Grafana dashboard ( #15674 )
...
Fix https://github.com/matrix-org/synapse/issues/15662
This manifests as purple lines that show up on all time series panels
that you can hover and see what version was deployed.
Also added a new "Deployed Synapse versions over time" panel
where the color block changes with each version. And mixed this
color block into the "Up" time series panel.
To get the Grafana dashboard JSON to copy here: use the **Share** icon at the top -> **Export** -> check the **Export for sharing externally** option -> **View JSON** or **Save to file**
2023-05-31 14:35:49 -05:00
6f18812bb0
Add stubs package for lxml. ( #15697 )
...
The stubs have some issues so this has some generous cast
and ignores in it, but it is better than not having stubs.
Note that confusing that Element is a function which creates
_Element instances (and similarly for Comment).
2023-05-31 17:06:57 +00:00
874378c052
Docker fully qualified image names ( #15689 )
...
* Fully qualified docker image names for the main Dockerfile and Complement related.
* Fully qualified docker image names for Dockerfiles associated with building Debian release artifacts.
This one is harder and is separate from the other commit in case it wasn't correct or was unwanted. I decided to
do the expansion on the docker images in the Dockerfile itself, instead of the various source places that build
which distribution that is selected, as it would have been more invasive with the scripts breaking up the string
for tagging and such. This one is untested.
* Changelog
* Update docker/Dockerfile-workers
* Update docker/complement/Dockerfile
---------
Co-authored-by: reivilibre <olivier@librepush.net>
2023-05-31 15:13:31 +00:00
daf3a67908
Add get_canonical_room_alias to module API ( #15450 )
...
Co-authored-by: Boxdot <d@zerovolt.org>
2023-05-31 09:18:37 -04:00
c01343de43
Add stricter mypy options ( #15694 )
...
Enable warn_unused_configs, strict_concatenate, disallow_subclassing_any,
and disallow_incomplete_defs.
2023-05-31 07:18:29 -04:00
6fc3deb029
Merge branch 'release-v1.85' into develop
2023-05-30 16:08:33 +01:00
ec9379d7e2
Newsfile.
2023-05-30 09:43:06 -04:00
5d8c659373
Remove unused `FederationServer.__str__` override ( #15690 )
...
Signed-off-by: Sean Quah <seanq@matrix.org>
2023-05-30 14:37:39 +01:00
a103b874dd
1.85.0rc1
2023-05-30 14:03:22 +01:00
42786d8a47
Create dependabot changelogs at release time ( #15481 )
...
* Ditch dependabot changelog workflow
* Summarise dependabot commits in release script
* Changelog
* Update scripts-dev/release.py
2023-05-30 13:54:50 +01:00
626bd75f48
Bump types-bleach from 6.0.0.1 to 6.0.0.3 ( #15686 )
...
* Bump types-bleach from 6.0.0.1 to 6.0.0.3
Bumps [types-bleach](https://github.com/python/typeshed ) from 6.0.0.1 to 6.0.0.3.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-bleach
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Changelog
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-05-30 11:13:04 +01:00
2b6c9150dc
Bump types-requests from 2.30.0.0 to 2.31.0.0 ( #15684 )
...
* Bump types-requests from 2.30.0.0 to 2.31.0.0
Bumps [types-requests](https://github.com/python/typeshed ) from 2.30.0.0 to 2.31.0.0.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-requests
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
* Changelog
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>
2023-05-30 11:03:58 +01:00
04798b710d
Bump log from 0.4.17 to 0.4.18 ( #15681 )
2023-05-29 14:15:49 -04:00
eb48b10f4f
Bump pydantic from 1.10.7 to 1.10.8 ( #15685 )
2023-05-29 14:14:58 -04:00
ea634a9f81
Bump prometheus-client from 0.16.0 to 0.17.0 ( #15682 )
2023-05-29 14:13:40 -04:00
4f07c2a170
Bump types-pyyaml from 6.0.12.9 to 6.0.12.10 ( #15683 )
2023-05-29 14:07:25 -04:00
c835befd10
Add Unix socket support for Redis connections ( #15644 )
...
Adds a new configuration setting to connect to Redis via a Unix
socket instead of over TCP. Disabled by default.
2023-05-26 15:28:39 -04:00
50918c4940
Add `MSC3820opt2` as a known room version ( #15678 )
2023-05-26 18:05:24 +00:00
179f0f851e
Documentation improvements to contributing guide ( #15667 ) ( #15668 )
...
Fix #15667
- Reiterate the importance of getting Rust installed and set up before attempting to install the Python dependencies.
- Mention the importance of confirming that `poetry install` completed successfully and include a typical error that the user might see if it did not.
- Expand on "Now edit homeserver.yaml" to give examples of things likely to need changing and to link to the relevant sections of the Synapse server documentation.
2023-05-26 12:28:04 -05:00
2ad91ec628
Set thread_id column to non-null for event_push_{actions,actions_staging,summary} ( #15597 )
...
Updates the database schema to require a thread_id (by adding a
constraint that the column is non-null) for event_push_actions,
event_push_actions_staging, and event_push_actions_summary.
For PostgreSQL we add the constraint as NOT VALID, then
VALIDATE the constraint a background job to avoid locking
the table during an upgrade.
Each table is updated as a separate schema delta to avoid
deadlocks between them.
For SQLite we simply rebuild the table & copy the data.
2023-05-26 13:16:08 -04:00
4e013093a8
Add MSC3820 (room version 11) option 2 unstable room version. ( #15666 )
2023-05-26 07:46:13 -04:00
77156a4bc1
Process previously failed backfill events in the background ( #15585 )
...
Process previously failed backfill events in the background because they are bound to fail again and we don't need to waste time holding up the request for something that is bound to fail again.
Fix https://github.com/matrix-org/synapse/issues/13623
Follow-up to https://github.com/matrix-org/synapse/issues/13621 and https://github.com/matrix-org/synapse/issues/13622
Part of making `/messages` faster: https://github.com/matrix-org/synapse/issues/13356
2023-05-24 23:22:24 -05:00
8839b6c2f8
Add requesting user id parameter to key claim methods in `TransportLayerClient` ( #15663 )
2023-05-24 13:23:26 -07:00
ca5c4be921
Add type hints to test_descriptors. ( #15659 )
...
Require type hints in test_descriptors and add missing ones.
2023-05-24 14:18:52 +00:00
c7e9c1d5ae
Speed up user directory rebuild for users some more... ( #15665 )
2023-05-24 14:13:28 +00:00
Travis Ralston