Andrew Morgan
|
3e58ce72b4
|
Don't bother responding to client requests that have already disconnected (#8465)
This PR ports the quick fix from https://github.com/matrix-org/synapse/pull/2796 to further methods which handle media, URL preview and `/key/v2/server` requests. This prevents a harmless `ERROR` that comes up in the logs when we were unable to respond to a client request when the client had already disconnected. In this case we simply bail out if the client has already done so.
This is the 'simple fix' as suggested by https://github.com/matrix-org/synapse/issues/5304#issuecomment-574740003.
Fixes https://github.com/matrix-org/synapse/issues/6700
Fixes https://github.com/matrix-org/synapse/issues/5304
|
2020-10-06 10:03:39 +01:00 |
|
Patrick Cloke
|
c619253db8
|
Stop sub-classing object (#8249)
|
2020-09-04 06:54:56 -04:00 |
|
Patrick Cloke
|
68626ff8e9
|
Convert the remaining media repo code to async / await. (#7947)
|
2020-07-27 14:40:11 -04:00 |
|
Patrick Cloke
|
5ea29d7f85
|
Convert more of the media code to async/await (#7873)
|
2020-07-24 09:39:02 -04:00 |
|
Dagfinn Ilmari Mannsåker
|
a3f11567d9
|
Replace all remaining six usage with native Python 3 equivalents (#7704)
|
2020-06-16 08:51:47 -04:00 |
|
Richard van der Hoff
|
d4676910c9
|
remove miscellaneous PY2 code
|
2020-05-15 19:37:41 +01:00 |
|
The Stranjer
|
5e477c1deb
|
Set charset to utf-8 when adding headers for certain text content types (#7044)
Fixes #7043
|
2020-03-17 13:29:09 +00:00 |
|
Patrick Cloke
|
509e381afa
|
Clarify list/set/dict/tuple comprehensions and enforce via flake8 (#6957)
Ensure good comprehension hygiene using flake8-comprehensions.
|
2020-02-21 07:15:07 -05:00 |
|
Michael Kaye
|
dc795ba709
|
Log responder we are using. (#6139)
This prevents us logging "Responding to media request with responder %s".
|
2019-10-07 15:41:25 +01:00 |
|
Amber Brown
|
463b072b12
|
Move logging utilities out of the side drawer of util/ and into logging/ (#5606)
|
2019-07-04 00:07:04 +10:00 |
|
Amber Brown
|
32e7c9e7f2
|
Run Black. (#5482)
|
2019-06-20 19:32:02 +10:00 |
|
Amber Brown
|
6b2b9a58c4
|
Prevent "producer not unregistered" message (#5009)
|
2019-04-24 17:37:32 +01:00 |
|
Andrew Morgan
|
caa76e6021
|
Remove periods from copyright headers (#5046)
|
2019-04-11 17:08:13 +01:00 |
|
Matthew Hodgson
|
2326e00bc4
|
fix incorrect encoding of filenames with spaces in (#2090)
fixes https://github.com/vector-im/riot-web/issues/3155
|
2019-03-11 09:53:45 +00:00 |
|
Richard van der Hoff
|
68f47d6744
|
Fix parsing of Content-Disposition headers (#4763)
* Fix parsing of Content-Disposition headers
TIL: filenames in content-dispostion headers can contain semicolons, and aren't
%-encoded.
* fix python2 incompatibility
* Fix docstrings
|
2019-02-27 14:29:10 -08:00 |
|
Erik Johnston
|
899a119c2b
|
Don't log stack trace when client has gone away during media download (#4738)
* Don't log stack trace when client has gone away during media download
* Newsfile
* Fixup newsfile
|
2019-02-25 11:17:22 -08:00 |
|
Amber Brown
|
8b1affe7d5
|
Fix Content-Disposition in media repository (#4176)
|
2018-11-15 15:55:58 -06:00 |
|
Amber Brown
|
02aa41809b
|
Port rest/ to Python 3 (#3823)
|
2018-09-12 20:41:31 +10:00 |
|
Amber Brown
|
49af402019
|
run isort
|
2018-07-09 16:09:20 +10:00 |
|
Richard van der Hoff
|
be31adb036
|
Fix logcontext leak in media repo
Make FileResponder.write_to_consumer uphold the logcontext contract
|
2018-05-02 16:14:50 +01:00 |
|
Adrian Tschira
|
2a3c33ff03
|
Use six.moves.urlparse
The imports were shuffled around a bunch in py3
Signed-off-by: Adrian Tschira <nota@notafile.com>
|
2018-04-15 21:22:43 +02:00 |
|
Erik Johnston
|
694f1c1b18
|
Fix up comments
|
2018-01-12 15:02:46 +00:00 |
|
Erik Johnston
|
85a4d78213
|
Make Responder a context manager
|
2018-01-12 13:32:03 +00:00 |
|
Erik Johnston
|
227c491510
|
Comments
|
2018-01-12 11:22:41 +00:00 |
|
Erik Johnston
|
1ee787912b
|
Add some helper classes
|
2018-01-09 16:15:07 +00:00 |
|
Erik Johnston
|
47ca5eb882
|
Split out add_file_headers
|
2018-01-09 16:15:07 +00:00 |
|
Richard van der Hoff
|
eaaabc6c4f
|
replace 'except:' with 'except Exception:'
what could possibly go wrong
|
2017-10-23 15:52:32 +01:00 |
|
Richard van der Hoff
|
d03cfc4258
|
Fix a logcontext leak in the media repo
|
2017-10-23 14:34:27 +01:00 |
|
Erik Johnston
|
0c93df89b6
|
Move MediaRepository to media_repository module
|
2016-04-19 11:31:43 +01:00 |