MatrixSynapse/changelog.d
David Robertson 2d91b6256e
Fix adding excluded users to the private room sharing tables when joining a room (#11143)
* We only need to fetch users in private rooms

* Filter out `user_id` at the top

* Discard excluded users in the top loop

We weren't doing this in the "First, if they're our user" branch so this
is a bugfix.

* The caller must check that `user_id` is included

This is in the docstring. There are two call sites:
- one in `_handle_room_publicity_change`, which explicitly checks before calling;
- and another in `_handle_room_membership_event`, which returns early if
  the user is excluded.

So this change is safe.

* Test joining a private room with an excluded user

* Tweak an existing test

* Changelog

* test docstring

* lint
2021-10-21 17:48:59 +01:00
..
.gitignore
10548.feature
10972.misc
10975.feature
10984.misc Fix logging context warnings when losing replication connection (#10984) 2021-10-15 13:10:58 +01:00
11001.bugfix Check auth on received events' auth_events (#11001) 2021-10-18 18:29:37 +01:00
11008.misc Include rejected status when we log events. (#11008) 2021-10-19 10:21:50 +01:00
11009.bugfix Check *all* auth events for room id and rejection (#11009) 2021-10-18 18:28:30 +01:00
11014.misc `_run_push_actions_and_persist_event`: handle no min_depth (#11014) 2021-10-18 17:17:15 +01:00
11024.misc
11027.bugfix
11035.misc
11048.misc
11051.bugfix Fix setting a user's external_id via the admin API returns 500 and deletes users existing external mappings if that external ID is already mapped (#11051) 2021-10-21 09:52:32 +01:00
11054.misc
11055.misc
11056.misc
11057.misc
11065.misc
11066.misc
11068.misc
11069.doc
11070.misc Move experimental & retention config out of the server module. (#11070) 2021-10-15 14:30:48 +00:00
11071.misc
11075.bugfix Correctly exclude users when making a room public or private (#11075) 2021-10-15 15:53:05 +01:00
11076.misc
11077.bugfix
11078.bugfix Fix broken export-data admin command and add a test for it to CI (#11078) 2021-10-18 08:14:12 -07:00
11089.bugfix
11092.doc Remove false warning about copying the log config to a homeserver.yaml (#11092) 2021-10-20 11:48:15 +00:00
11093.doc Update doc of the allowed characters for registration tokens (#11093) 2021-10-15 09:56:39 +00:00
11096.doc Document Synapse's behaviour when dealing with multiple modules (#11096) 2021-10-18 18:26:52 +02:00
11101.bugfix Show error when timestamp in seconds is provided to the /purge_media_cache API (#11101) 2021-10-20 14:41:48 +00:00
11103.bugfix Don't remove local users from dir when the leave their last room (#11103) 2021-10-18 13:20:04 +00:00
11109.misc Add missing type hints to synapse.api. (#11109) 2021-10-18 15:01:10 -04:00
11115.misc Move _persist_auth_tree into FederationEventHandler (#11115) 2021-10-19 10:24:09 +01:00
11116.misc Rename `_auth_and_persist_fetched_events` (#11116) 2021-10-19 10:23:55 +01:00
11118.doc Fix instances of [example]{.title-ref} in the upgrade notes (#11118) 2021-10-19 14:13:56 +01:00
11120.bugfix Consider IP whitelist for identity server resolution (#11120) 2021-10-20 18:43:49 +01:00
11121.misc Add missing type hints to event fetching. (#11121) 2021-10-19 14:29:03 +00:00
11122.misc Clean up `_update_auth_events_and_context_for_auth` (#11122) 2021-10-20 18:22:40 +01:00
11132.doc Document the version of Synapse each module callback was introduced in (#11132) 2021-10-20 11:04:27 +00:00
11138.misc Improve docstrings for methods related to sending EDUs to application services (#11138) 2021-10-21 17:42:25 +01:00
11139.misc Update `sign_json` to support inline key config (#11139) 2021-10-20 18:49:20 +01:00
11143.misc Fix adding excluded users to the private room sharing tables when joining a room (#11143) 2021-10-21 17:48:59 +01:00
11144.misc fix relative link in docker readme (#11144) 2021-10-21 13:50:43 +01:00
11146.misc Add missing type hints to synapse.crypto. (#11146) 2021-10-21 13:07:07 +00:00