MatrixSynapse/synapse/config
David Robertson 796a4b7482
Prefer `type(x) is int` to `isinstance(x, int)` (#14945)
* Perfer `type(x) is int` to `isinstance(x, int)`

This covered all additional instances I could see where `x` was
user-controlled.
The remaining cases are

```
$ rg -s 'isinstance.*[^_]int'
tests/replication/_base.py
576:        if isinstance(obj, int):

synapse/util/caches/stream_change_cache.py
136:        assert isinstance(stream_pos, int)
214:        assert isinstance(stream_pos, int)
246:        assert isinstance(stream_pos, int)
267:        assert isinstance(stream_pos, int)

synapse/replication/tcp/external_cache.py
133:        if isinstance(result, int):

synapse/metrics/__init__.py
100:        if isinstance(calls, (int, float)):

synapse/handlers/appservice.py
262:        assert isinstance(new_token, int)

synapse/config/_util.py
62:        if isinstance(p, int):
```

which cover metrics, logic related to `jsonschema`, and replication and
data streams. AFAICS these are all internal to Synapse

* Changelog
2023-01-31 10:33:07 +00:00
..
__init__.py
__main__.py
_base.py Prefer `type(x) is int` to `isinstance(x, int)` (#14945) 2023-01-31 10:33:07 +00:00
_base.pyi
_util.py
account_validity.py
api.py
appservice.py
auth.py
background_updates.py
cache.py Prefer `type(x) is int` to `isinstance(x, int)` (#14945) 2023-01-31 10:33:07 +00:00
captcha.py
cas.py
consent.py
database.py
emailconfig.py
experimental.py
federation.py
homeserver.py
jwt.py
key.py
logger.py
metrics.py
modules.py
oembed.py
oidc.py
password_auth_providers.py
push.py
ratelimiting.py
redis.py
registration.py
repository.py
retention.py
room.py
room_directory.py
saml2.py
server.py Prefer `type(x) is int` to `isinstance(x, int)` (#14945) 2023-01-31 10:33:07 +00:00
server_notices.py
spam_checker.py
sso.py
stats.py
third_party_event_rules.py
tls.py
tracer.py
user_directory.py
voip.py
workers.py