MatrixSynapse/synapse/storage/databases/main
David Robertson 796a4b7482
Prefer `type(x) is int` to `isinstance(x, int)` (#14945)
* Perfer `type(x) is int` to `isinstance(x, int)`

This covered all additional instances I could see where `x` was
user-controlled.
The remaining cases are

```
$ rg -s 'isinstance.*[^_]int'
tests/replication/_base.py
576:        if isinstance(obj, int):

synapse/util/caches/stream_change_cache.py
136:        assert isinstance(stream_pos, int)
214:        assert isinstance(stream_pos, int)
246:        assert isinstance(stream_pos, int)
267:        assert isinstance(stream_pos, int)

synapse/replication/tcp/external_cache.py
133:        if isinstance(result, int):

synapse/metrics/__init__.py
100:        if isinstance(calls, (int, float)):

synapse/handlers/appservice.py
262:        assert isinstance(new_token, int)

synapse/config/_util.py
62:        if isinstance(p, int):
```

which cover metrics, logic related to `jsonschema`, and replication and
data streams. AFAICS these are all internal to Synapse

* Changelog
2023-01-31 10:33:07 +00:00
..
__init__.py
account_data.py
appservice.py
cache.py
censor_events.py
client_ips.py
deviceinbox.py
devices.py
directory.py
e2e_room_keys.py
end_to_end_keys.py
event_federation.py
event_push_actions.py
events.py Prefer `type(x) is int` to `isinstance(x, int)` (#14945) 2023-01-31 10:33:07 +00:00
events_bg_updates.py
events_forward_extremities.py
events_worker.py
filtering.py
keys.py
lock.py
media_repository.py
metrics.py
monthly_active_users.py
openid.py
presence.py
profile.py
purge_events.py
push_rule.py
pusher.py
receipts.py
registration.py
rejections.py
relations.py
room.py
room_batch.py
roommember.py
search.py
session.py
signatures.py
state.py
state_deltas.py
stats.py
stream.py
tags.py
transactions.py
ui_auth.py
user_directory.py
user_erasure_store.py