2021-08-27 14:32:44 +02:00
|
|
|
import express from 'express'
|
2021-05-12 14:51:17 +02:00
|
|
|
import { Transaction } from 'sequelize/types'
|
|
|
|
import { changeVideoChannelShare } from '@server/lib/activitypub/share'
|
2022-10-12 16:09:02 +02:00
|
|
|
import { addVideoJobsAfterUpdate, buildVideoThumbnailsFromReq, setVideoTags } from '@server/lib/video'
|
|
|
|
import { setVideoPrivacy } from '@server/lib/video-privacy'
|
2021-07-16 10:42:24 +02:00
|
|
|
import { openapiOperationDoc } from '@server/middlewares/doc'
|
2021-05-12 14:51:17 +02:00
|
|
|
import { FilteredModelAttributes } from '@server/types'
|
|
|
|
import { MVideoFullLight } from '@server/types/models'
|
Add Podcast RSS feeds (#5487)
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Add correct feed image to RSS channel
* Prefer HLS videos for podcast RSS
Remove video/stream titles, add optional height attribute to podcast RSS
* Prefix podcast RSS images with root server URL
* Add optional video query support to include captions
* Add transcripts & person images to podcast RSS feed
* Prefer webseed/webtorrent files over HLS fragmented mp4s
* Experimentally adding podcast fields to basic config page
* Add validation for new basic config fields
* Don't include "content" in podcast feed, use full description for "description"
* Initial test implementation of Podcast RSS
This is a pretty simple implementation to add support for The Podcast Namespace in RSS -- instead of affecting the existing RSS implementation, this adds a new UI option.
I attempted to retain compatibility with the rest of the RSS feed implementation as much as possible and have created a temporary fork of the "pfeed" library to support this effort.
* Update to pfeed-podcast 1.2.2
* Add correct feed image to RSS channel
* Prefer HLS videos for podcast RSS
Remove video/stream titles, add optional height attribute to podcast RSS
* Prefix podcast RSS images with root server URL
* Add optional video query support to include captions
* Add transcripts & person images to podcast RSS feed
* Prefer webseed/webtorrent files over HLS fragmented mp4s
* Experimentally adding podcast fields to basic config page
* Add validation for new basic config fields
* Don't include "content" in podcast feed, use full description for "description"
* Add medium/socialInteract to podcast RSS feeds. Use HTML for description
* Change base production image to bullseye, install prosody in image
* Add liveItem and trackers to Podcast RSS feeds
Remove height from alternateEnclosure, replaced with title.
* Clear Podcast RSS feed cache when live streams start/end
* Upgrade to Node 16
* Refactor clearCacheRoute to use ApiCache
* Remove unnecessary type hint
* Update dockerfile to node 16, install python-is-python2
* Use new file paths for captions/playlists
* Fix legacy videos in RSS after migration to object storage
* Improve method of identifying non-fragmented mp4s in podcast RSS feeds
* Don't include fragmented MP4s in podcast RSS feeds
* Add experimental support for podcast:categories on the podcast RSS item
* Fix undefined category when no videos exist
Allows for empty feeds to exist (important for feeds that might only go live)
* Add support for podcast:locked -- user has to opt in to show their email
* Use comma for podcast:categories delimiter
* Make cache clearing async
* Fix merge, temporarily test with pfeed-podcast
* Syntax changes
* Add EXT_MIMETYPE constants for captions
* Update & fix tests, fix enclosure mimetypes, remove admin email
* Add test for podacst:socialInteract
* Add filters hooks for podcast customTags
* Remove showdown, updated to pfeed-podcast 6.1.2
* Add 'action:api.live-video.state.updated' hook
* Avoid assigning undefined category to podcast feeds
* Remove nvmrc
* Remove comment
* Remove unused podcast config
* Remove more unused podcast config
* Fix MChannelAccountDefault type hint missed in merge
* Remove extra line
* Re-add newline in config
* Fix lint errors for isEmailPublic
* Fix thumbnails in podcast feeds
* Requested changes based on review
* Provide podcast rss 2.0 only on video channels
* Misc cleanup for a less messy PR
* Lint fixes
* Remove pfeed-podcast
* Add peertube version to new hooks
* Don't use query include, remove TODO
* Remove film medium hack
* Clear podcast rss cache before video/channel update hooks
* Clear podcast rss cache before video uploaded/deleted hooks
* Refactor podcast feed cache clearing
* Set correct person name from video channel
* Styling
* Fix tests
---------
Co-authored-by: Chocobozzz <me@florianbigard.com>
2023-05-22 16:00:05 +02:00
|
|
|
import { forceNumber } from '@shared/core-utils'
|
2023-06-29 09:48:55 +02:00
|
|
|
import { HttpStatusCode, VideoPrivacy, VideoUpdate } from '@shared/models'
|
2021-05-12 14:51:17 +02:00
|
|
|
import { auditLoggerFactory, getAuditIdFromRes, VideoAuditView } from '../../../helpers/audit-logger'
|
|
|
|
import { resetSequelizeInstance } from '../../../helpers/database-utils'
|
|
|
|
import { createReqFiles } from '../../../helpers/express-utils'
|
|
|
|
import { logger, loggerTagsFactory } from '../../../helpers/logger'
|
|
|
|
import { MIMETYPES } from '../../../initializers/constants'
|
|
|
|
import { sequelizeTypescript } from '../../../initializers/database'
|
|
|
|
import { Hooks } from '../../../lib/plugins/hooks'
|
|
|
|
import { autoBlacklistVideoIfNeeded } from '../../../lib/video-blacklist'
|
|
|
|
import { asyncMiddleware, asyncRetryTransactionMiddleware, authenticate, videosUpdateValidator } from '../../../middlewares'
|
|
|
|
import { ScheduleVideoUpdateModel } from '../../../models/video/schedule-video-update'
|
|
|
|
import { VideoModel } from '../../../models/video/video'
|
2023-06-29 09:48:55 +02:00
|
|
|
import { VideoPathManager } from '@server/lib/video-path-manager'
|
|
|
|
import { VideoPasswordModel } from '@server/models/video/video-password'
|
|
|
|
import { exists } from '@server/helpers/custom-validators/misc'
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
const lTags = loggerTagsFactory('api', 'video')
|
|
|
|
const auditLogger = auditLoggerFactory('videos')
|
|
|
|
const updateRouter = express.Router()
|
|
|
|
|
2022-03-04 10:57:36 +01:00
|
|
|
const reqVideoFileUpdate = createReqFiles([ 'thumbnailfile', 'previewfile' ], MIMETYPES.IMAGE.MIMETYPE_EXT)
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
updateRouter.put('/:id',
|
2021-06-04 08:57:07 +02:00
|
|
|
openapiOperationDoc({ operationId: 'putVideo' }),
|
2021-05-12 14:51:17 +02:00
|
|
|
authenticate,
|
|
|
|
reqVideoFileUpdate,
|
|
|
|
asyncMiddleware(videosUpdateValidator),
|
|
|
|
asyncRetryTransactionMiddleware(updateVideo)
|
|
|
|
)
|
|
|
|
|
|
|
|
// ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
export {
|
|
|
|
updateRouter
|
|
|
|
}
|
|
|
|
|
|
|
|
// ---------------------------------------------------------------------------
|
|
|
|
|
2021-11-17 16:04:53 +01:00
|
|
|
async function updateVideo (req: express.Request, res: express.Response) {
|
2021-11-10 14:57:09 +01:00
|
|
|
const videoFromReq = res.locals.videoAll
|
|
|
|
const oldVideoAuditView = new VideoAuditView(videoFromReq.toFormattedDetailsJSON())
|
2021-05-12 14:51:17 +02:00
|
|
|
const videoInfoToUpdate: VideoUpdate = req.body
|
|
|
|
|
2021-11-10 14:57:09 +01:00
|
|
|
const hadPrivacyForFederation = videoFromReq.hasPrivacyForFederation()
|
2022-10-12 16:09:02 +02:00
|
|
|
const oldPrivacy = videoFromReq.privacy
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
const [ thumbnailModel, previewModel ] = await buildVideoThumbnailsFromReq({
|
2021-11-10 14:57:09 +01:00
|
|
|
video: videoFromReq,
|
2021-05-12 14:51:17 +02:00
|
|
|
files: req.files,
|
|
|
|
fallback: () => Promise.resolve(undefined),
|
|
|
|
automaticallyGenerated: false
|
|
|
|
})
|
|
|
|
|
2022-10-12 16:09:02 +02:00
|
|
|
const videoFileLockReleaser = await VideoPathManager.Instance.lockFiles(videoFromReq.uuid)
|
|
|
|
|
2021-05-12 14:51:17 +02:00
|
|
|
try {
|
2021-12-08 11:32:45 +01:00
|
|
|
const { videoInstanceUpdated, isNewVideo } = await sequelizeTypescript.transaction(async t => {
|
2021-11-10 14:57:09 +01:00
|
|
|
// Refresh video since thumbnails to prevent concurrent updates
|
2022-06-28 14:57:51 +02:00
|
|
|
const video = await VideoModel.loadFull(videoFromReq.id, t)
|
2021-11-10 14:57:09 +01:00
|
|
|
|
|
|
|
const oldVideoChannel = video.VideoChannel
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
const keysToUpdate: (keyof VideoUpdate & FilteredModelAttributes<VideoModel>)[] = [
|
|
|
|
'name',
|
|
|
|
'category',
|
|
|
|
'licence',
|
|
|
|
'language',
|
|
|
|
'nsfw',
|
|
|
|
'waitTranscoding',
|
|
|
|
'support',
|
|
|
|
'description',
|
|
|
|
'commentsEnabled',
|
|
|
|
'downloadEnabled'
|
|
|
|
]
|
|
|
|
|
|
|
|
for (const key of keysToUpdate) {
|
2021-11-10 14:57:09 +01:00
|
|
|
if (videoInfoToUpdate[key] !== undefined) video.set(key, videoInfoToUpdate[key])
|
2021-05-12 14:51:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
if (videoInfoToUpdate.originallyPublishedAt !== undefined && videoInfoToUpdate.originallyPublishedAt !== null) {
|
2021-11-10 14:57:09 +01:00
|
|
|
video.originallyPublishedAt = new Date(videoInfoToUpdate.originallyPublishedAt)
|
2021-05-12 14:51:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Privacy update?
|
|
|
|
let isNewVideo = false
|
|
|
|
if (videoInfoToUpdate.privacy !== undefined) {
|
2021-11-10 14:57:09 +01:00
|
|
|
isNewVideo = await updateVideoPrivacy({ videoInstance: video, videoInfoToUpdate, hadPrivacyForFederation, transaction: t })
|
2021-05-12 14:51:17 +02:00
|
|
|
}
|
|
|
|
|
2021-11-10 14:34:02 +01:00
|
|
|
// Force updatedAt attribute change
|
2021-11-10 14:57:09 +01:00
|
|
|
if (!video.changed()) {
|
2021-11-10 15:52:22 +01:00
|
|
|
await video.setAsRefreshed(t)
|
2021-11-10 14:34:02 +01:00
|
|
|
}
|
|
|
|
|
2022-10-12 16:09:02 +02:00
|
|
|
const videoInstanceUpdated = await video.save({ transaction: t }) as MVideoFullLight
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
// Thumbnail & preview updates?
|
|
|
|
if (thumbnailModel) await videoInstanceUpdated.addAndSaveThumbnail(thumbnailModel, t)
|
|
|
|
if (previewModel) await videoInstanceUpdated.addAndSaveThumbnail(previewModel, t)
|
|
|
|
|
|
|
|
// Video tags update?
|
|
|
|
if (videoInfoToUpdate.tags !== undefined) {
|
|
|
|
await setVideoTags({ video: videoInstanceUpdated, tags: videoInfoToUpdate.tags, transaction: t })
|
|
|
|
}
|
|
|
|
|
|
|
|
// Video channel update?
|
|
|
|
if (res.locals.videoChannel && videoInstanceUpdated.channelId !== res.locals.videoChannel.id) {
|
|
|
|
await videoInstanceUpdated.$set('VideoChannel', res.locals.videoChannel, { transaction: t })
|
|
|
|
videoInstanceUpdated.VideoChannel = res.locals.videoChannel
|
|
|
|
|
2022-10-12 16:09:02 +02:00
|
|
|
if (hadPrivacyForFederation === true) {
|
|
|
|
await changeVideoChannelShare(videoInstanceUpdated, oldVideoChannel, t)
|
|
|
|
}
|
2021-05-12 14:51:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Schedule an update in the future?
|
|
|
|
await updateSchedule(videoInstanceUpdated, videoInfoToUpdate, t)
|
|
|
|
|
|
|
|
await autoBlacklistVideoIfNeeded({
|
|
|
|
video: videoInstanceUpdated,
|
|
|
|
user: res.locals.oauth.token.User,
|
|
|
|
isRemote: false,
|
|
|
|
isNew: false,
|
|
|
|
transaction: t
|
|
|
|
})
|
|
|
|
|
|
|
|
auditLogger.update(
|
|
|
|
getAuditIdFromRes(res),
|
|
|
|
new VideoAuditView(videoInstanceUpdated.toFormattedDetailsJSON()),
|
|
|
|
oldVideoAuditView
|
|
|
|
)
|
2021-11-10 14:57:09 +01:00
|
|
|
logger.info('Video with name %s and uuid %s updated.', video.name, video.uuid, lTags(video.uuid))
|
2021-05-12 14:51:17 +02:00
|
|
|
|
2021-12-08 11:32:45 +01:00
|
|
|
return { videoInstanceUpdated, isNewVideo }
|
2021-05-12 14:51:17 +02:00
|
|
|
})
|
|
|
|
|
2022-08-08 15:48:17 +02:00
|
|
|
Hooks.runAction('action:api.video.updated', { video: videoInstanceUpdated, body: req.body, req, res })
|
2021-12-08 11:32:45 +01:00
|
|
|
|
2022-10-12 16:09:02 +02:00
|
|
|
await addVideoJobsAfterUpdate({
|
|
|
|
video: videoInstanceUpdated,
|
|
|
|
nameChanged: !!videoInfoToUpdate.name,
|
|
|
|
oldPrivacy,
|
|
|
|
isNewVideo
|
|
|
|
})
|
2021-05-12 14:51:17 +02:00
|
|
|
} catch (err) {
|
|
|
|
// If the transaction is retried, sequelize will think the object has not changed
|
2023-02-14 08:59:27 +01:00
|
|
|
// So we need to restore the previous fields
|
2023-05-11 15:02:53 +02:00
|
|
|
await resetSequelizeInstance(videoFromReq)
|
2021-05-12 14:51:17 +02:00
|
|
|
|
|
|
|
throw err
|
2022-10-12 16:09:02 +02:00
|
|
|
} finally {
|
|
|
|
videoFileLockReleaser()
|
2021-05-12 14:51:17 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return res.type('json')
|
|
|
|
.status(HttpStatusCode.NO_CONTENT_204)
|
|
|
|
.end()
|
|
|
|
}
|
|
|
|
|
|
|
|
async function updateVideoPrivacy (options: {
|
|
|
|
videoInstance: MVideoFullLight
|
|
|
|
videoInfoToUpdate: VideoUpdate
|
|
|
|
hadPrivacyForFederation: boolean
|
|
|
|
transaction: Transaction
|
|
|
|
}) {
|
|
|
|
const { videoInstance, videoInfoToUpdate, hadPrivacyForFederation, transaction } = options
|
|
|
|
const isNewVideo = videoInstance.isNewVideo(videoInfoToUpdate.privacy)
|
|
|
|
|
2022-11-15 14:41:55 +01:00
|
|
|
const newPrivacy = forceNumber(videoInfoToUpdate.privacy)
|
2022-10-12 16:09:02 +02:00
|
|
|
setVideoPrivacy(videoInstance, newPrivacy)
|
2021-05-12 14:51:17 +02:00
|
|
|
|
2023-06-29 09:48:55 +02:00
|
|
|
// Delete passwords if video is not anymore password protected
|
|
|
|
if (videoInstance.privacy === VideoPrivacy.PASSWORD_PROTECTED && newPrivacy !== VideoPrivacy.PASSWORD_PROTECTED) {
|
|
|
|
await VideoPasswordModel.deleteAllPasswords(videoInstance.id, transaction)
|
|
|
|
}
|
|
|
|
|
|
|
|
if (newPrivacy === VideoPrivacy.PASSWORD_PROTECTED && exists(videoInfoToUpdate.videoPasswords)) {
|
|
|
|
await VideoPasswordModel.deleteAllPasswords(videoInstance.id, transaction)
|
|
|
|
await VideoPasswordModel.addPasswords(videoInfoToUpdate.videoPasswords, videoInstance.id, transaction)
|
|
|
|
}
|
|
|
|
|
2021-05-12 14:51:17 +02:00
|
|
|
// Unfederate the video if the new privacy is not compatible with federation
|
|
|
|
if (hadPrivacyForFederation && !videoInstance.hasPrivacyForFederation()) {
|
|
|
|
await VideoModel.sendDelete(videoInstance, { transaction })
|
|
|
|
}
|
|
|
|
|
|
|
|
return isNewVideo
|
|
|
|
}
|
|
|
|
|
|
|
|
function updateSchedule (videoInstance: MVideoFullLight, videoInfoToUpdate: VideoUpdate, transaction: Transaction) {
|
|
|
|
if (videoInfoToUpdate.scheduleUpdate) {
|
|
|
|
return ScheduleVideoUpdateModel.upsert({
|
|
|
|
videoId: videoInstance.id,
|
|
|
|
updateAt: new Date(videoInfoToUpdate.scheduleUpdate.updateAt),
|
|
|
|
privacy: videoInfoToUpdate.scheduleUpdate.privacy || null
|
|
|
|
}, { transaction })
|
|
|
|
} else if (videoInfoToUpdate.scheduleUpdate === null) {
|
|
|
|
return ScheduleVideoUpdateModel.deleteByVideoId(videoInstance.id, transaction)
|
|
|
|
}
|
|
|
|
}
|