PeerTube/server/tests/api/activitypub/security.ts

291 lines
11 KiB
TypeScript
Raw Normal View History

2020-01-31 16:56:52 +01:00
/* eslint-disable @typescript-eslint/no-unused-expressions,@typescript-eslint/require-await */
import 'mocha'
import * as chai from 'chai'
2020-04-23 09:32:53 +02:00
import { buildDigest } from '@server/helpers/peertube-crypto'
2021-07-16 10:42:24 +02:00
import { HTTP_SIGNATURE } from '@server/initializers/constants'
import { buildSignedActivity } from '@server/lib/activitypub/activity'
import { activityPubContextify } from '@server/lib/activitypub/context'
2021-07-16 10:42:24 +02:00
import { buildGlobalHeaders } from '@server/lib/job-queue/handlers/utils/activitypub-http-utils'
import { makeFollowRequest, makePOSTAPRequest } from '@server/tests/shared'
import { buildAbsoluteFixturePath, wait } from '@shared/core-utils'
2021-07-16 10:42:24 +02:00
import { HttpStatusCode } from '@shared/models'
import { cleanupTests, createMultipleServers, killallServers, PeerTubeServer } from '@shared/server-commands'
const expect = chai.expect
2021-07-16 09:47:51 +02:00
function setKeysOfServer (onServer: PeerTubeServer, ofServer: PeerTubeServer, publicKey: string, privateKey: string) {
2021-03-10 11:17:20 +01:00
const url = 'http://localhost:' + ofServer.port + '/accounts/peertube'
return Promise.all([
2021-07-16 09:04:35 +02:00
onServer.sql.setActorField(url, 'publicKey', publicKey),
onServer.sql.setActorField(url, 'privateKey', privateKey)
2021-03-10 11:17:20 +01:00
])
}
2021-07-16 09:47:51 +02:00
function setUpdatedAtOfServer (onServer: PeerTubeServer, ofServer: PeerTubeServer, updatedAt: string) {
2021-03-10 11:17:20 +01:00
const url = 'http://localhost:' + ofServer.port + '/accounts/peertube'
return Promise.all([
2021-07-16 09:04:35 +02:00
onServer.sql.setActorField(url, 'createdAt', updatedAt),
onServer.sql.setActorField(url, 'updatedAt', updatedAt)
])
}
2021-07-16 09:47:51 +02:00
function getAnnounceWithoutContext (server: PeerTubeServer) {
2021-06-14 16:52:22 +02:00
const json = require(buildAbsoluteFixturePath('./ap-json/peertube/announce-without-context.json'))
2019-04-26 08:50:52 +02:00
const result: typeof json = {}
for (const key of Object.keys(json)) {
if (Array.isArray(json[key])) {
2021-03-10 11:17:20 +01:00
result[key] = json[key].map(v => v.replace(':9002', `:${server.port}`))
2019-04-26 08:50:52 +02:00
} else {
2021-03-10 11:17:20 +01:00
result[key] = json[key].replace(':9002', `:${server.port}`)
2019-04-26 08:50:52 +02:00
}
}
return result
}
describe('Test ActivityPub security', function () {
2021-07-16 09:47:51 +02:00
let servers: PeerTubeServer[]
let url: string
2021-06-14 16:52:22 +02:00
const keys = require(buildAbsoluteFixturePath('./ap-json/peertube/keys.json'))
const invalidKeys = require(buildAbsoluteFixturePath('./ap-json/peertube/invalid-keys.json'))
2019-04-26 08:50:52 +02:00
const baseHttpSignature = () => ({
algorithm: HTTP_SIGNATURE.ALGORITHM,
authorizationHeaderName: HTTP_SIGNATURE.HEADER_NAME,
2019-04-26 08:50:52 +02:00
keyId: 'acct:peertube@localhost:' + servers[1].port,
key: keys.privateKey,
headers: HTTP_SIGNATURE.HEADERS_TO_SIGN
2019-04-26 08:50:52 +02:00
})
// ---------------------------------------------------------------
before(async function () {
this.timeout(60000)
2021-07-16 09:47:51 +02:00
servers = await createMultipleServers(3)
url = servers[0].url + '/inbox'
2021-03-10 11:17:20 +01:00
await setKeysOfServer(servers[0], servers[1], keys.publicKey, null)
await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
2019-04-26 08:50:52 +02:00
const to = { url: 'http://localhost:' + servers[0].port + '/accounts/peertube' }
const by = { url: 'http://localhost:' + servers[1].port + '/accounts/peertube', privateKey: keys.privateKey }
await makeFollowRequest(to, by)
})
describe('When checking HTTP signature', function () {
it('Should fail with an invalid digest', async function () {
2019-04-26 08:50:52 +02:00
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = {
Digest: buildDigest({ hello: 'coucou' })
}
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
})
it('Should fail with an invalid date', async function () {
2019-04-26 08:50:52 +02:00
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
headers['date'] = 'Wed, 21 Oct 2015 07:28:00 GMT'
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
})
it('Should fail with bad keys', async function () {
2019-04-26 08:50:52 +02:00
await setKeysOfServer(servers[0], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
await setKeysOfServer(servers[1], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
2019-04-26 08:50:52 +02:00
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
})
it('Should reject requests without appropriate signed headers', async function () {
2019-04-26 08:50:52 +02:00
await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
2019-04-26 08:50:52 +02:00
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
const signatureOptions = baseHttpSignature()
const badHeadersMatrix = [
[ '(request-target)', 'date', 'digest' ],
[ 'host', 'date', 'digest' ],
[ '(request-target)', 'host', 'digest' ]
]
for (const badHeaders of badHeadersMatrix) {
signatureOptions.headers = badHeaders
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, body, signatureOptions, headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
}
})
it('Should succeed with a valid HTTP signature', async function () {
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
2021-03-08 14:24:11 +01:00
const { statusCode } = await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(statusCode).to.equal(HttpStatusCode.NO_CONTENT_204)
})
2021-02-26 14:42:34 +01:00
it('Should refresh the actor keys', async function () {
this.timeout(20000)
// Update keys of server 2 to invalid keys
// Server 1 should refresh the actor and fail
await setKeysOfServer(servers[1], servers[1], invalidKeys.publicKey, invalidKeys.privateKey)
2021-03-10 11:17:20 +01:00
await setUpdatedAtOfServer(servers[0], servers[1], '2015-07-17 22:00:00+00')
// Invalid peertube actor cache
2021-07-09 15:37:43 +02:00
await killallServers([ servers[1] ])
2021-07-16 09:47:51 +02:00
await servers[1].run()
2021-02-26 14:42:34 +01:00
const body = activityPubContextify(getAnnounceWithoutContext(servers[1]))
const headers = buildGlobalHeaders(body)
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, body, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
2021-03-10 11:17:20 +01:00
console.error(err)
2021-03-09 14:01:44 +01:00
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
2021-02-26 14:42:34 +01:00
})
})
describe('When checking Linked Data Signature', function () {
2021-02-26 14:42:34 +01:00
before(async function () {
this.timeout(10000)
await setKeysOfServer(servers[0], servers[1], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[1], servers[1], keys.publicKey, keys.privateKey)
2019-04-26 08:50:52 +02:00
await setKeysOfServer(servers[2], servers[2], keys.publicKey, keys.privateKey)
2019-04-26 08:50:52 +02:00
const to = { url: 'http://localhost:' + servers[0].port + '/accounts/peertube' }
const by = { url: 'http://localhost:' + servers[2].port + '/accounts/peertube', privateKey: keys.privateKey }
await makeFollowRequest(to, by)
})
it('Should fail with bad keys', async function () {
this.timeout(10000)
2019-04-26 08:50:52 +02:00
await setKeysOfServer(servers[0], servers[2], invalidKeys.publicKey, invalidKeys.privateKey)
await setKeysOfServer(servers[2], servers[2], invalidKeys.publicKey, invalidKeys.privateKey)
2019-04-26 08:50:52 +02:00
const body = getAnnounceWithoutContext(servers[1])
body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
2019-04-26 08:50:52 +02:00
const signer: any = { privateKey: invalidKeys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
const signedBody = await buildSignedActivity(signer, body)
const headers = buildGlobalHeaders(signedBody)
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
})
it('Should fail with an altered body', async function () {
this.timeout(10000)
2019-04-26 08:50:52 +02:00
await setKeysOfServer(servers[0], servers[2], keys.publicKey, keys.privateKey)
await setKeysOfServer(servers[0], servers[2], keys.publicKey, keys.privateKey)
2019-04-26 08:50:52 +02:00
const body = getAnnounceWithoutContext(servers[1])
body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
2019-04-26 08:50:52 +02:00
const signer: any = { privateKey: keys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
const signedBody = await buildSignedActivity(signer, body)
2019-04-26 08:50:52 +02:00
signedBody.actor = 'http://localhost:' + servers[2].port + '/account/peertube'
const headers = buildGlobalHeaders(signedBody)
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
})
it('Should succeed with a valid signature', async function () {
this.timeout(10000)
2019-04-26 08:50:52 +02:00
const body = getAnnounceWithoutContext(servers[1])
body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
2019-04-26 08:50:52 +02:00
const signer: any = { privateKey: keys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
const signedBody = await buildSignedActivity(signer, body)
const headers = buildGlobalHeaders(signedBody)
2021-03-08 14:24:11 +01:00
const { statusCode } = await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
expect(statusCode).to.equal(HttpStatusCode.NO_CONTENT_204)
})
2021-02-26 14:42:34 +01:00
it('Should refresh the actor keys', async function () {
this.timeout(20000)
// Wait refresh invalidation
await wait(10000)
// Update keys of server 3 to invalid keys
// Server 1 should refresh the actor and fail
await setKeysOfServer(servers[2], servers[2], invalidKeys.publicKey, invalidKeys.privateKey)
const body = getAnnounceWithoutContext(servers[1])
body.actor = 'http://localhost:' + servers[2].port + '/accounts/peertube'
const signer: any = { privateKey: keys.privateKey, url: 'http://localhost:' + servers[2].port + '/accounts/peertube' }
const signedBody = await buildSignedActivity(signer, body)
const headers = buildGlobalHeaders(signedBody)
2021-03-09 14:01:44 +01:00
try {
await makePOSTAPRequest(url, signedBody, baseHttpSignature(), headers)
expect(true, 'Did not throw').to.be.false
} catch (err) {
expect(err.statusCode).to.equal(HttpStatusCode.FORBIDDEN_403)
}
2021-02-26 14:42:34 +01:00
})
})
after(async function () {
2019-04-26 08:50:52 +02:00
this.timeout(10000)
await cleanupTests(servers)
})
})