changed video rating popover text with link to login page (#3168)

Co-authored-by: Rigel Kent <sendmemail@rigelk.eu>
pull/3239/head
test2a 2020-10-30 10:30:21 +00:00 committed by GitHub
parent dd1e2f2f96
commit 214ff6fa00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions

View File

@ -59,9 +59,13 @@
</div>
<div class="video-actions-rates">
<ng-template #ratePopoverText>
<span [innerHTML]="getRatePopoverText()"></span>
</ng-template>
<div class="video-actions fullWidth justify-content-end">
<button
[ngbPopover]="getRatePopoverText()" [ngClass]="{ 'activated': userRating === 'like' }" (click)="setLike()" (keyup.enter)="setLike()"
[ngbPopover]="getRatePopoverText() && ratePopoverText" [ngClass]="{ 'activated': userRating === 'like' }" (click)="setLike()" (keyup.enter)="setLike()"
class="action-button action-button-like" [attr.aria-pressed]="userRating === 'like'" [attr.aria-label]="tooltipLike"
[ngbTooltip]="tooltipLike"
placement="bottom auto"
@ -71,7 +75,7 @@
</button>
<button
[ngbPopover]="getRatePopoverText()" [ngClass]="{ 'activated': userRating === 'dislike' }" (click)="setDislike()" (keyup.enter)="setDislike()"
[ngbPopover]="getRatePopoverText() && ratePopoverText" [ngClass]="{ 'activated': userRating === 'dislike' }" (click)="setDislike()" (keyup.enter)="setDislike()"
class="action-button action-button-dislike" [attr.aria-pressed]="userRating === 'dislike'" [attr.aria-label]="tooltipDislike"
[ngbTooltip]="tooltipDislike"
placement="bottom auto"

View File

@ -577,10 +577,6 @@ my-video-comments {
.privacy-concerns {
width: 100%;
strong {
display: none;
}
}
}

View File

@ -189,7 +189,7 @@ export class VideoWatchComponent implements OnInit, OnDestroy {
getRatePopoverText () {
if (this.isUserLoggedIn()) return undefined
return $localize`You need to be connected to rate this content.`
return $localize`You need to be <a href="/login">logged in</a> to rate this video.`
}
showMoreDescription () {