From 302fd93c495b1e3a447837d39e50c7b9d6f72272 Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Tue, 19 Mar 2024 14:52:41 +0100 Subject: [PATCH] Disable http metrics by default Can lead to performance issues on prometheus side and peertube side if many different URLs have been called on peertube side (google indexation for example) --- config/default.yaml | 2 +- config/production.yaml.example | 2 +- packages/tests/src/api/server/open-telemetry.ts | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/config/default.yaml b/config/default.yaml index 8e7e5bd59..689ffa74c 100644 --- a/config/default.yaml +++ b/config/default.yaml @@ -277,7 +277,7 @@ open_telemetry: http_request_duration: # You can disable HTTP request duration metric that can have a high tag cardinality - enabled: true + enabled: false # Create a prometheus exporter server on this port so prometheus server can scrape PeerTube metrics prometheus_exporter: diff --git a/config/production.yaml.example b/config/production.yaml.example index f05cd2a74..b5bf8c6a5 100644 --- a/config/production.yaml.example +++ b/config/production.yaml.example @@ -275,7 +275,7 @@ open_telemetry: http_request_duration: # You can disable HTTP request duration metric that can have a high tag cardinality - enabled: true + enabled: false # Create a prometheus exporter server on this port so prometheus server can scrape PeerTube metrics prometheus_exporter: diff --git a/packages/tests/src/api/server/open-telemetry.ts b/packages/tests/src/api/server/open-telemetry.ts index 8ed3801db..87b44d6f1 100644 --- a/packages/tests/src/api/server/open-telemetry.ts +++ b/packages/tests/src/api/server/open-telemetry.ts @@ -41,7 +41,10 @@ describe('Open Telemetry', function () { await server.run({ open_telemetry: { metrics: { - enabled: true + enabled: true, + http_request_duration: { + enabled: true + } } } })