From 4df22f9e47ace5acc5f62587f0ff4d2386ff66b5 Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Tue, 6 Aug 2024 13:41:08 +0200
Subject: [PATCH] Fix hidden delete button for original file

---
 .../app/+admin/overview/videos/video-list.component.html    | 6 +-----
 .../src/app/+admin/overview/videos/video-list.component.ts  | 4 ++--
 client/src/app/shared/shared-main/video/video.model.ts      | 2 +-
 .../video-actions-dropdown.component.ts                     | 2 +-
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/client/src/app/+admin/overview/videos/video-list.component.html b/client/src/app/+admin/overview/videos/video-list.component.html
index 6f326297f..cf1b272cc 100644
--- a/client/src/app/+admin/overview/videos/video-list.component.html
+++ b/client/src/app/+admin/overview/videos/video-list.component.html
@@ -128,11 +128,7 @@
               <li>
                 <a title="Download this file" i18n-title [href]="getDownloadUrl(video, video.videoSource.fileDownloadUrl)">{{ video.videoSource.inputFilename }}</a>: {{ video.videoSource.size | bytes: 1 }}
 
-                <button
-                  *ngIf="canRemoveOneFile(video)" class="border-0 p-0"
-                  i18n-title title="Delete this file"
-                  (click)="removeVideoSourceFile(video)"
-                >
+                <button class="border-0 p-0" i18n-title title="Delete this file" (click)="removeVideoSourceFile(video)">
                   <my-global-icon iconName="delete"></my-global-icon>
                 </button>
               </li>
diff --git a/client/src/app/+admin/overview/videos/video-list.component.ts b/client/src/app/+admin/overview/videos/video-list.component.ts
index 98f56af20..236113ba8 100644
--- a/client/src/app/+admin/overview/videos/video-list.component.ts
+++ b/client/src/app/+admin/overview/videos/video-list.component.ts
@@ -159,13 +159,13 @@ export class VideoListComponent extends RestTable <Video> implements OnInit {
         {
           label: $localize`Delete HLS files`,
           handler: videos => this.removeVideoFiles(videos, 'hls'),
-          isDisplayed: videos => videos.every(v => v.canRemoveFiles(this.authUser)),
+          isDisplayed: videos => videos.every(v => v.canRemoveAllHLSOrWebFiles(this.authUser)),
           iconName: 'delete'
         },
         {
           label: $localize`Delete Web Video files`,
           handler: videos => this.removeVideoFiles(videos, 'web-videos'),
-          isDisplayed: videos => videos.every(v => v.canRemoveFiles(this.authUser)),
+          isDisplayed: videos => videos.every(v => v.canRemoveAllHLSOrWebFiles(this.authUser)),
           iconName: 'delete'
         }
       ],
diff --git a/client/src/app/shared/shared-main/video/video.model.ts b/client/src/app/shared/shared-main/video/video.model.ts
index d408b093d..1063499a7 100644
--- a/client/src/app/shared/shared-main/video/video.model.ts
+++ b/client/src/app/shared/shared-main/video/video.model.ts
@@ -265,7 +265,7 @@ export class Video implements VideoServerModel {
       getAllFiles(this).length > 1
   }
 
-  canRemoveFiles (user: AuthUser) {
+  canRemoveAllHLSOrWebFiles (user: AuthUser) {
     return this.isLocal &&
       user && user.hasRight(UserRight.MANAGE_VIDEO_FILES) &&
       this.state.id !== VideoState.TO_TRANSCODE &&
diff --git a/client/src/app/shared/shared-video-miniature/video-actions-dropdown.component.ts b/client/src/app/shared/shared-video-miniature/video-actions-dropdown.component.ts
index e11adfbb8..eafef8131 100644
--- a/client/src/app/shared/shared-video-miniature/video-actions-dropdown.component.ts
+++ b/client/src/app/shared/shared-video-miniature/video-actions-dropdown.component.ts
@@ -243,7 +243,7 @@ export class VideoActionsDropdownComponent implements OnChanges {
   }
 
   canRemoveVideoFiles () {
-    return this.video.canRemoveFiles(this.user)
+    return this.video.canRemoveAllHLSOrWebFiles(this.user)
   }
 
   canRunTranscoding () {