From 65bb29c6d37a96cd0cae738f8dea07f3a3b5bc3d Mon Sep 17 00:00:00 2001
From: Chocobozzz <me@florianbigard.com>
Date: Fri, 28 Jul 2023 15:20:49 +0200
Subject: [PATCH] Remove unnecesary fixme/todo

---
 client/src/app/core/renderer/html-renderer.service.ts          | 3 +--
 client/src/app/core/renderer/markdown.service.ts               | 3 +--
 client/src/app/core/server/server.service.ts                   | 1 -
 client/src/app/core/users/user.model.ts                        | 1 -
 client/src/app/shared/shared-main/video/video-edit.model.ts    | 1 -
 .../src/app/shared/shared-share-modal/video-share.component.ts | 1 -
 .../app/shared/shared-video-miniature/video-filters.model.ts   | 1 -
 .../shared-video-miniature/video-miniature.component.html      | 1 -
 8 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/client/src/app/core/renderer/html-renderer.service.ts b/client/src/app/core/renderer/html-renderer.service.ts
index d158519f8..7776ccad5 100644
--- a/client/src/app/core/renderer/html-renderer.service.ts
+++ b/client/src/app/core/renderer/html-renderer.service.ts
@@ -36,7 +36,6 @@ export class HtmlRendererService {
   }
 
   private async loadSanitizeHtml () {
-    // FIXME: import('..') returns a struct module, containing a "default" field corresponding to our sanitizeHtml function
-    this.sanitizeHtml = (await import('sanitize-html') as any).default
+    this.sanitizeHtml = (await import('sanitize-html')).default
   }
 }
diff --git a/client/src/app/core/renderer/markdown.service.ts b/client/src/app/core/renderer/markdown.service.ts
index dd23a1b01..ec3b683bb 100644
--- a/client/src/app/core/renderer/markdown.service.ts
+++ b/client/src/app/core/renderer/markdown.service.ts
@@ -146,8 +146,7 @@ export class MarkdownService {
   }
 
   private async createMarkdownIt (config: MarkdownConfig) {
-    // FIXME: import('...') returns a struct module, containing a "default" field
-    const MarkdownItClass: typeof import ('markdown-it') = (await import('markdown-it') as any).default
+    const MarkdownItClass = (await import('markdown-it')).default
 
     const markdownIt = new MarkdownItClass('zero', { linkify: true, breaks: config.breaks, html: config.html })
 
diff --git a/client/src/app/core/server/server.service.ts b/client/src/app/core/server/server.service.ts
index 122c3d37d..41cb4791a 100644
--- a/client/src/app/core/server/server.service.ts
+++ b/client/src/app/core/server/server.service.ts
@@ -195,7 +195,6 @@ export class ServerService {
   }
 
   private loadHTMLConfigLocally () {
-    // FIXME: typings
     const configString = (window as any)['PeerTubeServerConfig']
     if (!configString) {
       throw new Error('Could not find PeerTubeServerConfig in HTML')
diff --git a/client/src/app/core/users/user.model.ts b/client/src/app/core/users/user.model.ts
index 5aa02e472..54b749a4c 100644
--- a/client/src/app/core/users/user.model.ts
+++ b/client/src/app/core/users/user.model.ts
@@ -130,7 +130,6 @@ export class User implements UserServerModel {
 
   patch (obj: UserServerModel) {
     for (const key of objectKeysTyped(obj)) {
-      // FIXME: typings
       (this as any)[key] = obj[key]
     }
 
diff --git a/client/src/app/shared/shared-main/video/video-edit.model.ts b/client/src/app/shared/shared-main/video/video-edit.model.ts
index 1b8b67ee2..9129ab93f 100644
--- a/client/src/app/shared/shared-main/video/video-edit.model.ts
+++ b/client/src/app/shared/shared-main/video/video-edit.model.ts
@@ -70,7 +70,6 @@ export class VideoEdit implements VideoUpdate {
 
   patch (values: { [ id: string ]: any }) {
     objectKeysTyped(values).forEach(key => {
-      // FIXME: typings
       (this as any)[key] = values[key]
     })
 
diff --git a/client/src/app/shared/shared-share-modal/video-share.component.ts b/client/src/app/shared/shared-share-modal/video-share.component.ts
index da4f2a4b4..b09222c3e 100644
--- a/client/src/app/shared/shared-share-modal/video-share.component.ts
+++ b/client/src/app/shared/shared-share-modal/video-share.component.ts
@@ -106,7 +106,6 @@ export class VideoShareComponent {
       includeVideoInPlaylist: false
     }, {
       set: (target, prop, value) => {
-        // FIXME: typings
         (target as any)[prop] = value
 
         if (prop === 'embedP2P') {
diff --git a/client/src/app/shared/shared-video-miniature/video-filters.model.ts b/client/src/app/shared/shared-video-miniature/video-filters.model.ts
index 4db73b25a..f57a45eb1 100644
--- a/client/src/app/shared/shared-video-miniature/video-filters.model.ts
+++ b/client/src/app/shared/shared-video-miniature/video-filters.model.ts
@@ -83,7 +83,6 @@ export class VideoFilters {
     for (const [ key, value ] of this.defaultValues) {
       if (specificKey && specificKey !== key) continue
 
-      // FIXME: typings
       (this as any)[key] = value
     }
 
diff --git a/client/src/app/shared/shared-video-miniature/video-miniature.component.html b/client/src/app/shared/shared-video-miniature/video-miniature.component.html
index 9e0a4f79b..5c3140b58 100644
--- a/client/src/app/shared/shared-video-miniature/video-miniature.component.html
+++ b/client/src/app/shared/shared-video-miniature/video-miniature.component.html
@@ -71,7 +71,6 @@
     </div>
 
     <div class="video-actions">
-      <!-- FIXME: remove bottom placement when overflow is fixed in bootstrap dropdown: https://github.com/ng-bootstrap/ng-bootstrap/issues/3495 -->
       <my-video-actions-dropdown
         *ngIf="showActions" [video]="video" [displayOptions]="videoActionsDisplayOptions" placement="bottom-left bottom-right left auto"
         (videoRemoved)="onVideoRemoved()" (videoBlocked)="onVideoBlocked()" (videoUnblocked)="onVideoUnblocked()" (videoAccountMuted)="onVideoAccountMuted()"