diff --git a/server/models/video/sql/comment/video-comment-list-query-builder.ts b/server/models/video/sql/comment/video-comment-list-query-builder.ts index f3f6910e1..49b41b6d8 100644 --- a/server/models/video/sql/comment/video-comment-list-query-builder.ts +++ b/server/models/video/sql/comment/video-comment-list-query-builder.ts @@ -87,8 +87,7 @@ export class VideoCommentListQueryBuilder extends AbstractRunQuery { this.query = `${this.select} ` + `FROM (${this.innerQuery}) AS "VideoCommentModel" ` + `${this.joins} ` + - `${this.getOrder()} ` + - `${this.getLimit()}` + `${this.getOrder()}` } private buildInnerListQuery () { @@ -375,14 +374,6 @@ export class VideoCommentListQueryBuilder extends AbstractRunQuery { return 'ORDER BY ' + orders.map(o => `"${o[0]}" ${o[1]}`).join(', ') } - private getLimit () { - if (!this.options.count) return '' - - this.replacements.limit = this.options.count - - return `LIMIT :limit ` - } - private getInnerLimit () { if (!this.options.count) return '' diff --git a/server/models/video/sql/comment/video-comment-table-attributes.ts b/server/models/video/sql/comment/video-comment-table-attributes.ts index 10e635e41..87f8750c1 100644 --- a/server/models/video/sql/comment/video-comment-table-attributes.ts +++ b/server/models/video/sql/comment/video-comment-table-attributes.ts @@ -38,6 +38,6 @@ export class VideoCommentTableAttributes { @Memoize() getAvatarAttributes () { - return ActorImageModel.getSQLAttributes('Account->Actor->Avatars', 'Account.Actor.Avatars.id').join(', ') + return ActorImageModel.getSQLAttributes('Account->Actor->Avatars', 'Account.Actor.Avatars.').join(', ') } } diff --git a/server/tests/api/videos/video-comments.ts b/server/tests/api/videos/video-comments.ts index 5485b72ec..e077cbf73 100644 --- a/server/tests/api/videos/video-comments.ts +++ b/server/tests/api/videos/video-comments.ts @@ -38,6 +38,8 @@ describe('Test video comments', function () { await setDefaultAccountAvatar(server) userAccessTokenServer1 = await server.users.generateUserAndToken('user1') + await setDefaultChannelAvatar(server, 'user1_channel') + await setDefaultAccountAvatar(server, userAccessTokenServer1) command = server.comments }) @@ -240,9 +242,26 @@ describe('Test video comments', function () { describe('All instance comments', function () { it('Should list instance comments as admin', async function () { - const { data } = await command.listForAdmin({ start: 0, count: 1 }) + { + const { data, total } = await command.listForAdmin({ start: 0, count: 1 }) - expect(data[0].text).to.equal('my second answer to thread 4') + expect(total).to.equal(7) + expect(data).to.have.lengthOf(1) + expect(data[0].text).to.equal('my second answer to thread 4') + expect(data[0].account.name).to.equal('root') + expect(data[0].account.displayName).to.equal('root') + expect(data[0].account.avatars).to.have.lengthOf(2) + } + + { + const { data, total } = await command.listForAdmin({ start: 1, count: 2 }) + + expect(total).to.equal(7) + expect(data).to.have.lengthOf(2) + + expect(data[0].account.avatars).to.have.lengthOf(2) + expect(data[1].account.avatars).to.have.lengthOf(2) + } }) it('Should filter instance comments by isLocal', async function () {