Optimize custom markup angular tags

We can use the on push strategy with these components
pull/5548/head
Chocobozzz 2023-01-13 09:39:35 +01:00
parent 6a056bbe4d
commit bc48e33b80
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
5 changed files with 15 additions and 10 deletions

View File

@ -1,4 +1,4 @@
import { Component, Input } from '@angular/core'
import { ChangeDetectionStrategy, Component, Input } from '@angular/core'
import { VideoChannel } from '../../shared-main'
import { CustomMarkupComponent } from './shared'
@ -9,7 +9,8 @@ import { CustomMarkupComponent } from './shared'
@Component({
selector: 'my-button-markup',
templateUrl: 'button-markup.component.html',
styleUrls: [ 'button-markup.component.scss' ]
styleUrls: [ 'button-markup.component.scss' ],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class ButtonMarkupComponent implements CustomMarkupComponent {
@Input() theme: 'primary' | 'secondary'

View File

@ -1,6 +1,6 @@
import { from } from 'rxjs'
import { finalize, map, switchMap, tap } from 'rxjs/operators'
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { MarkdownService, Notifier, UserService } from '@app/core'
import { FindInBulkService } from '@app/shared/shared-search'
import { VideoSortField } from '@shared/models'
@ -14,7 +14,8 @@ import { CustomMarkupComponent } from './shared'
@Component({
selector: 'my-channel-miniature-markup',
templateUrl: 'channel-miniature-markup.component.html',
styleUrls: [ 'channel-miniature-markup.component.scss' ]
styleUrls: [ 'channel-miniature-markup.component.scss' ],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class ChannelMiniatureMarkupComponent implements CustomMarkupComponent, OnInit {
@Input() name: string

View File

@ -1,5 +1,5 @@
import { finalize } from 'rxjs/operators'
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { Notifier } from '@app/core'
import { FindInBulkService } from '@app/shared/shared-search'
import { MiniatureDisplayOptions } from '../../shared-video-miniature'
@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared'
@Component({
selector: 'my-playlist-miniature-markup',
templateUrl: 'playlist-miniature-markup.component.html',
styleUrls: [ 'playlist-miniature-markup.component.scss' ]
styleUrls: [ 'playlist-miniature-markup.component.scss' ],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class PlaylistMiniatureMarkupComponent implements CustomMarkupComponent, OnInit {
@Input() uuid: string

View File

@ -1,5 +1,5 @@
import { finalize } from 'rxjs/operators'
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { AuthService, Notifier } from '@app/core'
import { FindInBulkService } from '@app/shared/shared-search'
import { Video } from '../../shared-main'
@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared'
@Component({
selector: 'my-video-miniature-markup',
templateUrl: 'video-miniature-markup.component.html',
styleUrls: [ 'video-miniature-markup.component.scss' ]
styleUrls: [ 'video-miniature-markup.component.scss' ],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class VideoMiniatureMarkupComponent implements CustomMarkupComponent, OnInit {
@Input() uuid: string

View File

@ -1,5 +1,5 @@
import { finalize } from 'rxjs/operators'
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { ChangeDetectionStrategy, Component, EventEmitter, Input, OnInit, Output } from '@angular/core'
import { AuthService, Notifier } from '@app/core'
import { VideoSortField } from '@shared/models'
import { Video, VideoService } from '../../shared-main'
@ -13,7 +13,8 @@ import { CustomMarkupComponent } from './shared'
@Component({
selector: 'my-videos-list-markup',
templateUrl: 'videos-list-markup.component.html',
styleUrls: [ 'videos-list-markup.component.scss' ]
styleUrls: [ 'videos-list-markup.component.scss' ],
changeDetection: ChangeDetectionStrategy.OnPush
})
export class VideosListMarkupComponent implements CustomMarkupComponent, OnInit {
@Input() sort: string