Better handling video resizing

pull/364/head
Chocobozzz 2018-03-19 17:16:34 +01:00
parent 6194c1b419
commit caae7a0671
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
2 changed files with 16 additions and 10 deletions

View File

@ -3,6 +3,7 @@ import { ActivatedRoute, Router } from '@angular/router'
import { isInMobileView } from '@app/shared/misc/utils' import { isInMobileView } from '@app/shared/misc/utils'
import { InfiniteScrollerDirective } from '@app/shared/video/infinite-scroller.directive' import { InfiniteScrollerDirective } from '@app/shared/video/infinite-scroller.directive'
import { NotificationsService } from 'angular2-notifications' import { NotificationsService } from 'angular2-notifications'
import 'rxjs/add/operator/debounceTime'
import { Observable } from 'rxjs/Observable' import { Observable } from 'rxjs/Observable'
import { fromEvent } from 'rxjs/observable/fromEvent' import { fromEvent } from 'rxjs/observable/fromEvent'
import { AuthService } from '../../core/auth' import { AuthService } from '../../core/auth'
@ -25,9 +26,9 @@ export abstract class AbstractVideoList implements OnInit {
defaultSort: SortField = '-createdAt' defaultSort: SortField = '-createdAt'
loadOnInit = true loadOnInit = true
pageHeight: number pageHeight: number
videoWidth = 215 videoWidth: number
videoHeight = 230 videoHeight: number
videoPages: Video[][] videoPages: Video[][] = []
protected abstract notificationsService: NotificationsService protected abstract notificationsService: NotificationsService
protected abstract authService: AuthService protected abstract authService: AuthService
@ -174,23 +175,27 @@ export abstract class AbstractVideoList implements OnInit {
this.videoWidth = -1 this.videoWidth = -1
this.pageHeight = this.pagination.itemsPerPage * this.videoHeight this.pageHeight = this.pagination.itemsPerPage * this.videoHeight
} else { } else {
this.videoWidth = 215
this.videoHeight = 230
const videosWidth = this.videosElement.nativeElement.offsetWidth const videosWidth = this.videosElement.nativeElement.offsetWidth
this.pagination.itemsPerPage = Math.floor(videosWidth / this.videoWidth) * AbstractVideoList.LINES_PER_PAGE this.pagination.itemsPerPage = Math.floor(videosWidth / this.videoWidth) * AbstractVideoList.LINES_PER_PAGE
this.pageHeight = this.videoHeight * AbstractVideoList.LINES_PER_PAGE this.pageHeight = this.videoHeight * AbstractVideoList.LINES_PER_PAGE
} }
// Rebuild pages because maybe we modified the number of items per page // Rebuild pages because maybe we modified the number of items per page
let videos: Video[] = [] const videos = [].concat(...this.videoPages)
Object.values(this.loadedPages)
.forEach(videosPage => videos = videos.concat(videosPage))
this.loadedPages = {} this.loadedPages = {}
for (let i = 1; (i * this.pagination.itemsPerPage) <= videos.length; i++) { let i = 1
this.loadedPages[i] = videos.slice((i - 1) * this.pagination.itemsPerPage, this.pagination.itemsPerPage * i) // Don't include the last page if it not complete
while (videos.length >= this.pagination.itemsPerPage && i < 10000) { // 10000 -> Hard limit in case of infinite loop
this.loadedPages[i] = videos.splice(0, this.pagination.itemsPerPage)
i++
} }
this.buildVideoPages() this.buildVideoPages()
console.log('Re calculated pages after a resize!') console.log('Rebuilt pages with %s elements per page.', this.pagination.itemsPerPage)
} }
} }

View File

@ -7,6 +7,7 @@ import { NotificationsService } from 'angular2-notifications'
import { Subscription } from 'rxjs/Subscription' import { Subscription } from 'rxjs/Subscription'
import * as videojs from 'video.js' import * as videojs from 'video.js'
import 'videojs-hotkeys' import 'videojs-hotkeys'
import * as WebTorrent from 'webtorrent'
import { UserVideoRateType, VideoRateType } from '../../../../../shared' import { UserVideoRateType, VideoRateType } from '../../../../../shared'
import '../../../assets/player/peertube-videojs-plugin' import '../../../assets/player/peertube-videojs-plugin'
import { AuthService, ConfirmService } from '../../core' import { AuthService, ConfirmService } from '../../core'
@ -74,7 +75,7 @@ export class VideoWatchComponent implements OnInit, OnDestroy {
} }
ngOnInit () { ngOnInit () {
if (localStorage.getItem(VideoWatchComponent.LOCAL_STORAGE_PRIVACY_CONCERN_KEY) === 'true') { if (WebTorrent.WEBRTC_SUPPORT === false || localStorage.getItem(VideoWatchComponent.LOCAL_STORAGE_PRIVACY_CONCERN_KEY) === 'true') {
this.hasAlreadyAcceptedPrivacyConcern = true this.hasAlreadyAcceptedPrivacyConcern = true
} }