OpenCloud
/
PeerTube
mirror of https://github.com/Chocobozzz/PeerTube
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix "update your settings" keyboard navigation

pull/6449/head
Chocobozzz 2024-06-11 09:25:30 +02:00
parent 2d9e4188b5
commit cc0a39c2c4
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
client/src/app/shared/shared-video-miniature/video-filters-header.component.html
View File

@ -1,9 +1,8 @@
<ng-template #updateSettings let-fragment> <ng-template #updateSettings let-fragment>
<div class="label-description muted" i18n> <div class="label-description muted" i18n>
Update Update
<a routerLink="/my-account/settings" [fragment]="fragment">
<button class="button-unstyle" (click)="onAccountSettingsClick($event)">your settings</button> <a routerLink="/my-account/settings" [fragment]="fragment" (click)="onAccountSettingsClick($event)">your settings</a
</a
></div> ></div>
</ng-template> </ng-template>
@ -17,8 +16,11 @@
[attr.aria-expanded]="!areFiltersCollapsed" aria-controls="collapseBasic" [attr.aria-expanded]="!areFiltersCollapsed" aria-controls="collapseBasic"
[ngClass]="{ active: !areFiltersCollapsed }" [ngClass]="{ active: !areFiltersCollapsed }"
> >
<ng-container i18n *ngIf="areFiltersCollapsed">More filters</ng-container> @if (areFiltersCollapsed) {
<ng-container i18n *ngIf="!areFiltersCollapsed">Hide filters</ng-container> <ng-container i18n>More filters</ng-container>
} @else {
<ng-container i18n>Hide filters</ng-container>
}
<my-global-icon iconName="chevrons-up"></my-global-icon> <my-global-icon iconName="chevrons-up"></my-global-icon>
</button> </button>
@ -54,9 +56,15 @@
<ng-option i18n value="-originallyPublishedAt">Sort by <strong>"Original Publication Date"</strong></ng-option> <ng-option i18n value="-originallyPublishedAt">Sort by <strong>"Original Publication Date"</strong></ng-option>
<ng-option i18n value="name">Sort by <strong>"Name"</strong></ng-option> <ng-option i18n value="name">Sort by <strong>"Name"</strong></ng-option>
<ng-option i18n *ngIf="isTrendingSortEnabled('most-viewed')" value="-trending">Sort by <strong>"Recent Views"</strong></ng-option>
<ng-option i18n *ngIf="isTrendingSortEnabled('hot')" value="-hot">Sort by <strong>"Hot"</strong></ng-option> @if (isTrendingSortEnabled('most-viewed')) {
<ng-option i18n *ngIf="isTrendingSortEnabled('most-liked')" value="-likes">Sort by <strong>"Likes"</strong></ng-option> <ng-option i18n value="-trending">Sort by <strong>"Recent Views"</strong></ng-option>
} @else if (isTrendingSortEnabled('hot')) {
<ng-option i18n value="-hot">Sort by <strong>"Hot"</strong></ng-option>
} @else if (isTrendingSortEnabled('most-liked')) {
<ng-option i18n value="-likes">Sort by <strong>"Likes"</strong></ng-option>
}
<ng-option i18n value="-views">Sort by <strong>"Global Views"</strong></ng-option> <ng-option i18n value="-views">Sort by <strong>"Global Views"</strong></ng-option>
</ng-select> </ng-select>

1
client/src/assets/player/shared/settings/menu-focus-fixed.ts
View File

@ -16,6 +16,7 @@ class MenuFocusFixed extends Menu {
return return
} }
// FIXME: super misses handleKeyDown
// eslint-disable-next-line @typescript-eslint/ban-ts-comment // eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-expect-error // @ts-expect-error
return super.handleKeyDown(event) return super.handleKeyDown(event)