Merge pull request #3103 from matrix-org/t3chguy/edit_skip_if_no_edit

If oldContent matches newContent, skip sending the edit
pull/21833/head
Michael Telatynski 2019-07-06 08:52:58 +01:00 committed by GitHub
commit 000f7e8007
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 0 deletions

View File

@ -187,6 +187,17 @@ export default class MessageEditor extends React.Component {
contentBody.format = newContent.format;
contentBody.formatted_body = ` * ${newContent.formatted_body}`;
}
// if nothing has changed then bail
const oldContent = this.props.editState.getEvent().getContent();
if (!this._hasModifications ||
(oldContent["msgtype"] === newContent["msgtype"] && oldContent["body"] === newContent["body"] &&
oldContent["format"] === newContent["format"] &&
oldContent["formatted_body"] === newContent["formatted_body"])) {
this._cancelEdit();
return;
}
const content = Object.assign({
"m.new_content": newContent,
"m.relates_to": {