diff --git a/src/components/structures/InteractiveAuth.tsx b/src/components/structures/InteractiveAuth.tsx
index b42e65d57f..4342355c74 100644
--- a/src/components/structures/InteractiveAuth.tsx
+++ b/src/components/structures/InteractiveAuth.tsx
@@ -31,6 +31,17 @@ import Spinner from "../views/elements/Spinner";
export const ERROR_USER_CANCELLED = new Error("User cancelled auth session");
+type InteractiveAuthCallbackSuccess = (
+ success: true,
+ response: IAuthData,
+ extra?: { emailSid?: string, clientSecret?: string }
+) => void;
+type InteractiveAuthCallbackFailure = (
+ success: false,
+ response: IAuthData | Error,
+) => void;
+export type InteractiveAuthCallback = InteractiveAuthCallbackSuccess & InteractiveAuthCallbackFailure;
+
interface IProps {
// matrix client to use for UI auth requests
matrixClient: MatrixClient;
@@ -66,11 +77,7 @@ interface IProps {
// the auth session.
// * clientSecret {string} The client secret used in auth
// sessions with the ID server.
- onAuthFinished(
- status: boolean,
- result: IAuthData | Error,
- extra?: { emailSid?: string, clientSecret?: string },
- ): void;
+ onAuthFinished: InteractiveAuthCallback;
// As js-sdk interactive-auth
requestEmailToken?(email: string, secret: string, attempt: number, session: string): Promise<{ sid: string }>;
// Called when the stage changes, or the stage's phase changes. First
diff --git a/src/components/structures/auth/Registration.tsx b/src/components/structures/auth/Registration.tsx
index 7515a4f0d9..d349205ab9 100644
--- a/src/components/structures/auth/Registration.tsx
+++ b/src/components/structures/auth/Registration.tsx
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/
-import { createClient } from 'matrix-js-sdk/src/matrix';
+import { AuthType, createClient } from 'matrix-js-sdk/src/matrix';
import React, { Fragment, ReactNode } from 'react';
import { MatrixClient } from "matrix-js-sdk/src/client";
import classNames from "classnames";
@@ -34,10 +34,17 @@ import RegistrationForm from '../../views/auth/RegistrationForm';
import AccessibleButton from '../../views/elements/AccessibleButton';
import AuthBody from "../../views/auth/AuthBody";
import AuthHeader from "../../views/auth/AuthHeader";
-import InteractiveAuth from "../InteractiveAuth";
+import InteractiveAuth, { InteractiveAuthCallback } from "../InteractiveAuth";
import Spinner from "../../views/elements/Spinner";
import { AuthHeaderDisplay } from './header/AuthHeaderDisplay';
import { AuthHeaderProvider } from './header/AuthHeaderProvider';
+import SettingsStore from '../../../settings/SettingsStore';
+
+const debuglog = (...args: any[]) => {
+ if (SettingsStore.getValue("debug_registration")) {
+ logger.log.call(console, "Registration debuglog:", ...args);
+ }
+};
interface IProps {
serverConfig: ValidatedServerConfig;
@@ -287,9 +294,10 @@ export default class Registration extends React.Component {
);
};
- private onUIAuthFinished = async (success: boolean, response: any) => {
+ private onUIAuthFinished: InteractiveAuthCallback = async (success, response) => {
+ debuglog("Registration: ui authentication finished: ", { success, response });
if (!success) {
- let errorText = response.message || response.toString();
+ let errorText: ReactNode = response.message || response.toString();
// can we give a better error message?
if (response.errcode === 'M_RESOURCE_LIMIT_EXCEEDED') {
const errorTop = messageForResourceLimitError(
@@ -312,10 +320,10 @@ export default class Registration extends React.Component {
{ errorTop }
{ errorDetail }
;
- } else if (response.required_stages && response.required_stages.indexOf('m.login.msisdn') > -1) {
+ } else if (response.required_stages && response.required_stages.includes(AuthType.Msisdn)) {
let msisdnAvailable = false;
for (const flow of response.available_flows) {
- msisdnAvailable = msisdnAvailable || flow.stages.includes('m.login.msisdn');
+ msisdnAvailable = msisdnAvailable || flow.stages.includes(AuthType.Msisdn);
}
if (!msisdnAvailable) {
errorText = _t('This server does not support authentication with a phone number.');
@@ -351,14 +359,31 @@ export default class Registration extends React.Component {
// starting the registration process. This isn't perfect since it's possible
// the user had a separate guest session they didn't actually mean to replace.
const [sessionOwner, sessionIsGuest] = await Lifecycle.getStoredSessionOwner();
- if (sessionOwner && !sessionIsGuest && sessionOwner !== response.userId) {
+ if (sessionOwner && !sessionIsGuest && sessionOwner !== response.user_id) {
logger.log(
- `Found a session for ${sessionOwner} but ${response.userId} has just registered.`,
+ `Found a session for ${sessionOwner} but ${response.user_id} has just registered.`,
);
newState.differentLoggedInUserId = sessionOwner;
}
- if (response.access_token) {
+ // if we don't have an email at all, only one client can be involved in this flow, and we can directly log in.
+ //
+ // if we've got an email, it needs to be verified. in that case, two clients can be involved in this flow, the
+ // original client starting the process and the client that submitted the verification token. After the token
+ // has been submitted, it can not be used again.
+ //
+ // we can distinguish them based on whether the client has form values saved (if so, it's the one that started
+ // the registration), or whether it doesn't have any form values saved (in which case it's the client that
+ // verified the email address)
+ //
+ // as the client that started registration may be gone by the time we've verified the email, and only the client
+ // that verified the email is guaranteed to exist, we'll always do the login in that client.
+ const hasEmail = Boolean(this.state.formVals.email);
+ const hasAccessToken = Boolean(response.access_token);
+ debuglog("Registration: ui auth finished:", { hasEmail, hasAccessToken });
+ if (!hasEmail && hasAccessToken) {
+ // we'll only try logging in if we either have no email to verify at all or we're the client that verified
+ // the email, not the client that started the registration flow
await this.props.onLoggedIn({
userId: response.user_id,
deviceId: response.device_id,
@@ -416,26 +441,17 @@ export default class Registration extends React.Component {
};
private makeRegisterRequest = auth => {
- // We inhibit login if we're trying to register with an email address: this
- // avoids a lot of complex race conditions that can occur if we try to log
- // the user in one one or both of the tabs they might end up with after
- // clicking the email link.
- let inhibitLogin = Boolean(this.state.formVals.email);
-
- // Only send inhibitLogin if we're sending username / pw params
- // (Since we need to send no params at all to use the ones saved in the
- // session).
- if (!this.state.formVals.password) inhibitLogin = null;
-
const registerParams = {
username: this.state.formVals.username,
password: this.state.formVals.password,
initial_device_display_name: this.props.defaultDeviceDisplayName,
auth: undefined,
+ // we still want to avoid the race conditions involved with multiple clients handling registration, but
+ // we'll handle these after we've received the access_token in onUIAuthFinished
inhibit_login: undefined,
};
if (auth) registerParams.auth = auth;
- if (inhibitLogin !== undefined && inhibitLogin !== null) registerParams.inhibit_login = inhibitLogin;
+ debuglog("Registration: sending registration request:", auth);
return this.state.matrixClient.registerRequest(registerParams);
};
@@ -597,22 +613,22 @@ export default class Registration extends React.Component {
{ _t("Continue with previous account") }
;
- } else if (this.state.formVals.password) {
- // We're the client that started the registration
+ } else {
+ // regardless of whether we're the client that started the registration or not, we should
+ // try our credentials anyway
regDoneText = { _t(
"Log in to your new account.", {},
{
- a: (sub) => { sub },
- },
- ) }
;
- } else {
- // We're not the original client: the user probably got to us by clicking the
- // email validation link. We can't offer a 'go straight to your account' link
- // as we don't have the original creds.
- regDoneText = { _t(
- "You can now close this window or log in to your new account.", {},
- {
- a: (sub) => { sub },
+ a: (sub) => {
+ const sessionLoaded = await this.onLoginClickWithCheck(event);
+ if (sessionLoaded) {
+ dis.dispatch({ action: "view_home_page" });
+ }
+ }}
+ >{ sub },
},
) }
;
}
diff --git a/src/components/views/dialogs/DeactivateAccountDialog.tsx b/src/components/views/dialogs/DeactivateAccountDialog.tsx
index dbdc3b3639..55251025fb 100644
--- a/src/components/views/dialogs/DeactivateAccountDialog.tsx
+++ b/src/components/views/dialogs/DeactivateAccountDialog.tsx
@@ -22,7 +22,7 @@ import { logger } from "matrix-js-sdk/src/logger";
import Analytics from '../../../Analytics';
import { MatrixClientPeg } from '../../../MatrixClientPeg';
import { _t } from '../../../languageHandler';
-import InteractiveAuth, { ERROR_USER_CANCELLED } from "../../structures/InteractiveAuth";
+import InteractiveAuth, { ERROR_USER_CANCELLED, InteractiveAuthCallback } from "../../structures/InteractiveAuth";
import { DEFAULT_PHASE, PasswordAuthEntry, SSOAuthEntry } from "../auth/InteractiveAuthEntryComponents";
import StyledCheckbox from "../elements/StyledCheckbox";
import BaseDialog from "./BaseDialog";
@@ -104,7 +104,7 @@ export default class DeactivateAccountDialog extends React.Component {
+ private onUIAuthFinished: InteractiveAuthCallback = (success, result) => {
if (success) return; // great! makeRequest() will be called too.
if (result === ERROR_USER_CANCELLED) {
diff --git a/src/components/views/dialogs/InteractiveAuthDialog.tsx b/src/components/views/dialogs/InteractiveAuthDialog.tsx
index 46bad5fd0e..6f10790811 100644
--- a/src/components/views/dialogs/InteractiveAuthDialog.tsx
+++ b/src/components/views/dialogs/InteractiveAuthDialog.tsx
@@ -22,7 +22,7 @@ import { IAuthData } from "matrix-js-sdk/src/interactive-auth";
import { _t } from '../../../languageHandler';
import AccessibleButton from '../elements/AccessibleButton';
-import InteractiveAuth, { ERROR_USER_CANCELLED } from "../../structures/InteractiveAuth";
+import InteractiveAuth, { ERROR_USER_CANCELLED, InteractiveAuthCallback } from "../../structures/InteractiveAuth";
import { SSOAuthEntry } from "../auth/InteractiveAuthEntryComponents";
import BaseDialog from "./BaseDialog";
import { IDialogProps } from "./IDialogProps";
@@ -117,7 +117,7 @@ export default class InteractiveAuthDialog extends React.Component {
+ private onAuthFinished: InteractiveAuthCallback = (success, result): void => {
if (success) {
this.props.onFinished(true, result);
} else {
diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
index 9b82b120c3..87dbb0fa91 100644
--- a/src/i18n/strings/en_EN.json
+++ b/src/i18n/strings/en_EN.json
@@ -3232,7 +3232,6 @@
"Your new account (%(newAccountId)s) is registered, but you're already logged into a different account (%(loggedInUserId)s).": "Your new account (%(newAccountId)s) is registered, but you're already logged into a different account (%(loggedInUserId)s).",
"Continue with previous account": "Continue with previous account",
"Log in to your new account.": "Log in to your new account.",
- "You can now close this window or log in to your new account.": "You can now close this window or log in to your new account.",
"Registration Successful": "Registration Successful",
"Create account": "Create account",
"Host account on": "Host account on",
diff --git a/src/settings/Settings.tsx b/src/settings/Settings.tsx
index 0df3d87481..e3d5b0afce 100644
--- a/src/settings/Settings.tsx
+++ b/src/settings/Settings.tsx
@@ -929,6 +929,10 @@ export const SETTINGS: {[setting: string]: ISetting} = {
supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS,
default: false,
},
+ "debug_registration": {
+ supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS,
+ default: false,
+ },
"audioInputMuted": {
supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS,
default: false,