Merge branch 'poljar/delete-events' into develop

pull/21833/head
Damir Jelić 2020-03-17 10:15:05 +01:00
commit 029624cbec
2 changed files with 34 additions and 1 deletions

View File

@ -123,6 +123,10 @@ export default class BaseEventIndexManager {
throw new Error("Unimplemented");
}
async deleteEvent(eventId: string): Promise<boolean> {
throw new Error("Unimplemented");
}
/**
* Check if our event index is empty.
*/

View File

@ -61,6 +61,7 @@ export default class EventIndex extends EventEmitter {
client.on('Room.timeline', this.onRoomTimeline);
client.on('Event.decrypted', this.onEventDecrypted);
client.on('Room.timelineReset', this.onTimelineReset);
client.on('Room.redaction', this.onRedaction);
}
/**
@ -74,6 +75,7 @@ export default class EventIndex extends EventEmitter {
client.removeListener('Room.timeline', this.onRoomTimeline);
client.removeListener('Event.decrypted', this.onEventDecrypted);
client.removeListener('Room.timelineReset', this.onTimelineReset);
client.removeListener('Room.redaction', this.onRedaction);
}
/**
@ -210,6 +212,23 @@ export default class EventIndex extends EventEmitter {
await this.addLiveEventToIndex(ev);
}
/*
* The Room.redaction listener.
*
* Removes a redacted event from our event index.
*/
onRedaction = async (ev, room) => {
// We only index encrypted rooms locally.
if (!MatrixClientPeg.get().isRoomEncrypted(room.roomId)) return;
const indexManager = PlatformPeg.get().getEventIndexingManager();
try {
await indexManager.deleteEvent(ev.getAssociatedId());
} catch (e) {
console.log("EventIndex: Error deleting event from index", e);
}
}
/*
* The Room.timelineReset listener.
*
@ -446,12 +465,17 @@ export default class EventIndex extends EventEmitter {
// Let us wait for all the events to get decrypted.
await Promise.all(decryptionPromises);
// TODO if there are no events at this point we're missing a lot
// decryption keys, do we want to retry this checkpoint at a later
// stage?
const filteredEvents = matrixEvents.filter(this.isValidEvent);
// Collect the redaction events so we can delete the redacted events
// from the index.
const redactionEvents = matrixEvents.filter((ev) => {
return ev.getType() === "m.room.redaction";
});
// Let us convert the events back into a format that EventIndex can
// consume.
const events = filteredEvents.map((ev) => {
@ -483,6 +507,11 @@ export default class EventIndex extends EventEmitter {
);
try {
for (let i = 0; i < redactionEvents.length; i++) {
const ev = redactionEvents[i];
await indexManager.deleteEvent(ev.getAssociatedId());
}
const eventsAlreadyAdded = await indexManager.addHistoricEvents(
events, newCheckpoint, checkpoint);
// If all events were already indexed we assume that we catched