OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #60 from matrix-org/bwindels/somefixes 

Attempt at making E2E tests on CI less flaky
pull/21833/head
Bruno Windels 2019-09-16 11:22:02 +00:00 committed by GitHub
parent 7be47b2775 87be5fb938
commit 04f7514080
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/session.js
View File

@ -108,6 +108,9 @@ module.exports = class RiotSession {
async replaceInputText(input, text) { async replaceInputText(input, text) {
// click 3 times to select all text // click 3 times to select all text
await input.click({clickCount: 3}); await input.click({clickCount: 3});
// waiting here solves not having selected all the text by the 3x click above,
// presumably because of the Field label animation.
await this.delay(300);
// then remove it with backspace // then remove it with backspace
await input.press('Backspace'); await input.press('Backspace');
// and type the new text // and type the new text

4
src/usecases/timeline.js
View File

@ -20,14 +20,14 @@ module.exports.scrollToTimelineTop = async function(session) {
session.log.step(`scrolls to the top of the timeline`); session.log.step(`scrolls to the top of the timeline`);
await session.page.evaluate(() => { await session.page.evaluate(() => {
return Promise.resolve().then(async () => { return Promise.resolve().then(async () => {
const timelineScrollView = document.querySelector(".mx_RoomView_timeline .mx_ScrollPanel");
let timedOut = false; let timedOut = false;
let timeoutHandle = null; let timeoutHandle = null;
// set scrollTop to 0 in a loop and check every 50ms // set scrollTop to 0 in a loop and check every 50ms
// if content became available (scrollTop not being 0 anymore), // if content became available (scrollTop not being 0 anymore),
// assume everything is loaded after 3s // assume everything is loaded after 3s
do { do {
if (timelineScrollView.scrollTop !== 0) { const timelineScrollView = document.querySelector(".mx_RoomView_timeline .mx_ScrollPanel");
if (timelineScrollView && timelineScrollView.scrollTop !== 0) {
if (timeoutHandle) { if (timeoutHandle) {
clearTimeout(timeoutHandle); clearTimeout(timeoutHandle);
} }