From 0db0d4b09df5a868abb94638f4f060e000ec37c2 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 8 Mar 2023 10:04:07 +0000 Subject: [PATCH] Remove unused code (#10322) --- .../settings/UiFeatureSettingWrapper.tsx | 30 ---------- .../settings/UiFeatureSettingWrapper-test.tsx | 56 ------------------- .../UiFeatureSettingWrapper-test.tsx.snap | 13 ----- 3 files changed, 99 deletions(-) delete mode 100644 src/components/views/settings/UiFeatureSettingWrapper.tsx delete mode 100644 test/components/views/settings/UiFeatureSettingWrapper-test.tsx delete mode 100644 test/components/views/settings/__snapshots__/UiFeatureSettingWrapper-test.tsx.snap diff --git a/src/components/views/settings/UiFeatureSettingWrapper.tsx b/src/components/views/settings/UiFeatureSettingWrapper.tsx deleted file mode 100644 index 3bf243a681..0000000000 --- a/src/components/views/settings/UiFeatureSettingWrapper.tsx +++ /dev/null @@ -1,30 +0,0 @@ -/* -Copyright 2022 The Matrix.org Foundation C.I.C. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -import React from "react"; - -import SettingsStore from "../../../settings/SettingsStore"; -import { UIFeature } from "../../../settings/UIFeature"; - -interface IProps { - uiFeature: UIFeature; -} -const UiFeatureSettingWrapper: React.FC = ({ children, uiFeature }) => { - const settingValue = SettingsStore.getValue(uiFeature); - return settingValue && children ? <>{children} : null; -}; - -export default UiFeatureSettingWrapper; diff --git a/test/components/views/settings/UiFeatureSettingWrapper-test.tsx b/test/components/views/settings/UiFeatureSettingWrapper-test.tsx deleted file mode 100644 index aeba1273de..0000000000 --- a/test/components/views/settings/UiFeatureSettingWrapper-test.tsx +++ /dev/null @@ -1,56 +0,0 @@ -/* -Copyright 2022 The Matrix.org Foundation C.I.C. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -import React from "react"; -import { render } from "@testing-library/react"; - -import SettingsStore from "../../../../src/settings/SettingsStore"; -import UiFeatureSettingWrapper from "../../../../src/components/views/settings/UiFeatureSettingWrapper"; -import { UIFeature } from "../../../../src/settings/UIFeature"; - -jest.mock("../../../../src/settings/SettingsStore"); - -describe("", () => { - const defaultProps = { - uiFeature: UIFeature.Feedback, - children:
test
, - }; - const getComponent = (props = {}) => render(); - - beforeEach(() => { - (SettingsStore.getValue as jest.Mock).mockClear().mockReturnValue(true); - }); - - it("renders children when setting is truthy", () => { - const { asFragment } = getComponent(); - - expect(asFragment()).toMatchSnapshot(); - expect(SettingsStore.getValue).toHaveBeenCalledWith(defaultProps.uiFeature); - }); - - it("returns null when setting is truthy but children are undefined", () => { - const { asFragment } = getComponent({ children: undefined }); - - expect(asFragment()).toMatchSnapshot(); - }); - - it("returns null when setting is falsy", () => { - (SettingsStore.getValue as jest.Mock).mockReturnValue(false); - const { asFragment } = getComponent(); - - expect(asFragment()).toMatchSnapshot(); - }); -}); diff --git a/test/components/views/settings/__snapshots__/UiFeatureSettingWrapper-test.tsx.snap b/test/components/views/settings/__snapshots__/UiFeatureSettingWrapper-test.tsx.snap deleted file mode 100644 index 383442c0d5..0000000000 --- a/test/components/views/settings/__snapshots__/UiFeatureSettingWrapper-test.tsx.snap +++ /dev/null @@ -1,13 +0,0 @@ -// Jest Snapshot v1, https://goo.gl/fbAQLP - -exports[` renders children when setting is truthy 1`] = ` - -
- test -
-
-`; - -exports[` returns null when setting is falsy 1`] = ``; - -exports[` returns null when setting is truthy but children are undefined 1`] = ``;