OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Enable skipped tests in `redactions.spec.ts` (#12023)

pull/28788/head^2
Florian Duros 2023-12-11 15:53:00 +01:00 committed by GitHub
parent 6199287fe7
commit 0f42418b5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
playwright/e2e/read-receipts/redactions.spec.ts
View File

@ -206,8 +206,7 @@ test.describe("Read receipts", () => {
// Then the room is back to being read // Then the room is back to being read
await util.assertRead(room2); await util.assertRead(room2);
}); });
// XXX: fails because it flakes saying the room is unread when it should be read test("Redacting all unread messages makes the room read after restart", async ({
test.skip("Redacting all unread messages makes the room read after restart", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -277,8 +276,7 @@ test.describe("Read receipts", () => {
// Then the room is still read // Then the room is still read
await util.assertStillRead(room2); await util.assertStillRead(room2);
}); });
// XXX: fails because flakes showing 2 unread instead of 1 test("A reply to a redacted message makes the room unread", async ({
test.skip("A reply to a redacted message makes the room unread", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -368,8 +366,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2); await util.goTo(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because it flakes (on CI only) test("Reading an unread thread after a redaction of the latest message makes it read", async ({
test.skip("Reading an unread thread after a redaction of the latest message makes it read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -399,8 +396,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2); await util.goTo(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because the unread count is still 1 when it should be 0 test("Reading an unread thread after a redaction of the latest message makes it read after restart", async ({
test.skip("Reading an unread thread after a redaction of the latest message makes it read after restart", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -432,8 +428,7 @@ test.describe("Read receipts", () => {
// Then the room is still read // Then the room is still read
await util.assertRead(room2); await util.assertRead(room2);
}); });
// XXX: fails because it flakes (on CI only) test("Reading an unread thread after a redaction of an older message makes it read", async ({
test.skip("Reading an unread thread after a redaction of an older message makes it read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -463,8 +458,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2); await util.goTo(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because it flakes (on CI only) test("Marking an unread thread as read after a redaction makes it read", async ({
test.skip("Marking an unread thread as read after a redaction makes it read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -490,8 +484,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2); await util.goTo(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because the room has an unread dot after I marked it as read test("Sending and redacting a message after marking the thread as read leaves it read", async ({
test.skip("Sending and redacting a message after marking the thread as read leaves it read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -518,8 +511,7 @@ test.describe("Read receipts", () => {
await util.goTo(room2); await util.goTo(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because the room has an unread dot after I marked it as read test("Redacting a message after marking the thread as read leaves it read", async ({
test.skip("Redacting a message after marking the thread as read leaves it read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -573,8 +565,7 @@ test.describe("Read receipts", () => {
// Then the room is unread // Then the room is unread
await util.assertStillRead(room2); await util.assertStillRead(room2);
}); });
// XXX: fails because the room is still unread after opening the thread (initially) test("Editing a redacted message leaves the thread read", async ({
test.skip("Editing a redacted message leaves the thread read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -602,8 +593,7 @@ test.describe("Read receipts", () => {
// Then the room is unread // Then the room is unread
await util.assertStillRead(room2); await util.assertStillRead(room2);
}); });
// XXX: failed because flakes: https://github.com/vector-im/element-web/issues/26594 test("Reading a thread after a reaction to a redacted message marks the thread as read", async ({
test.skip("Reading a thread after a reaction to a redacted message marks the thread as read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -629,8 +619,7 @@ test.describe("Read receipts", () => {
await util.assertRead(room2); await util.assertRead(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because the unread count stays at 1 instead of zero test("Reading a thread containing a redacted, edited message marks the thread as read", async ({
test.skip("Reading a thread containing a redacted, edited message marks the thread as read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,
@ -681,8 +670,7 @@ test.describe("Read receipts", () => {
await util.assertRead(room2); await util.assertRead(room2);
await util.assertReadThread("Root"); await util.assertReadThread("Root");
}); });
// XXX: fails because flakes saying 2 unread instead of 1 test("Reading a thread root when its only message has been redacted leaves the room read", async ({
test.skip("Reading a thread root when its only message has been redacted leaves the room read", async ({
roomAlpha: room1, roomAlpha: room1,
roomBeta: room2, roomBeta: room2,
util, util,