From 14903274c0b9992a641d80876399837a3140abb0 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 16 Aug 2017 13:20:32 +0100 Subject: [PATCH] Change OOO so that MELS generation will continue over hidden events this fixes the scenario of N Member events, then an invisible event e.g. (m.room.aliases) then more Member events. Pre hide-join-parts this is how it worked. Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/components/structures/MessagePanel.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/structures/MessagePanel.js b/src/components/structures/MessagePanel.js index 02f224e942..a9a14c0870 100644 --- a/src/components/structures/MessagePanel.js +++ b/src/components/structures/MessagePanel.js @@ -339,6 +339,11 @@ module.exports = React.createClass({ for (;i + 1 < this.props.events.length; i++) { const collapsedMxEv = this.props.events[i + 1]; + // Ignore redacted/hidden member events + if (!this._shouldShowEvent(collapsedMxEv)) { + continue; + } + if (!isMembershipChange(collapsedMxEv) || this._wantsDateSeparator(this.props.events[i], collapsedMxEv.getDate())) { break; @@ -349,11 +354,6 @@ module.exports = React.createClass({ readMarkerInMels = true; } - // Ignore redacted/hidden member events - if (!this._shouldShowEvent(collapsedMxEv)) { - continue; - } - summarisedEvents.push(collapsedMxEv); }