From 1f2ba87ff543c6ca7c84ac50b17d3166ec1e7cd4 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Tue, 29 Mar 2016 23:21:17 +0100
Subject: [PATCH] Pass SimpleRoomHeader title in as a named property

... rather than a child
---
 src/components/structures/CreateRoom.js       |  4 +---
 src/components/structures/UserSettings.js     |  4 +---
 .../views/rooms/SimpleRoomHeader.js           | 19 +++++++++----------
 3 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/src/components/structures/CreateRoom.js b/src/components/structures/CreateRoom.js
index 36cc11575b..f6e2baeaf2 100644
--- a/src/components/structures/CreateRoom.js
+++ b/src/components/structures/CreateRoom.js
@@ -255,9 +255,7 @@ module.exports = React.createClass({
 
             return (
             <div className="mx_CreateRoom">
-                <SimpleRoomHeader>
-                    Create room
-                </SimpleRoomHeader>
+                <SimpleRoomHeader title="CreateRoom" />
                 <div className="mx_CreateRoom_body">
                     <input type="text" ref="room_name" value={this.state.room_name} onChange={this.onNameChange} placeholder="Name"/> <br />
                     <textarea className="mx_CreateRoom_description" ref="topic" value={this.state.topic} onChange={this.onTopicChange} placeholder="Topic"/> <br />
diff --git a/src/components/structures/UserSettings.js b/src/components/structures/UserSettings.js
index 6ac8d06f0d..a5f2a59878 100644
--- a/src/components/structures/UserSettings.js
+++ b/src/components/structures/UserSettings.js
@@ -331,9 +331,7 @@ module.exports = React.createClass({
 
         return (
             <div className="mx_UserSettings">
-                <SimpleRoomHeader>
-                    Settings
-                </SimpleRoomHeader>
+                <SimpleRoomHeader title="Settings"/>
 
                 <GeminiScrollbar className="mx_UserSettings_body" autoshow={true}>
 
diff --git a/src/components/views/rooms/SimpleRoomHeader.js b/src/components/views/rooms/SimpleRoomHeader.js
index bd4ed23ebe..8388da4a71 100644
--- a/src/components/views/rooms/SimpleRoomHeader.js
+++ b/src/components/views/rooms/SimpleRoomHeader.js
@@ -25,19 +25,18 @@ var React = require('react');
 module.exports = React.createClass({
     displayName: 'SimpleRoomHeader',
 
-    render: function() {
-        var cancel;
-        var header = (
-            <div className="mx_RoomHeader_wrapper">
-                <div className="mx_RoomHeader_simpleHeader">
-                    { this.props.children }
-                </div>
-            </div>
-        );
+    propTypes: {
+        title: React.PropTypes.string,
+    },
 
+    render: function() {
         return (
             <div className="mx_RoomHeader" >
-                { header }
+                <div className="mx_RoomHeader_wrapper">
+                    <div className="mx_RoomHeader_simpleHeader">
+                        { this.props.title }
+                    </div>
+                </div>
             </div>
         );
     },