OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Consistency, redundant check & doc

pull/21833/head
David Baker 2018-07-05 19:38:42 +01:00
parent eb552e5cef
commit 1f2d279a0a
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/stores/WidgetEchoStore.js
View File

@ -25,6 +25,7 @@ class WidgetEchoStore extends EventEmitter {
super(); super();
this._roomWidgetEcho = { this._roomWidgetEcho = {
// Map as below. For widgets that have been deleted locally, the object is empty.
// roomId: { // roomId: {
// widgetId: [object] // widgetId: [object]
// } // }
@ -49,7 +50,7 @@ class WidgetEchoStore extends EventEmitter {
for (const w of currentRoomWidgets) { for (const w of currentRoomWidgets) {
const widgetId = w.getStateKey(); const widgetId = w.getStateKey();
if (roomEchoState && roomEchoState[widgetId] && Object.keys(roomEchoState[widgetId]).length === 0) { if (roomEchoState[widgetId] && Object.keys(roomEchoState[widgetId]).length === 0) {
// delete locally so don't copy it // delete locally so don't copy it
// we don't include widgets that have changed for the same rason we don't include new ones, // we don't include widgets that have changed for the same rason we don't include new ones,
// so fall into the 'else' case and use the old one // so fall into the 'else' case and use the old one
@ -101,7 +102,7 @@ class WidgetEchoStore extends EventEmitter {
removeRoomWidgetEcho(roomId, widgetId) { removeRoomWidgetEcho(roomId, widgetId) {
delete this._roomWidgetEcho[roomId][widgetId]; delete this._roomWidgetEcho[roomId][widgetId];
if (this._roomWidgetEcho[roomId] === {}) delete this._roomWidgetEcho[roomId]; if (Object.keys(this._roomWidgetEcho[roomId]).length === 0) delete this._roomWidgetEcho[roomId];
this.emit('updateRoomWidgetEcho'); this.emit('updateRoomWidgetEcho');
} }
} }