From 23058112713eb06a459cfd727b96d5becee55d07 Mon Sep 17 00:00:00 2001
From: nurjinn jafar <nurjin.jafar@nordeck.net>
Date: Fri, 18 Dec 2020 15:30:50 +0100
Subject: [PATCH] changed canvas globalCompositeOperation value and removed
 probability

---
 src/effects/fireworks/index.ts | 9 +++------
 src/effects/index.ts           | 2 --
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/effects/fireworks/index.ts b/src/effects/fireworks/index.ts
index 3cc209eda3..b9898b8b22 100644
--- a/src/effects/fireworks/index.ts
+++ b/src/effects/fireworks/index.ts
@@ -26,7 +26,6 @@ export type FireworksOptions = {
      * gravity value that firework adds to shift from it's start position
      */
     gravity: number,
-    probability: number,
 }
 
 type FireworksParticle = {
@@ -58,7 +57,6 @@ type FireworksParticle = {
 export const DefaultOptions: FireworksOptions = {
     maxCount: 500,
     gravity: 0.05,
-    probability: 0.04,
 };
 
 export default class Fireworks implements ICanvasEffect {
@@ -95,7 +93,7 @@ export default class Fireworks implements ICanvasEffect {
         this.supportsAnimationFrame.call(window, this.updateWorld);
     }
     private update = () => {
-        if (this.particles.length < this.options.maxCount && Math.random() < this.options.probability) {
+        if (this.particles.length < this.options.maxCount) {
             this.createFirework();
         }
         const alive = [];
@@ -109,9 +107,8 @@ export default class Fireworks implements ICanvasEffect {
 
     private paint = () => {
         if (!this.context || !this.context.canvas) return;
-        this.context.globalCompositeOperation = 'source-over';
-        this.context.fillStyle = "rgba(0,0,0,0.2)";
-        this.context.canvas.style.opacity = "0.8";
+        this.context.globalCompositeOperation = 'destination-out';
+        this.context.fillStyle = "rgba(0,0,0,0.5)";
         this.context.fillRect(0, 0, this.context.canvas.width, this.context.canvas.height);
         this.context.globalCompositeOperation = 'lighter';
         for (let i=0; i<this.particles.length; i++) {
diff --git a/src/effects/index.ts b/src/effects/index.ts
index 07aaa5e736..990d1e68ef 100644
--- a/src/effects/index.ts
+++ b/src/effects/index.ts
@@ -74,7 +74,6 @@ type FireworksOptions = {
      * gravity value that firework adds to shift from it's start position
      */
     gravity: number,
-    probability: number,
 }
 
 /**
@@ -104,7 +103,6 @@ export const CHAT_EFFECTS: Array<Effect<{ [key: string]: any }>> = [
         options: {
             maxCount: 500,
             gravity: 0.05,
-            probability: 0.04,
         },
     } as Effect<FireworksOptions>,
 ];