OpenCloud
/
element-web
mirror of https://github.com/vector-im/element-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Trigger room-specific watchers whenever a higher level change happens 

Otherwise the room list badges end up having to listen to `null` for a room ID, meaning they have to filter.

The notification badge count setting is the first ever setting to watch based on a room ID, so there are no compatibility concerns with this change.
pull/21833/head
Travis Ralston 2020-06-19 15:45:48 -06:00
parent 13282bddad
commit 241e0c12f0
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/settings/WatchManager.js
View File

@ -51,8 +51,17 @@ export class WatchManager {
const roomWatchers = this._watchers[settingName]; const roomWatchers = this._watchers[settingName];
const callbacks = []; const callbacks = [];
if (inRoomId !== null && roomWatchers[inRoomId]) callbacks.push(...roomWatchers[inRoomId]); if (inRoomId !== null && roomWatchers[inRoomId]) {
if (roomWatchers[null]) callbacks.push(...roomWatchers[null]); callbacks.push(...roomWatchers[inRoomId]);
}
if (!inRoomId) {
// Fire updates to all the individual room watchers too, as they probably
// care about the change higher up.
callbacks.push(...Object.values(roomWatchers).reduce((r, a) => [...r, ...a], []));
} else if (roomWatchers[null]) {
callbacks.push(...roomWatchers[null]);
}
for (const callback of callbacks) { for (const callback of callbacks) {
callback(inRoomId, atLevel, newValueAtLevel); callback(inRoomId, atLevel, newValueAtLevel);