From 1e2cd9c2d173d48cd23321762d09a59fd982769a Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 14:30:12 +0000 Subject: [PATCH 1/8] Build all of the vector dir in the build process So the whole vector/ directory can now be removed during the build process and we don't ship random files that end up in the vector directory. --- .gitignore | 6 +----- vector/config.sample.json => config.sample.json | 0 package.json | 10 +++++++--- {vector => res}/media/busy.mp3 | Bin {vector => res}/media/busy.ogg | Bin {vector => res}/media/callend.mp3 | Bin {vector => res}/media/callend.ogg | Bin {vector => res}/media/message.mp3 | Bin {vector => res}/media/message.ogg | Bin {vector => res}/media/ring.mp3 | Bin {vector => res}/media/ring.ogg | Bin {vector => res}/media/ringback.mp3 | Bin {vector => res}/media/ringback.ogg | Bin .../vector-icons/android-chrome-144x144.png | Bin .../vector-icons/android-chrome-192x192.png | Bin .../vector-icons/android-chrome-36x36.png | Bin .../vector-icons/android-chrome-48x48.png | Bin .../vector-icons/android-chrome-72x72.png | Bin .../vector-icons/android-chrome-96x96.png | Bin .../vector-icons/apple-touch-icon-114x114.png | Bin .../vector-icons/apple-touch-icon-120x120.png | Bin .../vector-icons/apple-touch-icon-144x144.png | Bin .../vector-icons/apple-touch-icon-152x152.png | Bin .../vector-icons/apple-touch-icon-180x180.png | Bin .../vector-icons/apple-touch-icon-57x57.png | Bin .../vector-icons/apple-touch-icon-60x60.png | Bin .../vector-icons/apple-touch-icon-72x72.png | Bin .../vector-icons/apple-touch-icon-76x76.png | Bin .../vector-icons/apple-touch-icon-precomposed.png | Bin {vector => res}/vector-icons/apple-touch-icon.png | Bin {vector => res}/vector-icons/browserconfig.xml | 0 {vector => res}/vector-icons/favicon-16x16.png | Bin {vector => res}/vector-icons/favicon-32x32.png | Bin {vector => res}/vector-icons/favicon-96x96.png | Bin {vector => res}/vector-icons/favicon.ico | Bin {vector => res}/vector-icons/manifest.json | 0 {vector => res}/vector-icons/mstile-144x144.png | Bin {vector => res}/vector-icons/mstile-150x150.png | Bin {vector => res}/vector-icons/mstile-310x150.png | Bin {vector => res}/vector-icons/mstile-310x310.png | Bin {vector => res}/vector-icons/mstile-70x70.png | Bin vector/fonts | 1 - vector/img | 1 - 43 files changed, 8 insertions(+), 10 deletions(-) rename vector/config.sample.json => config.sample.json (100%) rename {vector => res}/media/busy.mp3 (100%) rename {vector => res}/media/busy.ogg (100%) rename {vector => res}/media/callend.mp3 (100%) rename {vector => res}/media/callend.ogg (100%) rename {vector => res}/media/message.mp3 (100%) rename {vector => res}/media/message.ogg (100%) rename {vector => res}/media/ring.mp3 (100%) rename {vector => res}/media/ring.ogg (100%) rename {vector => res}/media/ringback.mp3 (100%) rename {vector => res}/media/ringback.ogg (100%) rename {vector => res}/vector-icons/android-chrome-144x144.png (100%) rename {vector => res}/vector-icons/android-chrome-192x192.png (100%) rename {vector => res}/vector-icons/android-chrome-36x36.png (100%) rename {vector => res}/vector-icons/android-chrome-48x48.png (100%) rename {vector => res}/vector-icons/android-chrome-72x72.png (100%) rename {vector => res}/vector-icons/android-chrome-96x96.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-114x114.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-120x120.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-144x144.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-152x152.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-180x180.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-57x57.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-60x60.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-72x72.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-76x76.png (100%) rename {vector => res}/vector-icons/apple-touch-icon-precomposed.png (100%) rename {vector => res}/vector-icons/apple-touch-icon.png (100%) rename {vector => res}/vector-icons/browserconfig.xml (100%) rename {vector => res}/vector-icons/favicon-16x16.png (100%) rename {vector => res}/vector-icons/favicon-32x32.png (100%) rename {vector => res}/vector-icons/favicon-96x96.png (100%) rename {vector => res}/vector-icons/favicon.ico (100%) rename {vector => res}/vector-icons/manifest.json (100%) rename {vector => res}/vector-icons/mstile-144x144.png (100%) rename {vector => res}/vector-icons/mstile-150x150.png (100%) rename {vector => res}/vector-icons/mstile-310x150.png (100%) rename {vector => res}/vector-icons/mstile-310x310.png (100%) rename {vector => res}/vector-icons/mstile-70x70.png (100%) delete mode 120000 vector/fonts delete mode 120000 vector/img diff --git a/.gitignore b/.gitignore index d3ad95583f..8ff6a67965 100644 --- a/.gitignore +++ b/.gitignore @@ -6,11 +6,7 @@ /lib /node_modules /packages/ -/vector/bundle.* -/vector/emojione/ -/vector/config.json -/vector/index.html -/vector/olm.* +/vector .DS_Store npm-debug.log electron/dist diff --git a/vector/config.sample.json b/config.sample.json similarity index 100% rename from vector/config.sample.json rename to config.sample.json diff --git a/package.json b/package.json index f31f024aef..c9f54dc75d 100644 --- a/package.json +++ b/package.json @@ -27,6 +27,8 @@ "matrix-react-parent": "matrix-react-sdk", "scripts": { "reskindex": "reskindex -h src/header", + "build:res": "cpx \"{src/skins/vector/fonts,src/skins/vector/img}/**\" vector/ && cpx \"{res/media,res/vector-icons}/**\" vector/", + "build:config": "cpx config.json vector/", "build:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/", "build:modernizr": "modernizr -c .modernizr.json -d src/vector/modernizr.js", "build:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css --no-watch", @@ -34,16 +36,18 @@ "build:bundle": "NODE_ENV=production webpack -p --progress", "build:bundle:dev": "webpack --optimize-occurence-order --progress", "build:electron": "build -lwm", - "build": "node scripts/babelcheck.js && npm run build:emojione && npm run build:css && npm run build:bundle", + "build": "node scripts/babelcheck.js && npm run build:res && npm run build:config && npm run build:emojione && npm run build:css && npm run build:bundle", "build:dev": "npm run build:emojione && npm run build:css && npm run build:bundle:dev", "dist": "scripts/package.sh", + "start:res": "parallelshell \"cpx -w \\\"{src/skins/vector/fonts,src/skins/vector/img}/**\\\" vector/\" \"cpx \\\"{res/media,res/vector-icons}/**\\\" vector/\"", + "start:config": "cpx -w config.json vector/", "start:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/ -w", "start:js": "webpack-dev-server -w --progress", "start:js:prod": "NODE_ENV=production webpack-dev-server -w --progress", "start:skins:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css", - "start": "node scripts/babelcheck.js && parallelshell \"npm run start:emojione\" \"npm run start:js\" \"npm run start:skins:css\"", + "start": "node scripts/babelcheck.js && parallelshell \"npm run start:emojione\" \"npm run start:res\" \"npm run start:config\" \"npm run start:js\" \"npm run start:skins:css\"", "start:prod": "parallelshell \"npm run start:emojione\" \"npm run start:js:prod\" \"npm run start:skins:css\"", - "clean": "rimraf build lib vector/olm.* vector/bundle.* vector/emojione vector/index.html", + "clean": "rimraf build lib vector", "prepublish": "npm run build:compile", "test": "karma start --single-run=true --autoWatch=false --browsers PhantomJS --colors=false", "test:multi": "karma start" diff --git a/vector/media/busy.mp3 b/res/media/busy.mp3 similarity index 100% rename from vector/media/busy.mp3 rename to res/media/busy.mp3 diff --git a/vector/media/busy.ogg b/res/media/busy.ogg similarity index 100% rename from vector/media/busy.ogg rename to res/media/busy.ogg diff --git a/vector/media/callend.mp3 b/res/media/callend.mp3 similarity index 100% rename from vector/media/callend.mp3 rename to res/media/callend.mp3 diff --git a/vector/media/callend.ogg b/res/media/callend.ogg similarity index 100% rename from vector/media/callend.ogg rename to res/media/callend.ogg diff --git a/vector/media/message.mp3 b/res/media/message.mp3 similarity index 100% rename from vector/media/message.mp3 rename to res/media/message.mp3 diff --git a/vector/media/message.ogg b/res/media/message.ogg similarity index 100% rename from vector/media/message.ogg rename to res/media/message.ogg diff --git a/vector/media/ring.mp3 b/res/media/ring.mp3 similarity index 100% rename from vector/media/ring.mp3 rename to res/media/ring.mp3 diff --git a/vector/media/ring.ogg b/res/media/ring.ogg similarity index 100% rename from vector/media/ring.ogg rename to res/media/ring.ogg diff --git a/vector/media/ringback.mp3 b/res/media/ringback.mp3 similarity index 100% rename from vector/media/ringback.mp3 rename to res/media/ringback.mp3 diff --git a/vector/media/ringback.ogg b/res/media/ringback.ogg similarity index 100% rename from vector/media/ringback.ogg rename to res/media/ringback.ogg diff --git a/vector/vector-icons/android-chrome-144x144.png b/res/vector-icons/android-chrome-144x144.png similarity index 100% rename from vector/vector-icons/android-chrome-144x144.png rename to res/vector-icons/android-chrome-144x144.png diff --git a/vector/vector-icons/android-chrome-192x192.png b/res/vector-icons/android-chrome-192x192.png similarity index 100% rename from vector/vector-icons/android-chrome-192x192.png rename to res/vector-icons/android-chrome-192x192.png diff --git a/vector/vector-icons/android-chrome-36x36.png b/res/vector-icons/android-chrome-36x36.png similarity index 100% rename from vector/vector-icons/android-chrome-36x36.png rename to res/vector-icons/android-chrome-36x36.png diff --git a/vector/vector-icons/android-chrome-48x48.png b/res/vector-icons/android-chrome-48x48.png similarity index 100% rename from vector/vector-icons/android-chrome-48x48.png rename to res/vector-icons/android-chrome-48x48.png diff --git a/vector/vector-icons/android-chrome-72x72.png b/res/vector-icons/android-chrome-72x72.png similarity index 100% rename from vector/vector-icons/android-chrome-72x72.png rename to res/vector-icons/android-chrome-72x72.png diff --git a/vector/vector-icons/android-chrome-96x96.png b/res/vector-icons/android-chrome-96x96.png similarity index 100% rename from vector/vector-icons/android-chrome-96x96.png rename to res/vector-icons/android-chrome-96x96.png diff --git a/vector/vector-icons/apple-touch-icon-114x114.png b/res/vector-icons/apple-touch-icon-114x114.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-114x114.png rename to res/vector-icons/apple-touch-icon-114x114.png diff --git a/vector/vector-icons/apple-touch-icon-120x120.png b/res/vector-icons/apple-touch-icon-120x120.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-120x120.png rename to res/vector-icons/apple-touch-icon-120x120.png diff --git a/vector/vector-icons/apple-touch-icon-144x144.png b/res/vector-icons/apple-touch-icon-144x144.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-144x144.png rename to res/vector-icons/apple-touch-icon-144x144.png diff --git a/vector/vector-icons/apple-touch-icon-152x152.png b/res/vector-icons/apple-touch-icon-152x152.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-152x152.png rename to res/vector-icons/apple-touch-icon-152x152.png diff --git a/vector/vector-icons/apple-touch-icon-180x180.png b/res/vector-icons/apple-touch-icon-180x180.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-180x180.png rename to res/vector-icons/apple-touch-icon-180x180.png diff --git a/vector/vector-icons/apple-touch-icon-57x57.png b/res/vector-icons/apple-touch-icon-57x57.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-57x57.png rename to res/vector-icons/apple-touch-icon-57x57.png diff --git a/vector/vector-icons/apple-touch-icon-60x60.png b/res/vector-icons/apple-touch-icon-60x60.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-60x60.png rename to res/vector-icons/apple-touch-icon-60x60.png diff --git a/vector/vector-icons/apple-touch-icon-72x72.png b/res/vector-icons/apple-touch-icon-72x72.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-72x72.png rename to res/vector-icons/apple-touch-icon-72x72.png diff --git a/vector/vector-icons/apple-touch-icon-76x76.png b/res/vector-icons/apple-touch-icon-76x76.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-76x76.png rename to res/vector-icons/apple-touch-icon-76x76.png diff --git a/vector/vector-icons/apple-touch-icon-precomposed.png b/res/vector-icons/apple-touch-icon-precomposed.png similarity index 100% rename from vector/vector-icons/apple-touch-icon-precomposed.png rename to res/vector-icons/apple-touch-icon-precomposed.png diff --git a/vector/vector-icons/apple-touch-icon.png b/res/vector-icons/apple-touch-icon.png similarity index 100% rename from vector/vector-icons/apple-touch-icon.png rename to res/vector-icons/apple-touch-icon.png diff --git a/vector/vector-icons/browserconfig.xml b/res/vector-icons/browserconfig.xml similarity index 100% rename from vector/vector-icons/browserconfig.xml rename to res/vector-icons/browserconfig.xml diff --git a/vector/vector-icons/favicon-16x16.png b/res/vector-icons/favicon-16x16.png similarity index 100% rename from vector/vector-icons/favicon-16x16.png rename to res/vector-icons/favicon-16x16.png diff --git a/vector/vector-icons/favicon-32x32.png b/res/vector-icons/favicon-32x32.png similarity index 100% rename from vector/vector-icons/favicon-32x32.png rename to res/vector-icons/favicon-32x32.png diff --git a/vector/vector-icons/favicon-96x96.png b/res/vector-icons/favicon-96x96.png similarity index 100% rename from vector/vector-icons/favicon-96x96.png rename to res/vector-icons/favicon-96x96.png diff --git a/vector/vector-icons/favicon.ico b/res/vector-icons/favicon.ico similarity index 100% rename from vector/vector-icons/favicon.ico rename to res/vector-icons/favicon.ico diff --git a/vector/vector-icons/manifest.json b/res/vector-icons/manifest.json similarity index 100% rename from vector/vector-icons/manifest.json rename to res/vector-icons/manifest.json diff --git a/vector/vector-icons/mstile-144x144.png b/res/vector-icons/mstile-144x144.png similarity index 100% rename from vector/vector-icons/mstile-144x144.png rename to res/vector-icons/mstile-144x144.png diff --git a/vector/vector-icons/mstile-150x150.png b/res/vector-icons/mstile-150x150.png similarity index 100% rename from vector/vector-icons/mstile-150x150.png rename to res/vector-icons/mstile-150x150.png diff --git a/vector/vector-icons/mstile-310x150.png b/res/vector-icons/mstile-310x150.png similarity index 100% rename from vector/vector-icons/mstile-310x150.png rename to res/vector-icons/mstile-310x150.png diff --git a/vector/vector-icons/mstile-310x310.png b/res/vector-icons/mstile-310x310.png similarity index 100% rename from vector/vector-icons/mstile-310x310.png rename to res/vector-icons/mstile-310x310.png diff --git a/vector/vector-icons/mstile-70x70.png b/res/vector-icons/mstile-70x70.png similarity index 100% rename from vector/vector-icons/mstile-70x70.png rename to res/vector-icons/mstile-70x70.png diff --git a/vector/fonts b/vector/fonts deleted file mode 120000 index 1c206eff7c..0000000000 --- a/vector/fonts +++ /dev/null @@ -1 +0,0 @@ -../src/skins/vector/fonts \ No newline at end of file diff --git a/vector/img b/vector/img deleted file mode 120000 index 855fa9738f..0000000000 --- a/vector/img +++ /dev/null @@ -1 +0,0 @@ -../src/skins/vector/img/ \ No newline at end of file From d150ee0d05955190ac4759c9539f3df4d2d5f0c8 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 15:30:19 +0000 Subject: [PATCH 2/8] Missed a -w --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c9f54dc75d..bf3b43e1f0 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "build": "node scripts/babelcheck.js && npm run build:res && npm run build:config && npm run build:emojione && npm run build:css && npm run build:bundle", "build:dev": "npm run build:emojione && npm run build:css && npm run build:bundle:dev", "dist": "scripts/package.sh", - "start:res": "parallelshell \"cpx -w \\\"{src/skins/vector/fonts,src/skins/vector/img}/**\\\" vector/\" \"cpx \\\"{res/media,res/vector-icons}/**\\\" vector/\"", + "start:res": "parallelshell \"cpx -w \\\"{src/skins/vector/fonts,src/skins/vector/img}/**\\\" vector/\" \"cpx -w \\\"{res/media,res/vector-icons}/**\\\" vector/\"", "start:config": "cpx -w config.json vector/", "start:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/ -w", "start:js": "webpack-dev-server -w --progress", From 5b7f6299966b5556b8bc4fc021a9e9d2e5099604 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 15:46:21 +0000 Subject: [PATCH 3/8] Build to the 'webapp' directory instead People may have config files in vector/ so it would be nonideal if we started overwriting them / blowing them away. --- electron/src/electron-main.js | 2 +- package.json | 18 +++++++++--------- scripts/package.sh | 3 ++- webpack.config.js | 6 +++--- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/electron/src/electron-main.js b/electron/src/electron-main.js index 59cbca428e..18758eee90 100644 --- a/electron/src/electron-main.js +++ b/electron/src/electron-main.js @@ -160,7 +160,7 @@ electron.app.on('ready', () => { icon: `${__dirname}/../img/riot.ico`, width: 1024, height: 768, }); - mainWindow.loadURL(`file://${__dirname}/../../vector/index.html`); + mainWindow.loadURL(`file://${__dirname}/../../webapp/index.html`); electron.Menu.setApplicationMenu(VectorMenu); mainWindow.on('closed', () => { diff --git a/package.json b/package.json index bf3b43e1f0..93bfaceab9 100644 --- a/package.json +++ b/package.json @@ -27,9 +27,9 @@ "matrix-react-parent": "matrix-react-sdk", "scripts": { "reskindex": "reskindex -h src/header", - "build:res": "cpx \"{src/skins/vector/fonts,src/skins/vector/img}/**\" vector/ && cpx \"{res/media,res/vector-icons}/**\" vector/", - "build:config": "cpx config.json vector/", - "build:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/", + "build:res": "cpx \"{src/skins/vector/fonts,src/skins/vector/img}/**\" webapp/ && cpx \"{res/media,res/vector-icons}/**\" webapp/", + "build:config": "cpx config.json webapp/", + "build:emojione": "cpx \"node_modules/emojione/assets/svg/*\" webapp/emojione/svg/", "build:modernizr": "modernizr -c .modernizr.json -d src/vector/modernizr.js", "build:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css --no-watch", "build:compile": "babel --source-maps -d lib src", @@ -39,15 +39,15 @@ "build": "node scripts/babelcheck.js && npm run build:res && npm run build:config && npm run build:emojione && npm run build:css && npm run build:bundle", "build:dev": "npm run build:emojione && npm run build:css && npm run build:bundle:dev", "dist": "scripts/package.sh", - "start:res": "parallelshell \"cpx -w \\\"{src/skins/vector/fonts,src/skins/vector/img}/**\\\" vector/\" \"cpx -w \\\"{res/media,res/vector-icons}/**\\\" vector/\"", - "start:config": "cpx -w config.json vector/", - "start:emojione": "cpx \"node_modules/emojione/assets/svg/*\" vector/emojione/svg/ -w", + "start:res": "parallelshell \"cpx -w \\\"{src/skins/vector/fonts,src/skins/vector/img}/**\\\" webapp/\" \"cpx -w \\\"{res/media,res/vector-icons}/**\\\" webapp/\"", + "start:config": "cpx -w config.json webapp/", + "start:emojione": "cpx \"node_modules/emojione/assets/svg/*\" webapp/emojione/svg/ -w", "start:js": "webpack-dev-server -w --progress", "start:js:prod": "NODE_ENV=production webpack-dev-server -w --progress", "start:skins:css": "mkdirp build && catw \"src/skins/vector/css/**/*.css\" -o build/components.css", "start": "node scripts/babelcheck.js && parallelshell \"npm run start:emojione\" \"npm run start:res\" \"npm run start:config\" \"npm run start:js\" \"npm run start:skins:css\"", "start:prod": "parallelshell \"npm run start:emojione\" \"npm run start:js:prod\" \"npm run start:skins:css\"", - "clean": "rimraf build lib vector", + "clean": "rimraf build lib webapp", "prepublish": "npm run build:compile", "test": "karma start --single-run=true --autoWatch=false --browsers PhantomJS --colors=false", "test:multi": "karma start" @@ -132,12 +132,12 @@ "//asar=false": "https://github.com/electron-userland/electron-builder/issues/675", "asar": false, "dereference": true, - "//files": "We bundle everything, so we only need to include vector/", + "//files": "We bundle everything, so we only need to include webapp/", "files": [ "!**/*", "electron/src/**", "electron/img/**", - "vector/**", + "webapp/**", "package.json" ], "squirrelWindows": { diff --git a/scripts/package.sh b/scripts/package.sh index d5deffef64..35f6f92a5a 100755 --- a/scripts/package.sh +++ b/scripts/package.sh @@ -8,9 +8,10 @@ else version=`git describe --dirty --tags || echo unknown` fi +npm run clean npm run build mkdir -p dist -cp -r vector vector-$version +cp -r webapp vector-$version echo $version > vector-$version/version tar chvzf dist/vector-$version.tar.gz vector-$version rm -r vector-$version diff --git a/webpack.config.js b/webpack.config.js index 5d669bd2c3..4f350dd431 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -39,7 +39,7 @@ module.exports = { ], }, output: { - path: path.join(__dirname, "vector"), + path: path.join(__dirname, "webapp"), filename: "[name].[chunkhash].js", devtoolModuleFilenameTemplate: function(info) { // Reading input source maps gives only relative paths here for @@ -98,8 +98,8 @@ module.exports = { // configuration for the webpack-dev-server devServer: { - // serve unwebpacked assets from vector. - contentBase: './vector', + // serve unwebpacked assets from webapp. + contentBase: './webapp', }, }; From c8a6be1454c1e5ecfdb44dcb4304c81ed00ac4a8 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 16:14:57 +0000 Subject: [PATCH 4/8] Update gitignore --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 8ff6a67965..2e34b6c1c1 100644 --- a/.gitignore +++ b/.gitignore @@ -6,7 +6,7 @@ /lib /node_modules /packages/ -/vector +/webapp .DS_Store npm-debug.log electron/dist From 3b065639601baeecd243f31e5a019ca751b47aa0 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 17:08:01 +0000 Subject: [PATCH 5/8] Fix jenkins script / redeployer and make them re-use the package script rather than doing their own thing --- deploy/redeploy.py | 13 +++++-------- jenkins.sh | 8 ++------ scripts/package.sh | 7 ++++++- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/deploy/redeploy.py b/deploy/redeploy.py index 2839422bde..6e6e64aa15 100755 --- a/deploy/redeploy.py +++ b/deploy/redeploy.py @@ -110,20 +110,17 @@ def on_receive_jenkins_poke(): filename = download_file(tar_gz_url) print("Downloaded file: %s" % filename) name_str = filename.replace(".tar.gz", "") - untar_location = os.path.join(arg_extract_path, name_str) - untar_to(filename, untar_location) + untar_to(filename, arg_extract_path) + + extracted_dir = os.path.join(arg_extract_path, name_str) if arg_should_clean: os.remove(filename) - # stamp the version somewhere JS can get to it - with open(os.path.join(untar_location, "vector/version"), "w") as stamp_file: - stamp_file.write(name_str) - - create_symlink(source=os.path.join(untar_location, "vector"), linkname=arg_symlink) + create_symlink(source=extracted_dir, linkname=arg_symlink) if arg_config_location: - create_symlink(source=arg_config_location, linkname=os.path.join(untar_location, "vector", 'config.json')) + create_symlink(source=arg_config_location, linkname=os.path.join(extracted_dir, 'config.json')) return jsonify({}) diff --git a/jenkins.sh b/jenkins.sh index 2bccf0f88c..4cc141f0bc 100755 --- a/jenkins.sh +++ b/jenkins.sh @@ -25,11 +25,7 @@ cp -r olm/package node_modules/olm # run the mocha tests npm run test -# build our artifacts; dumps them in ./vector -npm run build:dev - -# gzip up ./vector -rm vector-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist +rm packages/vector-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist # node_modules deps from 'npm install' don't have a .git dir so can't # rev-parse; but they do set the commit in package.json under 'gitHead' which @@ -39,4 +35,4 @@ JSSDK_SHA=$(grep 'gitHead' node_modules/matrix-js-sdk/package.json | cut -d \" - VECTOR_SHA=$(git rev-parse --short=12 HEAD) # use the ACTUAL SHA rather than assume develop -tar -zcvhf vector-$VECTOR_SHA-react-$REACT_SHA-js-$JSSDK_SHA.tar.gz vector #g[z]ip, [c]reate archive, [v]erbose, [f]ilename, [h]ard-dereference (do not archive symlinks) +DIST_VERSION=vector-$VECTOR_SHA-react-$REACT_SHA-js-$JSSDK_SHA scripts/package.sh -d diff --git a/scripts/package.sh b/scripts/package.sh index 35f6f92a5a..9ae2901ab0 100755 --- a/scripts/package.sh +++ b/scripts/package.sh @@ -2,6 +2,11 @@ set -e +dev="" +if [ "$1" == '-d' ]; then + dev=":dev" +fi + if [ -n "$DIST_VERSION" ]; then version=$DIST_VERSION else @@ -9,7 +14,7 @@ else fi npm run clean -npm run build +npm run build$dev mkdir -p dist cp -r webapp vector-$version echo $version > vector-$version/version From 1401de2e7da72f4d8c0d6a85cf9d03554b5968b1 Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 17:09:44 +0000 Subject: [PATCH 6/8] Move the jenkins / redeploy scripts to scripts While we're breaking things anyway --- jenkins.sh => scripts/jenkins.sh | 0 {deploy => scripts}/redeploy.py | 0 2 files changed, 0 insertions(+), 0 deletions(-) rename jenkins.sh => scripts/jenkins.sh (100%) rename {deploy => scripts}/redeploy.py (100%) diff --git a/jenkins.sh b/scripts/jenkins.sh similarity index 100% rename from jenkins.sh rename to scripts/jenkins.sh diff --git a/deploy/redeploy.py b/scripts/redeploy.py similarity index 100% rename from deploy/redeploy.py rename to scripts/redeploy.py From 8676481aab8679c93b9222f2454abda5763055ae Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 8 Nov 2016 17:37:49 +0000 Subject: [PATCH 7/8] dist now, not packages --- scripts/jenkins.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/jenkins.sh b/scripts/jenkins.sh index 4cc141f0bc..58f214b817 100755 --- a/scripts/jenkins.sh +++ b/scripts/jenkins.sh @@ -25,7 +25,7 @@ cp -r olm/package node_modules/olm # run the mocha tests npm run test -rm packages/vector-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist +rm dist/vector-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist # node_modules deps from 'npm install' don't have a .git dir so can't # rev-parse; but they do set the commit in package.json under 'gitHead' which