add additional checks for hiding autocomplete to prevent `text` calculation

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
pull/21833/head
Michael Telatynski 2018-07-16 21:27:52 +01:00
parent bdbc2cbd38
commit 3000099991
No known key found for this signature in database
GPG Key ID: 3F879DA5AD802A5E
1 changed files with 5 additions and 3 deletions

View File

@ -498,10 +498,12 @@ export default class MessageComposerInput extends React.Component {
} }
} }
// when selection changes hide the autocomplete. // when in autocomplete mode and selection changes hide the autocomplete.
// Selection changes when we enter text so use a heuristic to compare documents without doing it recursively // Selection changes when we enter text so use a heuristic to compare documents without doing it recursively
const documentChanged = this.state.editorState.document.text !== editorState.document.text; if (this.autocomplete.state.completionList.length >= 0 && !this.autocomplete.state.hide &&
if (!documentChanged && !rangeEquals(this.state.editorState.selection, editorState.selection)) { this.state.editorState.document.text !== editorState.document.text &&
!rangeEquals(this.state.editorState.selection, editorState.selection))
{
this.autocomplete.hide(); this.autocomplete.hide();
} }